Skip to contentSkip to conversation

ASoC: pxa-ssp: allow setting of dai format 0

PATCH Applied Daniel Mack 2 participants 2 messages Apr 15, 2009

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ASoC: pxa-ssp: allow setting of dai format 0

pxa_ssp_set_dai_fmt() currently has an early exit if the desired format equals the current configuration. This is correct behaviour unless this function is called with a zero value parameter for the first time. Zero is a valid value for this function, but the early exit is bogus in this case.

Hence, set priv->dai_fmt to -1 in the beginning so we can configure the port.

Cc Mark Brown <[email protected]>
Cc pHilipp Zabel <[email protected]>
---
 sound/soc/pxa/pxa-ssp.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
sound/soc/pxa/pxa-ssp.c +1 -0
index 308a657..de22544 100644
@@ -806,6 +806,7 @@ static int pxa_ssp_probe(struct platform_device *pdev,
 		goto err_priv;
 	}
 
+	priv->dai_fmt = (unsigned int) -1;
 	dai->private_data = priv;
 
 	return 0;
Signature · 1 line
1.6.2.1
Applied
#1 lore raw
Quoted 5 lines · Daniel Mack

pxa_ssp_set_dai_fmt() currently has an early exit if the desired format equals the current configuration. This is correct behaviour unless this function is called with a zero value parameter for the first time. Zero is a valid value for this function, but the early exit is bogus in this case.

Applied, thanks.