Skip to contentSkip to conversation

mtd: physmap_of: Add multiple regions and concatenation support

PATCH In review Stefan Roese 4 participants 5 messages Apr 16, 2009 1 message not in the archive Memory technology devices (MTD)

lore
Share & tools
lore
#0 lore raw

v3 cover mtd: physmap_of: Add multiple regions and concatenation support

This patchset adds support to handle multiple non-identical chips in one flash device tree node. It also adds concat support to physmap_of. This makes it possible to support e.g. the Intel P30 48F4400 chip which internally consists of 2 non-identical NOR chips on one die. Additionally partitions now can span over multiple chips:

mtd: physmap_of: Add multiple regions and concatenation support mtd/powerpc: Factor out MTD physmap bindings into mtd-physmap.txt mtd/powerpc: Describe multiple "reg" tuples usage

v2 addresses all comments from Grant Likely, including factoring out the MTD dts bindings documentation into a separate file.

v3 addresses all comments (again from Grant).

Thanks,
Stefan

#1 lore raw
Quoted 6 lines · Stefan Roese

This patchset adds support to handle multiple non-identical chips in one flash device tree node. It also adds concat support to physmap_of. This makes it possible to support e.g. the Intel P30 48F4400 chip which internally consists of 2 non-identical NOR chips on one die. Additionally partitions now can span over multiple chips:

Quoted 8 lines

mtd: physmap_of: Add multiple regions and concatenation support mtd/powerpc: Factor out MTD physmap bindings into mtd-physmap.txt mtd/powerpc: Describe multiple "reg" tuples usage

v2 addresses all comments from Grant Likely, including factoring out the MTD dts bindings documentation into a separate file.

v3 addresses all comments (again from Grant).

Sorry for my ignorance, but could you please explain why regions exists as an MTD concept? Why different regions could not be represented as different MTD devices? The benefit is - simplicity.

Thanks.

Signature · 7 lines
Best regards,
Artem Bityutskiy (Битюцкий Артём)


______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
#2 lore raw
Quoted 11 lines · Artem Bityutskiy
Quoted 10 lines · Stefan Roese

This patchset adds support to handle multiple non-identical chips in one flash device tree node. It also adds concat support to physmap_of. This makes it possible to support e.g. the Intel P30 48F4400 chip which internally consists of 2 non-identical NOR chips on one die. Additionally partitions now can span over multiple chips:

mtd: physmap_of: Add multiple regions and concatenation support mtd/powerpc: Factor out MTD physmap bindings into mtd-physmap.txt mtd/powerpc: Describe multiple "reg" tuples usage

Quoted 8 lines
Quoted 4 lines

v2 addresses all comments from Grant Likely, including factoring out the MTD dts bindings documentation into a separate file.

v3 addresses all comments (again from Grant).

Sorry for my ignorance, but could you please explain why regions exists as an MTD concept? Why different regions could not be represented as different MTD devices? The benefit is - simplicity.

The result of these multiple "reg" tuples *is* multiple MTD devices. Not sure if this explains your comment/question. Please let me know if you still have some comments.

Thanks.

Best regards,
Stefan

#3 lore raw
Quoted 17 lines · Stefan Roese
Quoted 16 lines · Artem Bityutskiy
Quoted 14 lines · Stefan Roese

This patchset adds support to handle multiple non-identical chips in one flash device tree node. It also adds concat support to physmap_of. This makes it possible to support e.g. the Intel P30 48F4400 chip which internally consists of 2 non-identical NOR chips on one die. Additionally partitions now can span over multiple chips:

mtd: physmap_of: Add multiple regions and concatenation support mtd/powerpc: Factor out MTD physmap bindings into mtd-physmap.txt mtd/powerpc: Describe multiple "reg" tuples usage

v2 addresses all comments from Grant Likely, including factoring out the MTD dts bindings documentation into a separate file.

v3 addresses all comments (again from Grant).

Quoted 7 lines
Quoted 3 lines

Sorry for my ignorance, but could you please explain why regions exists as an MTD concept? Why different regions could not be represented as different MTD devices? The benefit is - simplicity.

The result of these multiple "reg" tuples *is* multiple MTD devices. Not sure if this explains your comment/question. Please let me know if you still have some comments.

OK, I was confused. In MTD there is a weird notion of "region". See 'struct mtd_info':

        /* Data for variable erase regions. If numeraseregions is zero,
         * it means that the whole device has erasesize as given above.
         */
        int numeraseregions;
        struct mtd_erase_region_info *eraseregions;

in include/linux/mtd/mtd.h

I thought you use that, and wanted to realize why is that "region" notion needed.

Signature · 7 lines
Best regards,
Artem Bityutskiy (Битюцкий Артём)

_______________________________________________
Linuxppc-dev mailing list
[email protected]
https://ozlabs.org/mailman/listinfo/linuxppc-dev

A message that is not in the archive (sent off-list or not yet received): 1239884344.3390.213.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/[email protected]

#5 lore raw
Quoted 11 lines · Artem Bityutskiy
Quoted 10 lines · Stefan Roese

This patchset adds support to handle multiple non-identical chips in one flash device tree node. It also adds concat support to physmap_of. This makes it possible to support e.g. the Intel P30 48F4400 chip which internally consists of 2 non-identical NOR chips on one die. Additionally partitions now can span over multiple chips:

    mtd: physmap_of: Add multiple regions and concatenation support mtd/powerpc: Factor out MTD physmap bindings into mtd-physmap.txt mtd/powerpc: Describe multiple "reg" tuples usage

Quoted 8 lines
Quoted 4 lines

v2 addresses all comments from Grant Likely, including factoring out the MTD dts bindings documentation into a separate file.

v3 addresses all comments (again from Grant).

Sorry for my ignorance, but could you please explain why regions exists as an MTD concept? Why different regions could not be represented as different MTD devices? The benefit is - simplicity.

Trying to describe MTD partitions that span device boundaries in the device tree is far simpler if a single node is used. It is also a common case for hardware designers to drop down multiple NOR devices to be used as a single flash region, so it makes sense to describe it as a single device.

g.

Quoted 8 lines

Thanks.

--
Best regards,
Artem Bityutskiy (Битюцкий Артём)

Signature · 6 lines
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
_______________________________________________
devicetree-discuss mailing list
[email protected]
https://ozlabs.org/mailman/listinfo/devicetree-discuss