Fix an errorneous using of a different return value in selinux_entrypoint test
PATCH 1/1 Fix an errorneous using of a different return value in selinux_entrypoint test
Stephen ??
-------- Forwarded Message --------
From: Jiri Palecek > <<[email protected]>
Cc: [email protected] <[email protected]>
Subject: [LTP] [PATCH] Fix an errorneous using of a different return value in selinux_entrypoint test
Date: Thu, 16 Apr 2009 17:59:00 +0200
Hello,
I have been trying to run the selinux tests on Debian and discovered a small flaw. The test was using a return value variable which wasn't set by the test.
I've coma across another strange (at least to me) fact - when you execute a program without path, it is searched for in $PATH. However, if the program is in one directory if $PATH and selinux rejects to run the file, the following directories in $PATH are search, and the call can succeed. Is this behavior planned? I know it can't tamper the security of selinux, but it can lead to surprising results.
Also, I've found some uses of macros not present in Debian's refpolicy. Should I send a patch for them?
Regards
Jiri Palecek
--- .../tests/entrypoint/selinux_entrypoint.sh | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)
testcases/kernel/security/selinux-testsuite/tests/entrypoint/selinux_entrypoint.sh +1 -0
@@ -52,6 +52,7 @@ test02() # Verify that test_entrypoint_t can be entered via this program. runcon -t test_entrypoint_t $SELINUXTMPDIR/true + RC=$? if [ $RC -ne 0 ] then echo "$TCID FAIL : entrypoint failed."
--
This message was distributed to subscribers of the selinux mailing list. If you no longer wish to subscribe, send mail to [email protected] with the words "unsubscribe selinux" without quotes as the message.
Quoted 1 line · Subrata Modak
Stephen ??
Heh, this isn't an selinux issue, just trivially correct.
-serge
Quoted 39 lines
-------- Forwarded Message --------
From: Jiri Palecek > <<[email protected]>
Cc: [email protected] <[email protected]>
Subject: [LTP] [PATCH] Fix an errorneous using of a different return value inselinux_entrypointtest
Date: Thu, 16 Apr 2009 17:59:00 +0200Hello,
I have been trying to run the selinux tests on Debian and discovered a small flaw. The test was using a return value variable which wasn't set by the test.
I've coma across another strange (at least to me) fact - when you execute a program without path, it is searched for in $PATH. However, if the program is in one directory if $PATH and selinux rejects to run the file, the following directories in $PATH are search, and the call can succeed. Is this behavior planned? I know it can't tamper the security of selinux, but it can lead to surprising results.
Also, I've found some uses of macros not present in Debian's refpolicy. Should I send a patch for them?
Regards
Jiri PalecekSigned-off-by Jiri Palecek <[email protected]>--- .../tests/entrypoint/selinux_entrypoint.sh | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)testcases/kernel/security/selinux-testsuite/tests/entrypoint/selinux_entrypoint.sh +1
-1@@ -52,6 +52,7 @@ test02() # Verify that test_entrypoint_t can be entered via this program. runcon -t test_entrypoint_t $SELINUXTMPDIR/true + RC=$? if [ $RC -ne 0 ] then echo "$TCID FAIL : entrypoint failed." ------------------------------------------------------------------------------Stay on top of everything new and different, both inside and
Quoted 8 lines
around Java (TM) technology - register by April 22, and save $200 on the JavaOne (SM) conference, June 2-5, 2009, San Francisco. 300 plus technical and hands-on sessions. Register today. Use priority code J9JMT32. http://p.sf.net/sfu/p
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list
--
This message was distributed to subscribers of the selinux mailing list. If you no longer wish to subscribe, send mail to [email protected] with the words "unsubscribe selinux" without quotes as the message.
Quoted 6 lines · Serge E. Hallyn
Quoted 1 line · Subrata Modak
Stephen ??
Heh, this isn't an selinux issue, just trivially correct.
Acked-by Serge Hallyn <[email protected]>
Thanks.
Quoted 40 lines
-serge
Quoted 37 lines
-------- Forwarded Message --------
From: Jiri Palecek > <<[email protected]>
Cc: [email protected] <[email protected]>
Subject: [LTP] [PATCH] Fix an errorneous using of a different return value inselinux_entrypointtest
Date: Thu, 16 Apr 2009 17:59:00 +0200Hello,
I have been trying to run the selinux tests on Debian and discovered a small flaw. The test was using a return value variable which wasn't set by the test.
I've coma across another strange (at least to me) fact - when you execute a program without path, it is searched for in $PATH. However, if the program is in one directory if $PATH and selinux rejects to run the file, the following directories in $PATH are search, and the call can succeed. Is this behavior planned? I know it can't tamper the security of selinux, but it can lead to surprising results.
Also, I've found some uses of macros not present in Debian's refpolicy. Should I send a patch for them?
Regards
Jiri PalecekSigned-off-by Jiri Palecek <[email protected]>--- .../tests/entrypoint/selinux_entrypoint.sh | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)testcases/kernel/security/selinux-testsuite/tests/entrypoint/selinux_entrypoint.sh +1
-0@@ -52,6 +52,7 @@ test02() # Verify that test_entrypoint_t can be entered via this program. runcon -t test_entrypoint_t $SELINUXTMPDIR/true + RC=$? if [ $RC -ne 0 ] then echo "$TCID FAIL : entrypoint failed."
Quoted 10 lines
Quoted 10 lines
------------------------------------------------------------------------------
Stay on top of everything new and different, both inside and around Java (TM) technology - register by April 22, and save $200 on the JavaOne (SM) conference, June 2-5, 2009, San Francisco. 300 plus technical and hands-on sessions. Register today. Use priority code J9JMT32. http://p.sf.net/sfu/p
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list
--
This message was distributed to subscribers of the selinux mailing list. If you no longer wish to subscribe, send mail to [email protected] with the words "unsubscribe selinux" without quotes as the message.