Skip to contentSkip to conversation

powerpc: don't disable SATA interrupts on Freescale MPC8610 HPCD

PATCH Applied Timur Tabi 2 participants 2 messages Apr 20, 2009 – Apr 21, 2009 PowerPC

lore
Share & tools
lore

Timur Tabi

author
#0 lore raw

PATCH 1/1 powerpc: don't disable SATA interrupts on Freescale MPC8610 HPCD

The ULI 1575 PCI quirk function for the Freescale MPC8610 HPCD was disabling the SATA INTx interrupt, even when SATA support was enabled. This was safe, because the SATA driver re-enabled it. But with commit a5bfc471 ("ahci: drop intx manipulation on msi enable"), the driver no longer does this, and so SATA support on the 8610 HPCD is broken.

The original quirk function disabled INTx because it caused some other interrupt problem during early development on this board, but no one remembers any more what that problem was, and it doesn't seem to occur any more.

---
 arch/powerpc/platforms/fsl_uli1575.c |    5 -----
 1 files changed, 0 insertions(+), 5 deletions(-)
arch/powerpc/platforms/fsl_uli1575.c +0 -5
index 1db6b9e..65a35f3 100644
@@ -275,11 +275,6 @@ static void __devinit hpcd_quirk_uli5288(struct pci_dev *dev)
 	if (!machine_is(mpc86xx_hpcd))
 		return;
 
-	/* Interrupt Disable, Needed when SATA disabled */
-	pci_read_config_word(dev, PCI_COMMAND, &temp);
-	temp |= 1<<10;
-	pci_write_config_word(dev, PCI_COMMAND, temp);
-
 	pci_read_config_byte(dev, 0x83, &c);
 	c |= 0x80;
 	pci_write_config_byte(dev, 0x83, c);
Signature · 1 line
1.6.0.6
Applied
#1 lore raw
Quoted 6 lines · Timur Tabi

The ULI 1575 PCI quirk function for the Freescale MPC8610 HPCD was disabling the SATA INTx interrupt, even when SATA support was enabled. This was safe, because the SATA driver re-enabled it. But with commit a5bfc471 ("ahci: drop intx manipulation on msi enable"), the driver no longer does this, and so SATA support on the 8610 HPCD is broken.

Quoted 8 lines

The original quirk function disabled INTx because it caused some other interrupt problem during early development on this board, but no one remembers any more what that problem was, and it doesn't seem to occur any more.

---
arch/powerpc/platforms/fsl_uli1575.c | 5 -----

1 files changed, 0 insertions(+), 5 deletions(-)

applied to merge.

- k