ARM: OMAP: Fix tusb6010 init error and compilation warning
Subsystems (4)
PATCH 1/1 ARM: OMAP: Fix tusb6010 init error and compilation warning
Fix "tusb6010 init error 5, -19" and compilation warning from function tusb6010_platform_retime "warning: 'sysclk_ps' is used uninitialized in this function".
I suppose commit c094ba34b8f780885d029ce3c2715a194b780e5d was meant to test for zero fclk_ps instead of sysclk_ps.
--- arch/arm/mach-omap2/usb-tusb6010.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
arch/arm/mach-omap2/usb-tusb6010.c +1 -1
@@ -185,7 +185,7 @@ int tusb6010_platform_retime(unsigned is_refclk)unsigned sysclk_ps;int status; -if (!refclk_psec || sysclk_ps ==0 ) +if (!refclk_psec || fclk_ps ==0 )return -ENODEV ; sysclk_ps = is_refclk ? refclk_psec :TUSB6010_OSCCLK_60 ;
Signature · 1 line
1.6.2.1
Quoted 6 lines · Jarkko Nikula
Fix "tusb6010 init error 5, -19" and compilation warning from function
tusb6010_platform_retime"warning: 'sysclk_ps' is used uninitialized in this function".I suppose commit
c094ba34b8f780885d029ce3c2715a194b780e5dwas meant to test for zerofclk_psinstead ofsysclk_ps.
I was suffering exactly this problem and this patch fixed it. Now usb network works again, thanks a lot for fixing this!
Quoted 2 lines
Signed-off-by Jarkko Nikula <[email protected]>Cc Roel Kluin <[email protected]>
Signature · 1 line
Kalle Valo
Quoted 9 lines · On Thu, 23 Apr 2009 20:06:39 +0300 Kalle Valo <[email protected]> wrote:
Quoted 6 lines · Jarkko Nikula
Fix "tusb6010 init error 5, -19" and compilation warning from function
tusb6010_platform_retime"warning: 'sysclk_ps' is used uninitialized in this function".I suppose commit
c094ba34b8f780885d029ce3c2715a194b780e5dwas meant to test for zerofclk_psinstead ofsysclk_ps.
Quoted 8 lines
I was suffering exactly this problem and this patch fixed it. Now usb network works again, thanks a lot for fixing this!
Quoted 2 lines
Signed-off-by Jarkko Nikula <[email protected]>Cc Roel Kluin <[email protected]>Tested-by Kalle Valo <[email protected]>
Ping? This patch was a fix for 2.6.30-rcX.
Signature · 1 line
Jarkko
Tony Lindgren
maintainerQuoted 15 lines · Jarkko Nikula
Quoted 12 lines · On Thu, 23 Apr 2009 20:06:39 +0300 Kalle Valo <[email protected]> wrote:
Quoted 6 lines · Jarkko Nikula
Fix "tusb6010 init error 5, -19" and compilation warning from function
tusb6010_platform_retime"warning: 'sysclk_ps' is used uninitialized in this function".I suppose commit
c094ba34b8f780885d029ce3c2715a194b780e5dwas meant to test for zerofclk_psinstead ofsysclk_ps.I was suffering exactly this problem and this patch fixed it. Now usb network works again, thanks a lot for fixing this!
Quoted 6 lines
Quoted 5 lines
Quoted 2 lines
Signed-off-by Jarkko Nikula <[email protected]>Cc Roel Kluin <[email protected]>Tested-by Kalle Valo <[email protected]>Ping? This patch was a fix for 2.6.30-rcX.
Sorry for the delay. Pushed and added to omap-fixes, so we should still get this in.
Regards,
Tony
Tony Lindgren
maintainerPATCH 1/1 ARM: OMAP: Fix tusb6010 init error and compilation warning
In reply to Jarkko NikulaThis patch has been applied to the linux-omap
by youw fwiendly patch wobot.
Initial commit ID (Likely to change): 17178f265cbe2220fc437e93128fb0feea54c3fc
PatchWorks
http://patchwork.kernel.org/patch/19477/
Git (Likely to change, and takes a while to get mirrored)
http://git.kernel.org/?p=linux/kernel/git/tmlind/linux-omap-2.6.git;a=commit;h=17178f265cbe2220fc437e93128fb0feea54c3fc