mips/vcth: Use generic 16550 uart driver
PATCH 1/1 mips/vcth: Use generic 16550 uart driver
As the common code also handles baudrate switching, which the board specific vct.c driver did not support, this is one of the rare occassions where deleting code actually adds a feature :)
--- drivers/serial/Makefile | 3 +- drivers/serial/vct.c | 125 ----------------------------------------------- include/configs/vct.h | 13 +++++- 3 files changed, 13 insertions(+), 128 deletions(-) delete mode 100755 drivers/serial/vct.c
drivers/serial/Makefile +1 -2
@@ -1,5 +1,5 @@ # -# (C) Copyright 2006 +# (C) Copyright 2006-2009 # Wolfgang Denk, DENX Software Engineering, wd at denx.de. # # See file CREDITS for list of people who contributed to this
@@ -50,7 +50,6 @@ COBJS-$(CONFIG_S3C44B0_SERIAL) += serial_s3c44b0.o COBJS-$(CONFIG_XILINX_UARTLITE) += serial_xuartlite.o COBJS-$(CONFIG_SCIF_CONSOLE) += serial_sh.o COBJS-$(CONFIG_USB_TTY) += usbtty.o -COBJS-$(CONFIG_VCT_SERIAL) += vct.o COBJS := $(sort $(COBJS-y)) SRCS := $(COBJS:.o=.c)
drivers/serial/vct.c deleted +0 -125
125 lines not on this page · raw message
include/configs/vct.h +12 -1
@@ -61,7 +61,18 @@/* * UART */ -#define CONFIG_VCT_SERIAL +#ifdef CONFIG_VCT_PLATINUMAVC +#define UART_1_BASE 0xBDC30000 +#else +#define UART_1_BASE 0xBF89C000 +#endif + +#define CONFIG_SYS_NS16550_SERIAL +#define CONFIG_SYS_NS16550 +#define CONFIG_SYS_NS16550_REG_SIZE -4 +#define CONFIG_SYS_NS16550_COM1 UART_1_BASE +#define CONFIG_CONS_INDEX 1 +#define CONFIG_SYS_NS16550_CLK 921600#define CONFIG_BAUDRATE 115200#define CONFIG_SYS_BAUDRATE_TABLE { 9600, 19200, 38400, 57600, 115200 }
Signature · 1 line
1.6.0.6
PATCH 1/1 mips/vcth: Use generic 16550 uart driver
Wolfgang,
Quoted 4 lines · Detlev Zundel
As the common code also handles baudrate switching, which the board specific
vct.cdriver did not support, this is one of the rare occassions where deleting code actually adds a feature :)
Quoted 8 lines
Signed-off-by Detlev Zundel <[email protected]>Acked-by Stefan Roese <[email protected]>--- drivers/serial/Makefile | 3 +- drivers/serial/vct.c | 125 ----------------------------------------------- include/configs/vct.h | 13 +++++- 3 files changed, 13 insertions(+), 128 deletions(-) delete mode 100755 drivers/serial/vct.c
Please pick up directly, I'll not take care of this :-)
Signature · 2 lines
Shinya Kuribayashi NEC Electronics
Wolfgang Denk
AppliedPATCH 1/1 mips/vcth: Use generic 16550 uart driver
In reply to Detlev ZundelDear Detlev Zundel,
Quoted 4 lines · In message <[email protected]> you wrote:
As the common code also handles baudrate switching, which the board specific
vct.cdriver did not support, this is one of the rare occassions where deleting code actually adds a feature :)
Quoted 8 lines
Signed-off-by Detlev Zundel <[email protected]>Acked-by Stefan Roese <[email protected]>--- drivers/serial/Makefile | 3 +- drivers/serial/vct.c | 125 ----------------------------------------------- include/configs/vct.h | 13 +++++- 3 files changed, 13 insertions(+), 128 deletions(-) delete mode 100755 drivers/serial/vct.c
Applied, thanks.
Best regards,
Wolfgang Denk
Signature · 5 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de Der Irrtum wiederholt sich immerfort in der Tat. Deshalb mu? man das Wahre unerm?dlich in Worten wiederholen. - Goethe