Skip to contentSkip to conversation

driver core:firmware_class:replace kfree(dev) with put_device(dev)

PATCH New [email protected] 1 participant 1 message Apr 23, 2009 Driver core

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 driver core:firmware_class:replace kfree(dev) with put_device(dev)

From: Ming Lei <[email protected]>

against v2.6.30-rc3-next tree.

---
 drivers/base/firmware_class.c |    8 +++++---
 1 files changed, 5 insertions(+), 3 deletions(-)
drivers/base/firmware_class.c +5 -3
index f19afa8..d186149 100644
@@ -356,7 +356,7 @@ static void fw_dev_release(struct device *dev)
 		__free_page(fw_priv->pages[i]);
 	kfree(fw_priv->pages);
 	kfree(fw_priv);
-	kfree(dev);
+	put_device(dev);
 
 	module_put(THIS_MODULE);
 }
@@ -400,14 +400,16 @@ static int fw_register_device(struct device **dev_p, const char *fw_name,
 	retval = device_register(f_dev);
 	if (retval) {
 		dev_err(device, "%s: device_register failed\n", __func__);
-		goto error_kfree;
+		put_device(f_dev);
+		goto error_kfree1;
 	}
 	*dev_p = f_dev;
 	return 0;
 
 error_kfree:
-	kfree(fw_priv);
 	kfree(f_dev);
+error_kfree1:
+	kfree(fw_priv);
 	return retval;
 }
 
Signature · 1 line
1.6.0.GIT