Skip to contentSkip to conversation

driver/base: add BUS_NOTIFY_UNBOUND_DRIVER event

PATCH In review Joerg Roedel 3 participants 4 messages Apr 24, 2009 Driver core

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 driver/base: add BUS_NOTIFY_UNBOUND_DRIVER event

This patch adds a new bus notifier event which is emitted _after_ a device is removed from its driver. This event will be used by the dma-api debug code to check if a driver has released all dma allocations for that device.

---
 drivers/base/dd.c      |    4 ++++
 include/linux/device.h |    2 ++
 2 files changed, 6 insertions(+), 0 deletions(-)
drivers/base/dd.c +4 -0
index 742cbe6..efd00de 100644
@@ -320,6 +320,10 @@ static void __device_release_driver(struct device *dev)
 		devres_release_all(dev);
 		dev->driver = NULL;
 		klist_remove(&dev->p->knode_driver);
+		if (dev->bus)
+			blocking_notifier_call_chain(&dev->bus->p->bus_notifier,
+						     BUS_NOTIFY_UNBOUND_DRIVER,
+						     dev);
 	}
 }
 
include/linux/device.h +2 -0
index 6a69caa..ac69c22 100644
@@ -116,6 +116,8 @@ extern int bus_unregister_notifier(struct bus_type *bus,
 #define BUS_NOTIFY_BOUND_DRIVER		0x00000003 /* driver bound to device */
 #define BUS_NOTIFY_UNBIND_DRIVER	0x00000004 /* driver about to be
 						      unbound */
+#define BUS_NOTIFY_UNBOUND_DRIVER	0x00000005 /* driver is unbound
+						      from the device */
 
 extern struct kset *bus_get_kset(struct bus_type *bus);
 extern struct klist *bus_get_device_klist(struct bus_type *bus);
Signature · 1 line
1.6.2.3
#1 lore raw
Quoted 4 lines · Joerg Roedel

This patch adds a new bus notifier event which is emitted _after_ a device is removed from its driver. This event will be used by the dma-api debug code to check if a driver has released all dma allocations for that device.

Heh, I was wondering if people were going to need that. I'll queue it up for 2.6.31, is that ok with you? Do you have patches that depend on it?

thanks,

greg k-h

#2 lore raw
Quoted 9 lines · Greg KH
Quoted 4 lines · Joerg Roedel

This patch adds a new bus notifier event which is emitted _after_ a device is removed from its driver. This event will be used by the dma-api debug code to check if a driver has released all dma allocations for that device.

Heh, I was wondering if people were going to need that. I'll queue it up for 2.6.31, is that ok with you? Do you have patches that depend on it?

2.6.31 is ok for me. I sent Ingo a patch to remove the broken feature which uses the wrong event for 2.6.30. I can reintroduce the fixed version for 2.6.31 too.
Other way may be to send this patch to 2.6.30 which makes a smaller fix possible for dma-api debugging. But I am not sure if this new event could go in after the merge window. So I choosed this way :) For me, 2.6.31 for this patch is fine.

Thanks,

Joerg

#3 lore raw
Quoted 11 lines · Joerg Roedel
Quoted 9 lines · Greg KH
Quoted 4 lines · Joerg Roedel

This patch adds a new bus notifier event which is emitted _after_ a device is removed from its driver. This event will be used by the dma-api debug code to check if a driver has released all dma allocations for that device.

Heh, I was wondering if people were going to need that. I'll queue it up for 2.6.31, is that ok with you? Do you have patches that depend on it?

Quoted 7 lines

2.6.31 is ok for me. I sent Ingo a patch to remove the broken feature which uses the wrong event for 2.6.30. I can reintroduce the fixed version for 2.6.31 too.
Other way may be to send this patch to 2.6.30 which makes a smaller fix possible for dma-api debugging. But I am not sure if this new event could go in after the merge window. So I choosed this way :) For me, 2.6.31 for this patch is fine.

Great, it will go in for 2.6.31 then.

thanks,

greg k-h