Skip to contentSkip to conversation

ath5k: 5211, don't crypt every protected frame

PATCH In review Jiri Slaby 3 participants 4 messages Apr 25, 2009 – Apr 26, 2009 Atheros ATH5K wireless driver

lore
Share & tools
lore

Jiri Slaby

author
#0 lore raw

PATCH 1/1 ath5k: 5211, don't crypt every protected frame

Hi guys,
do you remember some 5211 HW which didn't work with this? --

Set null key type even on ar5211, otherwise it en/decrypts every frame with protected bit set which renders the card unusable on encrypted networks.

Cc Nick Kossifidis <[email protected]>
Cc Luis R. Rodriguez <[email protected]>
Cc Bob Copeland <[email protected]>
---
 drivers/net/wireless/ath/ath5k/pcu.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/net/wireless/ath/ath5k/pcu.c +1 -1
index 55122f1..5f07e87 100644
@@ -1003,7 +1003,7 @@ int ath5k_hw_reset_key(struct ath5k_hw *ah, u16 entry)
 	 * Note2: Windows driver (ndiswrapper) sets this to
 	 *        0x00000714 instead of 0x00000007
 	 */
-	if (ah->ah_version > AR5K_AR5211) {
+	if (ah->ah_version >= AR5K_AR5211) {
 		ath5k_hw_reg_write(ah, AR5K_KEYTABLE_TYPE_NULL,
 				AR5K_KEYTABLE_TYPE(entry));
 
Signature · 1 line
1.6.2.4
#1 lore raw
Quoted 6 lines · Jiri Slaby

Hi guys,
do you remember some 5211 HW which didn't work with this? --

Set null key type even on ar5211, otherwise it en/decrypts every frame with protected bit set which renders the card unusable on encrypted networks.

Not me. I don't have the hardware, so I would say if your patch is known to work on a 5211 then we go with it.

Signature · 1 line
Bob Copeland %% www.bobcopeland.com
author
#2 lore raw
Quoted 10 lines · Bob Copeland
Quoted 6 lines · Jiri Slaby

Hi guys,
do you remember some 5211 HW which didn't work with this? --

Set null key type even on ar5211, otherwise it en/decrypts every frame with protected bit set which renders the card unusable on encrypted networks.

Not me. I don't have the hardware, so I would say if your patch is known to work on a 5211 then we go with it.

Ok, thanks. Of course the HW I used (IBM T40 Thinkpad) needs the patch ;).

maintainer Acked-by
#3 lore raw

2009/4/26 Jiri Slaby <[email protected]>:

Quoted 7 lines · Bob Copeland
Quoted 6 lines · Jiri Slaby
Quoted 5 lines

Hi guys,
do you remember some 5211 HW which didn't work with this? --

Set null key type even on ar5211, otherwise it en/decrypts every fr=

ame with

Quoted 1 line
Quoted 1 line
Quoted 1 line

protected bit set which renders the card unusable on encrypted netw=

orks.

Quoted 2 lines
Quoted 2 lines

Not me. =C2=A0I don't have the hardware, so I would say if your patc=

h is known

Quoted 3 lines
Quoted 1 line

to work on a 5211 then we go with it.

Ok, thanks. Of course the HW I used (IBM T40 Thinkpad) needs the patc=

h ;).

Quoted 1 line

--=20
GPG ID: 0xD21DB2DB
As you read this post global entropy rises. Have Fun ;-) Nick
--
To unsubscribe from this list: send the line "unsubscribe linux-wireles= s" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html