cfg80211: Remove unnecessary ksize() call
PATCH 1/1 cfg80211: Remove unnecessary ksize() call
This removes an unnecessary ksize() call. krealloc() will do this test internally and won't perform any allocation if the space is already sufficient to hold the data.
So remove the redundant check.
Signed-off-by Michael Buesch <[email protected]>
--- net/wireless/scan.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-)
net/wireless/scan.c +3 -5
@@ -384,11 +384,9 @@ cfg80211_bss_update(struct cfg80211_regi }else {u8 *ies = found->pub.information_elements; -if (found->ies_allocated) { -if (ksize (ies) < ielen) - ies =krealloc (ies, ielen, -GFP_ATOMIC ); - }else +if (found->ies_allocated) + ies =krealloc (ies, ielen,GFP_ATOMIC ); +else ies =kmalloc (ielen,GFP_ATOMIC );if (ies) {
Signature · 1 line
Greetings, Michael.
Quoted 6 lines · Michael Buesch
This removes an unnecessary
ksize()call.krealloc()will do this test internally and won't perform any allocation if the space is already sufficient to hold the data.
So remove the redundant check.Signed-off-by Michael Buesch <[email protected]>
Good catch, thanks.
Reviewed-by Johannes Berg <[email protected]>
johannes
Quoted 22 lines
--- net/wireless/scan.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-)net/wireless/scan.c +3
-5@@ -384,11 +384,9 @@ cfg80211_bss_update(struct cfg80211_regi }else {u8 *ies = found->pub.information_elements; -if (found->ies_allocated) { -if (ksize (ies) < ielen) - ies =krealloc (ies, ielen, -GFP_ATOMIC ); - }else +if (found->ies_allocated) + ies =krealloc (ies, ielen,GFP_ATOMIC ); +else ies =kmalloc (ielen,GFP_ATOMIC );if (ies) {