Skip to contentSkip to conversation

Fix sub-block zeroing for buffered writes into unwritten extents.

PATCH New Aneesh Kumar K.V 1 participant 1 message Apr 28, 2009 ext4 file system

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Fix sub-block zeroing for buffered writes into unwritten extents.

We need to mark the buffer_head mapping prealloc space as new during write_begin. Otherwise we don't zero out the page cache content properly for a partial write. This will cause file corruption with preallocation.

---
 fs/ext4/inode.c |    8 ++++++++
 1 files changed, 8 insertions(+), 0 deletions(-)
fs/ext4/inode.c +8 -0
index c6bd6ce..8dfa97a 100644
@@ -2323,6 +2323,14 @@ static int ext4_da_get_block_prep(struct inode *inode, sector_t iblock,
 		set_buffer_delay(bh_result);
 	} else if (ret > 0) {
 		bh_result->b_size = (ret << inode->i_blkbits);
+		bh_result->b_bdev = inode->i_sb->s_bdev;
+		/*
+		 * With sub-block writes into unwritten extents
+		 * we also need to mark the buffer as new so that
+		 * the unwritten parts of the buffer gets correctly zeroed.
+		 */
+		if (buffer_unwritten(bh_result))
+			set_buffer_new(bh_result);
 		ret = 0;
 	}
 
Signature · 1 line
tg: (51bec03..) preallocate_corruption (depends on: ext4_lock_group_conversion)