gianfar: Use memset instead of cacheable_memzero
Subsystems (2)
PATCH 1/1 gianfar: Use memset instead of cacheable_memzero
cacheable_memzero() is completely overkill for the clearing out the FCB block which is only 8-bytes. The compiler should easily optimize this with memset. Additionally, cacheable_memzero() only exists on ppc32 and thus breaks builds of gianfar on ppc64.
Signed-off-by Kumar Gala <[email protected]>
--- drivers/net/gianfar.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-)
drivers/net/gianfar.c +2 -1
@@ -1207,7 +1207,8 @@ static int gfar_enet_open(struct net_device *dev)static inline struct txfcb *gfar_add_fcb (struct sk_buff *skb) {struct txfcb *fcb = (struct txfcb *)skb_push (skb,GMAC_FCB_LEN ); -cacheable_memzero (fcb,GMAC_FCB_LEN ); + +memset (fcb,0 ,GMAC_FCB_LEN );return fcb; }
Signature · 1 line
1.6.0.6
From: Kumar Gala <[email protected]>
Date: Tue, 28 Apr 2009 09:14:01 -0500
Quoted 6 lines
cacheable_memzero()is completely overkill for the clearing out the FCB block which is only 8-bytes. The compiler should easily optimize this with memset. Additionally,cacheable_memzero()only exists on ppc32 and thus breaks builds of gianfar on ppc64.Signed-off-by Kumar Gala <[email protected]>
Applied to net-next-2.6, thanks!