Skip to contentSkip to conversation

kvm: discard masking checking when initial MSI-X entries

PATCH Applied Sheng Yang 2 participants 3 messages May 5, 2009 – May 18, 2009 KVM

lore
Share & tools
lore

Sheng Yang

author
#0 lore raw

PATCH 1/1 kvm: discard masking checking when initial MSI-X entries

This meant to be with commit: adcf3594f9580bdf9b5e71f271b6088b185e017e, otherwise QEmu only counts the MSI-X entries, but won't fill it...

Signed-off-by Sheng Yang <[email protected]>
---
 hw/device-assignment.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)
hw/device-assignment.c +0 -2
index 0a5f850..bee0bd8 100644
@@ -858,8 +858,6 @@ static int assigned_dev_update_msix_mmio(PCIDevice *pci_dev)
         if (entries_nr >= msix_nr.entry_nr)
             break;
         memcpy(&msg_ctrl, va + i * 16 + 12, 4);
-        if (msg_ctrl & 0x1)
-            continue;
         memcpy(&msg_data, va + i * 16 + 8, 4);
         if (msg_data == 0)
             continue;
Signature · 1 line
1.5.4.5
author
#1 lore raw
Quoted 13 lines · On Tuesday 05 May 2009 11:41:55 Sheng Yang wrote:

This meant to be with commit: adcf3594f9580bdf9b5e71f271b6088b185e017e, otherwise QEmu only counts the MSI-X entries, but won't fill it...

Signed-off-by Sheng Yang <[email protected]>
---
 hw/device-assignment.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)
hw/device-assignment.c +0 -0
index 0a5f850..bee0bd8 100644

hw/device-assignment.c static int assigned_dev_update_msix_mmio(PCIDevice · line 863

Quoted 8 lines
hw/device-assignment.c +0 -2
@@ -858,8 +858,6 @@ static int assigned_dev_update_msix_mmio(PCIDevice
 *pci_dev) if (entries_nr >= msix_nr.entry_nr)
             break;
         memcpy(&msg_ctrl, va + i * 16 + 12, 4);
-        if (msg_ctrl & 0x1)
-            continue;
         memcpy(&msg_data, va + i * 16 + 8, 4);
         if (msg_data == 0)
             continue;

Avi?

Signature · 2 lines
regards
Yang, Sheng
Applied
#2 lore raw
In reply to Sheng Yang
Quoted 3 lines · Sheng Yang

This meant to be with commit: adcf3594f9580bdf9b5e71f271b6088b185e017e, otherwise QEmu only counts the MSI-X entries, but won't fill it...

Applied, thanks.

Signature · 1 line
error compiling committee.c: too many arguments to function