oprofile: fix cpu buffer size
PATCH 1/1 oprofile: fix cpu buffer size
The unit of oprofile_cpu_buffer_size is in samples, but was allocated in bytes. This led to the allocation of too small cpu buffers. This patch recalculates the buffer size in bytes taking also the ring_buffer_event header size into account.
Reported-by Suravee Suthikulpanit <[email protected]>
Signed-off-by Robert Richter <[email protected]>
--- drivers/oprofile/cpu_buffer.c | 8 ++++++-- 1 files changed, 6 insertions(+), 2 deletions(-)
drivers/oprofile/cpu_buffer.c +6 -2
@@ -78,16 +78,20 @@ void free_cpu_buffers(void) op_ring_buffer_write =NULL ; } +#define RB_EVENT_HDR_SIZE 4 +int alloc_cpu_buffers (void ) {int i;unsigned long buffer_size = oprofile_cpu_buffer_size; +unsigned long byte_size = buffer_size * (sizeof (struct op_sample ) + +RB_EVENT_HDR_SIZE ); - op_ring_buffer_read =ring_buffer_alloc (buffer_size,OP_BUFFER_FLAGS ); + op_ring_buffer_read =ring_buffer_alloc (byte_size,OP_BUFFER_FLAGS );if (!op_ring_buffer_read) goto fail; - op_ring_buffer_write =ring_buffer_alloc (buffer_size,OP_BUFFER_FLAGS ); + op_ring_buffer_write =ring_buffer_alloc (byte_size,OP_BUFFER_FLAGS );if (!op_ring_buffer_write) goto fail;
Signature · 1 line
1.6.1.3