rocket tty BUG in 2.6.29 (regression)
Hi,
2.6.26 works fine in our terminal server machine, but after rebooting it into 2.6.29 I got the following Oops when starting screen for a ttyR serial device (after unloading and reloading the rocket module while trying to get some udev rename rules right):
May 8 01:56:09 noc2b kernel: [ 505.450289] RocketPort device driver module, version 2.09, 12-June-2003 May 8 01:56:09 noc2b kernel: [ 505.463680] pci 0000:02:06.0: comtrol PCI controller #0 found at address c800, 1 AIOP(s) (RocketPort UPCI 8 port w/external I/F), creating ttyR0 - 7 May 8 01:56:09 noc2b kernel: [ 505.491741] pci 0000:01:08.0: comtrol PCI controller #1 found at address d800, 1 AIOP(s) (RocketPort UPCI 8 port w/external I/F), creating ttyR8 - 15 May 8 01:56:32 noc2b kernel: [ 528.486680] BUG: unable to handle kernel paging request at 06bd0c30 May 8 01:56:32 noc2b kernel: [ 528.499538] IP: [<fbdf4f6a>] rp_open+0xc1/0x349 [rocket] May 8 01:56:32 noc2b kernel: [ 528.510352] *pde = 00000000 May 8 01:56:33 noc2b kernel: [ 528.516286] Oops: 0000 [#1] SMP May 8 01:56:33 noc2b kernel: [ 528.521023] last sysfs file: /sys/devices/virtual/block/md1/md/dev-sdb2/state May 8 01:56:33 noc2b kernel: [ 528.537022] Modules linked in: rocket 8021q garp stp bonding nf_conntrack_tftp xt_recent xt_multiport ip6t_REJECT ipt_REJECT nf_conntrack_ipv6 nf_conntrack_ipv4 nf_defrag_ipv4 xt_state nf_conntrack xt_tcpudp xt_comment ip6t_LOG ipt_LOG xt_limit ip6table_filter iptable_filter ip6table_raw ip6_tables iptable_raw ip_tables x_tables ext3 jbd mbcache ipmi_devintf ipmi_si ipmi_msghandler ipv6 evdev snd_pcm snd_timer snd soundcore snd_page_alloc psmouse serio_raw dcdbas button pcspkr shpchp pci_hotplug i2c_piix4 i2c_core sworks_agp agpgart xfs exportfs dm_mirror dm_region_hash dm_log dm_snapshot dm_mod raid1 md_mod sg sd_mod crc_t10dif ide_cd_mod cdrom ata_generic libata aic7xxx scsi_transport_spi ohci_hcd tg3 scsi_mod floppy libphy usbcore serverworks ide_pci_generic ide_core thermal processor fan thermal_sys [last unloaded: rocket] May 8 01:56:33 noc2b kernel: [ 528.689023] May 8 01:56:33 noc2b kernel: [ 528.693024] Pid: 6174, comm: stty Not tainted (2.6.29-2-686 #1) PowerEdge 2650 May 8 01:56:33 noc2b kernel: [ 528.709022] EIP: 0060:[<fbdf4f6a>] EFLAGS: 00010202 CPU: 0 May 8 01:56:33 noc2b kernel: [ 528.721022] EIP is at rp_open+0xc1/0x349 [rocket] May 8 01:56:33 noc2b kernel: [ 528.732509] EAX: 00000001 EBX: fffffff4 ECX: f5a1fc00 EDX: 00000000 May 8 01:56:33 noc2b kernel: [ 528.745026] ESI: f55d6000 EDI: f5a1fc00 EBP: f6bd0c00 ESP: f57ede54 May 8 01:56:33 noc2b kernel: [ 528.757023] DS: 007b ES: 007b FS: 00d8 GS: 0033 SS: 0068 May 8 01:56:33 noc2b kernel: [ 528.768508] Process stty (pid: 6174, ti=f57ec000 task=f671f7f0 task.ti=f57ec000) May 8 01:56:33 noc2b kernel: [ 528.781022] Stack: May 8 01:56:33 noc2b kernel: [ 528.785022] f6b3d880 f6bd0c04 f6ac1380 f5a1fc00 ffffffed f6b3d880 c0245690 00008800 May 8 01:56:33 noc2b kernel: [ 528.801022] f6346cc4 02e00004 00000000 00000004 00000000 f6ac1388 f6ac1388 00000000 May 8 01:56:33 noc2b kernel: [ 528.817022] c0189958 f6b3d880 f6346cc4 00000004 f6b3d880 00000000 f6346cc4 c0189827 May 8 01:56:33 noc2b kernel: [ 528.833022] Call Trace: May 8 01:56:33 noc2b kernel: [ 528.841022] [<c0245690>] tty_open+0x287/0x393 May 8 01:56:33 noc2b kernel: [ 528.849021] [<c0189958>] chrdev_open+0x131/0x148 May 8 01:56:33 noc2b kernel: [ 528.857023] [<c0189827>] chrdev_open+0x0/0x148 May 8 01:56:33 noc2b kernel: [ 528.869043] [<c0185f40>] __dentry_open+0x119/0x208 May 8 01:56:33 noc2b kernel: [ 528.877022] [<c01860c0>] nameidata_to_filp+0x29/0x3c May 8 01:56:33 noc2b kernel: [ 528.889022] [<c018fa92>] do_filp_open+0x385/0x6f7 May 8 01:56:33 noc2b kernel: [ 528.897023] [<c0172296>] vma_prio_tree_insert+0x17/0x7f May 8 01:56:33 noc2b kernel: [ 528.909022] [<c01792e8>] vma_link+0x69/0x72 May 8 01:56:33 noc2b kernel: [ 528.917022] [<c017a584>] mmap_region+0x318/0x41c May 8 01:56:33 noc2b kernel: [ 528.925022] [<c01973d7>] alloc_fd+0xb9/0xc5 May 8 01:56:33 noc2b kernel: [ 528.936509] [<c0185d55>] do_sys_open+0x3f/0xb2 May 8 01:56:33 noc2b kernel: [ 528.945021] [<c0185e0c>] sys_open+0x1e/0x23 May 8 01:56:33 noc2b kernel: [ 528.953022] [<c010341b>] sysenter_do_call+0x12/0x2f May 8 01:56:33 noc2b kernel: [ 528.964509] [<c02e0000>] cpuid4_cache_lookup+0x2d4/0x2e2 May 8 01:56:33 noc2b kernel: [ 528.973022] Code: 01 00 00 8d 45 04 89 fa 89 44 24 04 89 af 28 01 00 00 e8 92 4c 45 c4 8b 55 14 8d 42 01 85 d2 89 45 14 75 07 f0 ff 05 68 89 df fb <f6> 85 30 00 00 10 01 0f 85 46 02 00 00 8a 85 f2 00 00 00 8d 75 May 8 01:56:33 noc2b kernel: [ 529.017023] EIP: [<fbdf4f6a>] rp_open+0xc1/0x349 [rocket] SS:ESP 0068:f57ede54 May 8 01:56:33 noc2b kernel: [ 529.033342] ---[ end trace 206e0bf40f2c2211 ]---
This is a stock Debian unstable kernel, I can provide its config if needed. Please ask if any other information is missing.
Please Cc me, I'm not subscribed.
Signature · 2 lines
Thanks, Feri.
PATCH 1/2 Char: rocket, fix ASYNC flags
ASYNC_* flags are not bits, but rather constants, use ilog2 to obtain bit positions and stay atomic.
--- drivers/char/rocket.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-)
drivers/char/rocket.c +3 -3
@@ -939,7 +939,7 @@ static int rp_open(struct tty_struct *tty, struct file *filp)/* * Info->count is now 1; so it's safe to sleep now. */ -if (!test_bit (ASYNC_INITIALIZED , &port->flags)) { +if (!test_bit (ilog2 (ASYNC_INITIALIZED ), &port->flags)) { cp = &info->channel;sSetRxTrigger (cp,TRIG_1 );if (sGetChanStatus (cp) &CD_ACT )
@@ -963,7 +963,7 @@ static int rp_open(struct tty_struct *tty, struct file *filp)sEnRxFIFO (cp);sEnTransmit (cp); -set_bit (ASYNC_INITIALIZED , &info->port.flags); +set_bit (ilog2 (ASYNC_INITIALIZED ), &info->port.flags);/* * Set up the tty->alt_speed kludge
@@ -1646,7 +1646,7 @@ static int rp_write(struct tty_struct *tty,/* Write remaining data into the port's xmit_buf */ while (1 ) {/* Hung up ? */ -if (!test_bit (ASYNC_NORMAL_ACTIVE , &info->port.flags)) +if (!test_bit (ilog2 (ASYNC_NORMAL_ACTIVE ), &info->port.flags)) goto end; c =min (count,XMIT_BUF_SIZE - info->xmit_cnt -1 ); c =min (c,XMIT_BUF_SIZE - info->xmit_head);
Signature · 1 line
1.6.2.4
Re: [PATCH 1/2] Char: rocket, fix ASYNC flags
Quoted 2 lines · On Fri, 8 May 2009 10:32:43 +0200 Jiri Slaby <[email protected]> wrote:
ASYNC_* flags are not bits, but rather constants, use ilog2 to obtain bit positions and stay atomic.
Definitely agree with the bug but it would I think be cleaner to add ASYNCF_.. (or ASYNCB_.. or similar) that is the bit numbers rather than use ilog2. That also means we can later delete ASYNC_xxx from the kernel side to stop people using them unsafely in drivers
Re: [PATCH 1/2] Char: rocket, fix ASYNC flags
Quoted 1 line · Alan Cox
cleaner to add
ASYNCF_..
Heh, I have been thinking about that too, I'll post updated patches later. Thanks.
PATCH 2/2 Char: epca, fix ASYNC flags
In reply to Ferenc WagnerASYNC_* flags are not bits, but rather constants, use ilog2 to obtain bit positions and stay atomic.
--- drivers/char/epca.c | 9 +++++---- 1 files changed, 5 insertions(+), 4 deletions(-)
drivers/char/epca.c +5 -4
@@ -1518,7 +1518,7 @@ static void doevent(int crd)if (event &MODEMCHG_IND ) {/* A modem signal change has been indicated */ ch->imodem = mstat; -if (test_bit (ASYNC_CHECK_CD , &ch->port.flags)) { +if (test_bit (ilog2 (ASYNC_CHECK_CD ), &ch->port.flags)) {/* We are now receiving dcd */ if (mstat & ch->dcd)wake_up_interruptible (&ch->port.open_wait);
@@ -1765,9 +1765,9 @@ static void epcaparam(struct tty_struct *tty, struct channel *ch)* that the driver will wait on carrier detect. */ if (ts->c_cflag &CLOCAL ) -clear_bit (ASYNC_CHECK_CD , &ch->port.flags); +clear_bit (ilog2 (ASYNC_CHECK_CD ), &ch->port.flags);else -set_bit (ASYNC_CHECK_CD , &ch->port.flags); +set_bit (ilog2 (ASYNC_CHECK_CD ), &ch->port.flags); mval = ch->m_dtr | ch->m_rts; }/* End CBAUD not detected */ iflag =termios2digi_i (ch, ts->c_iflag);
@@ -2244,7 +2244,8 @@ static void do_softint(struct work_struct *work)if (test_and_clear_bit (EPCA_EVENT_HANGUP , &ch->event)) {tty_hangup (tty);wake_up_interruptible (&ch->port.open_wait); -clear_bit (ASYNC_NORMAL_ACTIVE , &ch->port.flags); +clear_bit (ilog2 (ASYNC_NORMAL_ACTIVE ), + &ch->port.flags); } }tty_kref_put (tty);
Signature · 1 line
1.6.2.4
Quoted 6 lines · On Fri, 08 May 2009 02:36:45 +0200 Ferenc Wagner <[email protected]> wrote:
Hi,
2.6.26 works fine in our terminal server machine, but after rebooting it into 2.6.29 I got the following Oops when starting screen for a ttyR serial device (after unloading and reloading the rocket module while trying to get some udev rename rules right):
So it works the first time around, then blos up the second ? Is this repeatable ?
In theory Ted is the maintainer for rocket but as I'm the one who last did any surgery on it this one may well be my bug.
Alan
Quoted 10 lines · Alan Cox
Quoted 4 lines · On Fri, 08 May 2009 02:36:45 +0200 Ferenc Wagner <[email protected]> wrote:
2.6.26 works fine in our terminal server machine, but after rebooting it into 2.6.29 I got the following Oops when starting screen for a ttyR serial device (after unloading and reloading the rocket module while trying to get some udev rename rules right):
So it works the first time around, then blos up the second ? Is this repeatable ?
No, I didn't say this. The first time I didn't even try, because our software uses the persistent names, not /dev/ttyR*, but the udev rename rules didn't fire. So I fixed the rules, removed and reinserted the module, then started the console multiplexer, which provoked the bugs (all 16). I don't think it has anything to do with the issue, but wanted to explain the "last removed: rocket" part of the log.
Quoted 2 lines
In theory Ted is the maintainer for rocket but as I'm the one who last did any surgery on it this one may well be my bug.
Looks like Jiri has a handle on the problem, though. Once you converge on a patch and need testing, tell me. I'm not in a hurry, the current Debian stable kernel works OK, I tested 2.6.29 while investigating an unrelated networking issue.
Signature · 2 lines
Thanks for the great support again, Feri.