Skip to contentSkip to conversation

ARM: DaVinci: DM646x Video: DM646x display driver

PATCH In review Chaithrika U S 2 participants 4 messages May 8, 2009 – May 22, 2009 Media (V4L/DVB)

lore
Share & tools
lore
#0 lore raw

v3 cover ARM: DaVinci: DM646x Video: DM646x display driver

Display driver for TI DM646x EVM

These patches add the display driver support for TI DM646x EVM. This patch set has been tested for basic display functionality for Composite and Component outputs.

This patch set consists of the updates based on the review comments by Hans Verkuil.

Patch 1: Display device platform and board setup Patch 2: VPIF driver
Patch 3: DM646x display driver
Patch 4: Makefile and config files modifications for Display

Some of the features like the HBI/VBI support are not yet implemented. Also there are some known issues in the code implementation like fine tuning to be done to TRY_FMT ioctl.The USERPTR usage has not been tested extensively.

-Chaithrika

author
#1 lore raw

Hi All,

Do you have any review comments on this patch set?

Regards,
Chaithrika

Quoted 33 lines

-----Original Message-----
From: Chaithrika U S [mailto:[email protected]]
Sent: Friday, May 08, 2009 6:55 PM
To: [email protected]
Cc: [email protected]; Manjunath Hadli; Brijesh Jadav; Chaithrika U S
Subject: [PATCH v3 0/4] ARM: DaVinci: DM646x Video: DM646x display driver

Display driver for TI DM646x EVM

These patches add the display driver support for TI DM646x EVM. This patch set has been tested for basic display functionality for Composite and Component outputs.

This patch set consists of the updates based on the review comments by Hans Verkuil.

Patch 1: Display device platform and board setup Patch 2: VPIF driver
Patch 3: DM646x display driver
Patch 4: Makefile and config files modifications for Display

Some of the features like the HBI/VBI support are not yet implemented. Also there are some known issues in the code implementation like fine tuning to be done to TRY_FMT ioctl.The USERPTR usage has not been tested extensively.

-Chaithrika

Reviewed-by
#2 lore raw
Quoted 3 lines · On Thursday 21 May 2009 08:12:57 chaithrika wrote:

Hi All,

Do you have any review comments on this patch set?

I'm happy with these patches!

There is one thing that can be improved, though. It is really an enhancement and does not prevent this from being merged.

Currently the isr routine refuses to switch to the next frame if the dma queue is empty. However, I see no reason for this: it should always go to that frame regardless and keep that until new frames are queued. I've made this change in the (very old) driver I use at work, but this should become standard behavior.

Regards,

Hans

Quoted 42 lines

Regards,
Chaithrika

Quoted 27 lines

-----Original Message-----
From: Chaithrika U S [mailto:[email protected]]
Sent: Friday, May 08, 2009 6:55 PM
To: [email protected]
Cc: [email protected]; Manjunath Hadli; Brijesh Jadav; Chaithrika U S
Subject: [PATCH v3 0/4] ARM: DaVinci: DM646x Video: DM646x display driver

Display driver for TI DM646x EVM

These patches add the display driver support for TI DM646x EVM. This patch set has been tested for basic display functionality for Composite and Component outputs.

This patch set consists of the updates based on the review comments by Hans Verkuil.

Patch 1: Display device platform and board setup Patch 2: VPIF driver
Patch 3: DM646x display driver
Patch 4: Makefile and config files modifications for Display

Quoted 6 lines

Some of the features like the HBI/VBI support are not yet implemented. Also there are some known issues in the code implementation like fine tuning to be done to TRY_FMT ioctl.The USERPTR usage has not been tested extensively.

-Chaithrika

--
To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

Signature · 1 line
Hans Verkuil - video4linux developer - sponsored by TANDBERG
author
#3 lore raw

Hans,

Quoted 9 lines

-----Original Message-----
From: Hans Verkuil [mailto:[email protected]]
Sent: Thursday, May 21, 2009 7:45 PM
To: chaithrika
Cc: [email protected]; davinci-linux-open- [email protected]; 'Manjunath Hadli'; 'Brijesh Jadav'
Subject: Re: [PATCH v3 0/4] ARM: DaVinci: DM646x Video: DM646x display driver

Quoted 9 lines
Quoted 3 lines · On Thursday 21 May 2009 08:12:57 chaithrika wrote:

Hi All,

Do you have any review comments on this patch set?

I'm happy with these patches!

Thanks!

Quoted 4 lines

There is one thing that can be improved, though. It is really an enhancement
and does not prevent this from being merged.

Quoted 10 lines

Currently the isr routine refuses to switch to the next frame if the dma
queue is empty. However, I see no reason for this: it should always go to
that frame regardless and keep that until new frames are queued. I've made
this change in the (very old) driver I use at work, but this should become
standard behavior.

OK. I will look into this.

Thanks,
Chaithrika

Quoted 56 lines

Regards,

Hans

Quoted 9 lines

Regards,
Chaithrika

Quoted 5 lines

-----Original Message-----
From: Chaithrika U S [mailto:[email protected]]
Sent: Friday, May 08, 2009 6:55 PM
To: [email protected]
Cc: [email protected]; Manjunath

Hadli;

Quoted 10 lines
Quoted 10 lines

Brijesh Jadav; Chaithrika U S
Subject: [PATCH v3 0/4] ARM: DaVinci: DM646x Video: DM646x display driver

Display driver for TI DM646x EVM

Quoted 5 lines
Quoted 5 lines

These patches add the display driver support for TI DM646x EVM. This patch set has been tested for basic display functionality for Composite and Component outputs.

This patch set consists of the updates based on the review comments

by

Quoted 8 lines
Quoted 8 lines

Hans Verkuil.

Patch 1: Display device platform and board setup Patch 2: VPIF driver
Patch 3: DM646x display driver
Patch 4: Makefile and config files modifications for Display

Some of the features like the HBI/VBI support are not yet

implemented.

Quoted 2 lines
Quoted 2 lines

Also there are some known issues in the code implementation like fine tuning to be done to TRY_FMT ioctl.The USERPTR usage has not

been

Quoted 6 lines
Quoted 3 lines

tested extensively.

-Chaithrika

--
To unsubscribe from this list: send the line "unsubscribe linux-

media" in

Quoted 2 lines

the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

--
Hans Verkuil - video4linux developer - sponsored by TANDBERG