nfs: Fix NFS v4 client handling of MAY_EXEC in nfs_permission.
Subsystems (2)
PATCH 1/1 nfs: Fix NFS v4 client handling of MAY_EXEC in nfs_permission.
The problem is that permission checking is skipped if atomic open is possible, but when exec opens a file, it just opens it O_READONLY which means EXEC permission will not be checked at that time.
This problem is observed by the following sequence (executed as root):
mount -t nfs4 server:/ /mnt4
echo "ls" >/mnt4/foo
chmod 744 /mnt4/foo
su guest -c "mnt4/foo"
--- fs/nfs/dir.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-)
fs/nfs/dir.c +2 -1
@@ -1943,7 +1943,8 @@ int nfs_permission(struct inode *inode, int mask)case S_IFREG :/* NFSv4 has atomic_open... */ if (nfs_server_capable (inode,NFS_CAP_ATOMIC_OPEN ) - && (mask &MAY_OPEN )) + && (mask &MAY_OPEN ) + && !(mask &MAY_EXEC )) goto out;break ;case S_IFDIR :
Signature · 18 lines
1.5.2.2 ------------------------------------------------------------------------------ The NEW KODAK i700 Series Scanners deliver under ANY circumstances! Your production scanning environment may not be a perfect world - but thanks to Kodak, there's a perfect scanner to get the job done! With the NEW KODAK i700 Series Scanner you'll get full speed at 300 dpi even with all image processing features enabled. http://p.sf.net/sfu/kodak-com _______________________________________________ NFS maillist - [email protected] https://lists.sourceforge.net/lists/listinfo/nfs _______________________________________________ Please note that [email protected] is being discontinued. Please subscribe to [email protected] instead. http://vger.kernel.org/vger-lists.html#linux-nfs
Quoted 4 lines · Frank Filz
The problem is that permission checking is skipped if atomic open is possible, but when exec opens a file, it just opens it
O_READONLYwhich means EXEC permission will not be checked at that time.
Quoted 8 lines
This problem is observed by the following sequence (executed as root):
mount -t nfs4 server:/ /mnt4
echo "ls" >/mnt4/foo
chmod 744 /mnt4/foo
su guest -c "mnt4/foo"Signed-off-by Frank Filz <ffilzlnx at us.ibm.com>
I have tested this on 2.6.29.3, and I can confirm that the patch fixed the problem.
Btw, this looks like the same problem that was reported in 2006:
http://linux-nfs.org/pipermail/nfsv4/2006-November/005323.html
http://linux-nfs.org/pipermail/nfsv4/2006-November/005313.html
http://bugzilla.linux-nfs.org/show_bug.cgi?id=131
Thanks, Eugene
_______________________________________________
NFSv4 mailing list
[email protected]
http://linux-nfs.org/cgi-bin/mailman/listinfo/nfsv4