jffs2: move jffs2_write_super to super.c
Subsystems (2)
PATCH 1/2 jffs2: move jffs2_write_super to super.c
jffs2_write_super is only called from super.c and doesn't use any functionality from fs.c. So move it over to super.c and make it static there.
[should go in through the vfs tree as it is a requirement for the
next patch]
Signed-off-by Christoph Hellwig <[email protected]>
fs/jffs2/fs.c +0 -15
@@ -402,21 +402,6 @@ int jffs2_remount_fs (struct super_blockreturn 0 ; } -void jffs2_write_super (struct super_block *sb) -{ -struct jffs2_sb_info *c =JFFS2_SB_INFO (sb); - sb->s_dirt =0 ; - -if (sb->s_flags &MS_RDONLY ) -return ; - -D1 (printk (KERN_DEBUG "jffs2_write_super()\n" )); -jffs2_garbage_collect_trigger (c); -jffs2_erase_pending_blocks (c,0 ); -jffs2_flush_wbuf_gc (c,0 ); -} - -/* jffs2_new_inode: allocate a new inode and inocache, add it to the hash, fill in the raw_inode while you're at it. */ struct inode *jffs2_new_inode (struct inode *dir_i,int mode,struct jffs2_raw_inode *ri)
fs/jffs2/os-linux.h +0 -1
@@ -181,7 +181,6 @@ void jffs2_dirty_inode(struct inode *inostruct inode *jffs2_new_inode (struct inode *dir_i,int mode,struct jffs2_raw_inode *ri);int jffs2_statfs (struct dentry *,struct kstatfs *); -void jffs2_write_super (struct super_block *);int jffs2_remount_fs (struct super_block *,int *,char *);int jffs2_do_fill_super (struct super_block *sb,void *data,int silent); void jffs2_gc_release_inode(struct jffs2_sb_info *c,
fs/jffs2/super.c +14 -0
@@ -53,6 +53,20 @@ static void jffs2_i_init_once(void *foo)inode_init_once (&f->vfs_inode); } +static void jffs2_write_super (struct super_block *sb) +{ +struct jffs2_sb_info *c =JFFS2_SB_INFO (sb); + sb->s_dirt =0 ; + +if (sb->s_flags &MS_RDONLY ) +return ; + +D1 (printk (KERN_DEBUG "jffs2_write_super()\n" )); +jffs2_garbage_collect_trigger (c); +jffs2_erase_pending_blocks (c,0 ); +jffs2_flush_wbuf_gc (c,0 ); +} +static int jffs2_sync_fs (struct super_block *sb,int wait) {struct jffs2_sb_info *c =JFFS2_SB_INFO (sb);
Quoted 9 lines · Christoph Hellwig
jffs2_write_superis only called fromsuper.cand doesn't use any functionality fromfs.c. So move it over tosuper.cand make it static there.[should go in through the vfs tree as it is a requirement for the
next patch]Signed-off-by Christoph Hellwig <[email protected]>
Acked-by David Woodhouse <[email protected]>
There are sometimes Linux-specific files split from generic files, which supports ports like eCos. But this isn't one of those cases. And I'm less inclined to care these days anyway -- I don't think eCos has updated from our tree for ages now.
Signature · 2 lines
David Woodhouse Open Source Technology Centre [email protected] Intel Corporation