qmake5_base.bbclass: fix typo
A message that is not in the archive (sent off-list or not yet received): [email protected]
PATCH 1/1 qmake5_base.bbclass: fix typo
In the qt.conf file created, fix typo on "TargetSpec" (was "TartgetSpec").
--- classes/qmake5_base.bbclass | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
classes/qmake5_base.bbclass +1 -1
@@ -79,7 +79,7 @@ HostBinaries = ${OE_QMAKE_PATH_HOST_BINS} HostData = ${OE_QMAKE_PATH_HOST_DATA} HostLibraries = ${OE_QMAKE_PATH_HOST_LIBS} HostSpec = ${OE_QMAKESPEC} -TartgetSpec = ${OE_XQMAKESPEC} +TargetSpec = ${OE_XQMAKESPEC} ExternalHostBinaries = ${OE_QMAKE_PATH_EXTERNAL_HOST_BINS} Sysroot = ${STAGING_DIR_TARGET} EOF
Signature · 1 line
2.3.5
Quoted 1 line · Alexis Cellier
In the qt.conf file created, fix typo on "TargetSpec" (was "TartgetSpec").
How was this tested before sending?
In my builds it causes:
| Cannot read /OE/build/oe-core/tmp-glibc/work/i586-oe-linux/qtbase/5.4.1+gitAUTOINC+f58e882b75-r0/build/mkspecs/linux-oe-g++/qmake.conf: No such file or directory | Could not read qmake configuration file /OE/build/oe-core/tmp-glibc/work/i586-oe-linux/qtbase/5.4.1+gitAUTOINC+f58e882b75-r0/build/mkspecs/linux-oe-g++/qmake.conf.
So I agree it's a typo, but if we cannot make it work, then we should remove the line completely.
Quoted 26 lines
Signed-off-by Alexis Cellier <[email protected]>--- classes/qmake5_base.bbclass | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)classes/qmake5_base.bbclass +1
-1@@ -79,7 +79,7 @@ HostBinaries = ${OE_QMAKE_PATH_HOST_BINS} HostData = ${OE_QMAKE_PATH_HOST_DATA} HostLibraries = ${OE_QMAKE_PATH_HOST_LIBS} HostSpec = ${OE_QMAKESPEC} -TartgetSpec = ${OE_XQMAKESPEC} +TargetSpec = ${OE_XQMAKESPEC} ExternalHostBinaries = ${OE_QMAKE_PATH_EXTERNAL_HOST_BINS} Sysroot = ${STAGING_DIR_TARGET} EOFSignature · 6 lines
2.3.5 -- _______________________________________________ Openembedded-devel mailing list [email protected] http://lists.openembedded.org/mailman/listinfo/openembedded-devel
Signature · 1 line
Martin 'JaMa' Jansa jabber: [email protected]
----- Mail original -----
Quoted 10 lines
De: "Martin Jansa" <[email protected]>
À: [email protected]
Envoyé: Mercredi 29 Avril 2015 16:27:18
Objet: Re: [oe] [meta-qt5][PATCH] qmake5_base.bbclass: fix typoQuoted 2 lines · Alexis Cellier
In the qt.conf file created, fix typo on "TargetSpec" (was "TartgetSpec").
How was this tested before sending?
Oh sorry, I've missed that I've also had a change in the file qtbase.inc:
# qtbase is exception, we need to use mkspecs from ${S}
-QMAKE_MKSPEC_PATH = "${B}"
+QMAKE_MKSPEC_PATH = "${S}"You want me to make a second patch or a new patch (or nothing)?
Quoted 9 lines
In my builds it causes:
| Cannot read | /OE/build/oe-core/tmp-glibc/work/i586-oe-linux/qtbase/5.4.1+gitAUTOINC+f58e882b75-r0/build/mkspecs/linux-oe-g++/qmake.conf: | No such file or directory | Could not read qmake configuration file | /OE/build/oe-core/tmp-glibc/work/i586-oe-linux/qtbase/5.4.1+gitAUTOINC+f58e882b75-r0/build/mkspecs/linux-oe-g++/qmake.conf.So I agree it's a typo, but if we cannot make it work, then we should remove the line completely.
It is needed for qmake project that does not used qt (it's how I found the typo). About this, it seems that when you don't install qtbase, you don't have the mkspecs in the libdir, so you need to override the mkspecs path by the native mkspecs path, as you only have built qtbase-native (added by qmake5.bbclass). But I should open another thread for this, when I'll be sure about this.
Quoted 36 lines
Quoted 21 lines
Signed-off-by Alexis Cellier <[email protected]>--- classes/qmake5_base.bbclass | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)classes/qmake5_base.bbclass +1
-2@@ -79,7 +79,7 @@ HostBinaries = ${OE_QMAKE_PATH_HOST_BINS} HostData = ${OE_QMAKE_PATH_HOST_DATA} HostLibraries = ${OE_QMAKE_PATH_HOST_LIBS} HostSpec = ${OE_QMAKESPEC} -TartgetSpec = ${OE_XQMAKESPEC} +TargetSpec = ${OE_XQMAKESPEC} ExternalHostBinaries = ${OE_QMAKE_PATH_EXTERNAL_HOST_BINS} Sysroot = ${STAGING_DIR_TARGET} EOF --Quoted 6 lines
2.3.5
--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel--
Martin 'JaMa' Jansa jabber: [email protected]
--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel
Signature · 2 lines
Alexis Cellier OpenWide Ingénierie
Quoted 20 lines · Alexis Cellier
----- Mail original -----
Quoted 10 lines
De: "Martin Jansa" <[email protected]>
À: [email protected]
Envoyé: Mercredi 29 Avril 2015 16:27:18
Objet: Re: [oe] [meta-qt5][PATCH] qmake5_base.bbclass: fix typoQuoted 2 lines · Alexis Cellier
In the qt.conf file created, fix typo on "TargetSpec" (was "TartgetSpec").
How was this tested before sending?
Oh sorry, I've missed that I've also had a change in the file qtbase.inc:
# qtbase is exception, we need to use mkspecs from ${S}(quoted diff) +1
-1-QMAKE_MKSPEC_PATH = "${B}" +QMAKE_MKSPEC_PATH = "${S}"
Quoted 1 line
You want me to make a second patch or a new patch (or nothing)?
nothing, I'll amend your patch with this change before sending it for another round of jenkins builds, thanks
Does the same apply for nativesdk-qtbase.inc?
Quoted 64 lines
Quoted 10 lines
In my builds it causes:
| Cannot read | /OE/build/oe-core/tmp-glibc/work/i586-oe-linux/qtbase/5.4.1+gitAUTOINC+f58e882b75-r0/build/mkspecs/linux-oe-g++/qmake.conf: | No such file or directory | Could not read qmake configuration file | /OE/build/oe-core/tmp-glibc/work/i586-oe-linux/qtbase/5.4.1+gitAUTOINC+f58e882b75-r0/build/mkspecs/linux-oe-g++/qmake.conf.So I agree it's a typo, but if we cannot make it work, then we should remove the line completely.
It is needed for qmake project that does not used qt (it's how I found the typo). About this, it seems that when you don't install qtbase, you don't have the mkspecs in the libdir, so you need to override the mkspecs path by the native mkspecs path, as you only have built qtbase-native (added by qmake5.bbclass). But I should open another thread for this, when I'll be sure about this.
Quoted 36 lines
Quoted 21 lines
Signed-off-by Alexis Cellier <[email protected]>--- classes/qmake5_base.bbclass | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)classes/qmake5_base.bbclass +1
-2@@ -79,7 +79,7 @@ HostBinaries = ${OE_QMAKE_PATH_HOST_BINS} HostData = ${OE_QMAKE_PATH_HOST_DATA} HostLibraries = ${OE_QMAKE_PATH_HOST_LIBS} HostSpec = ${OE_QMAKESPEC} -TartgetSpec = ${OE_XQMAKESPEC} +TargetSpec = ${OE_XQMAKESPEC} ExternalHostBinaries = ${OE_QMAKE_PATH_EXTERNAL_HOST_BINS} Sysroot = ${STAGING_DIR_TARGET} EOF --Quoted 6 lines
2.3.5
--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel--
Martin 'JaMa' Jansa jabber: [email protected]
--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-develSignature · 7 lines
Alexis Cellier OpenWide Ingénierie -- _______________________________________________ Openembedded-devel mailing list [email protected] http://lists.openembedded.org/mailman/listinfo/openembedded-devel
Signature · 1 line
Martin 'JaMa' Jansa jabber: [email protected]