Skip to contentSkip to conversation

hwmon: (lm78) add missing __devexit_p()

PATCH In review Mike Frysinger 2 participants 2 messages May 15, 2009 – May 16, 2009

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 hwmon: (lm78) add missing __devexit_p()

The remove function uses __devexit, so the .remove assignment needs __devexit_p() to fix a build error with hotplug disabled.

---
 drivers/hwmon/lm78.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/hwmon/lm78.c +1 -1
index b5e3b28..a1787fd 100644
@@ -182,7 +182,7 @@ static struct platform_driver lm78_isa_driver = {
 		.name	= "lm78",
 	},
 	.probe		= lm78_isa_probe,
-	.remove		= lm78_isa_remove,
+	.remove		= __devexit_p(lm78_isa_remove),
 };
 
 
Signature · 1 line
1.6.3
#1 lore raw

Hi Mike,

Quoted 14 lines · Mike Frysinger

The remove function uses __devexit, so the .remove assignment needs __devexit_p() to fix a build error with hotplug disabled.

---
 drivers/hwmon/lm78.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/hwmon/lm78.c +0 -0
index b5e3b28..a1787fd 100644

drivers/hwmon/lm78.c static struct platform_driver lm78_isa_driver = { · line 188

Quoted 8 lines
drivers/hwmon/lm78.c +1 -1
@@ -182,7 +182,7 @@ static struct platform_driver lm78_isa_driver = {
 		.name	= "lm78",
 	},
 	.probe		= lm78_isa_probe,
-	.remove		= lm78_isa_remove,
+	.remove		= __devexit_p(lm78_isa_remove),
 };
 
 

Good catch. Applied, thanks!

Signature · 1 line
Jean Delvare