common/octeontx2: cleanup void returns
PATCH 1/1 common/octeontx2: cleanup void returns
From: Krzysztof Kanas <[email protected]>
mbox_unregister_vf_irq and mbox_unregister_pf_irq returns void value. mbox_unregister_irq also returns void.
Clang with flags '-Wall -Wextra -pedantic' complains about:
void function should not return void expression
Signed-off-by Krzysztof Kanas <[email protected]>
--- drivers/common/octeontx2/otx2_dev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/common/octeontx2/otx2_dev.c +2 -2
@@ -744,9 +744,9 @@ static void mbox_unregister_irq(struct rte_pci_device *pci_dev, struct otx2_dev *dev) { if (otx2_dev_is_vf(dev)) - return mbox_unregister_vf_irq(pci_dev, dev); + mbox_unregister_vf_irq(pci_dev, dev); else - return mbox_unregister_pf_irq(pci_dev, dev); +mbox_unregister_pf_irq (pci_dev, dev); } static int
Signature · 1 line
2.21.0
Thomas Monjalon
Applied08/07/2019 14:18, [email protected]:
Quoted 9 lines
From: Krzysztof Kanas <[email protected]>
mbox_unregister_vf_irqandmbox_unregister_pf_irqreturns void value.mbox_unregister_irqalso returns void.Clang with flags '-Wall -Wextra -pedantic' complains about:
void function should not return void expressionSigned-off-by Krzysztof Kanas <[email protected]>
Applied, thanks