Skip to contentSkip to conversation

common/octeontx2: cleanup void returns

PATCH Applied [email protected] 2 participants 2 messages Jul 8, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 common/octeontx2: cleanup void returns

From: Krzysztof Kanas <[email protected]>

mbox_unregister_vf_irq and mbox_unregister_pf_irq returns void value. mbox_unregister_irq also returns void.

Clang with flags '-Wall -Wextra -pedantic' complains about:
void function should not return void expression

---
 drivers/common/octeontx2/otx2_dev.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/common/octeontx2/otx2_dev.c +2 -2
index 53a0c6efbcbc..3b51fa93ad29 100644
@@ -744,9 +744,9 @@ static void
 mbox_unregister_irq(struct rte_pci_device *pci_dev, struct otx2_dev *dev)
 {
 	if (otx2_dev_is_vf(dev))
-		return mbox_unregister_vf_irq(pci_dev, dev);
+		mbox_unregister_vf_irq(pci_dev, dev);
 	else
-		return mbox_unregister_pf_irq(pci_dev, dev);
+		mbox_unregister_pf_irq(pci_dev, dev);
 }
 
 static int
Signature · 1 line
2.21.0