Skip to contentSkip to conversation

OMAP3: Zoom2: Fix missing Board and CPU info

PATCH Superseded Dirk Behme 3 participants 4 messages May 16, 2009 – May 17, 2009

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Dirk Behme

author
#0 lore raw

PATCH 1/1 OMAP3: Zoom2: Fix missing Board and CPU info

With other OMAP3 boards we recently switched to CPU and Board info API. From parallel merge, this is missing for Zoom2. Enable it for Zoom2, too.

CC Tom.Rix at windriver.com

---

Compile tested on recent u-boot next branch.

 include/configs/omap3_zoom2.h |    6 ++++++
 1 file changed, 6 insertions(+)
include/configs/omap3_zoom2.h +6 -0
Index: u-boot-main/include/configs/omap3_zoom2.h
===================================================================
@@ -43,6 +43,12 @@
 #include <asm/arch/cpu.h>	/* get chip and board defs */
 #include <asm/arch/omap3.h>
 
+/*
+ * Display CPU and Board information
+ */
+#define CONFIG_DISPLAY_CPUINFO		1
+#define CONFIG_DISPLAY_BOARDINFO	1
+
 /* Clock Defines */
 #define V_OSCK			26000000	/* Clock output from T2 */
 #define V_SCLK			(V_OSCK >> 1)
#1 lore raw

PATCH 1/1 OMAP3: Zoom2: Fix missing Board and CPU info

Ok with me.
I have verified this patch runs on zoom2.
The expected cpu and board info are displayed on startup. Tom

Quoted 31 lines · Dirk Behme

With other OMAP3 boards we recently switched to CPU and Board info API. From parallel merge, this is missing for Zoom2. Enable it for Zoom2, too.

CC Tom.Rix at windriver.com

---

Compile tested on recent u-boot next branch.

 include/configs/omap3_zoom2.h |    6 ++++++
 1 file changed, 6 insertions(+)

Index: u-boot-main/include/configs/omap3_zoom2.h
===================================================================

include/configs/omap3_zoom2.h +6 -0
@@ -43,6 +43,12 @@
 #include <asm/arch/cpu.h>	/* get chip and board defs */
 #include <asm/arch/omap3.h>
 
+/*
+ * Display CPU and Board information
+ */
+#define CONFIG_DISPLAY_CPUINFO		1
+#define CONFIG_DISPLAY_BOARDINFO	1
+
 /* Clock Defines */
 #define V_OSCK			26000000	/* Clock output from T2 */
 #define V_SCLK			(V_OSCK >> 1)
#2 lore raw

PATCH 1/1 OMAP3: Zoom2: Fix missing Board and CPU info

In reply to Dirk Behme
Quoted 3 lines · Dirk Behme

With other OMAP3 boards we recently switched to CPU and Board info API. From parallel merge, this is missing for Zoom2. Enable it for Zoom2, too.

It's an option so it's not a fix
but you enable
each board Maintainer do his own choice

Quoted 2 lines
CC Tom.Rix at windriver.com

please fill with Name <email>
as it will be part of the final commit message

Quoted 13 lines

---

Compile tested on recent u-boot next branch.

 include/configs/omap3_zoom2.h |    6 ++++++
 1 file changed, 6 insertions(+)

Index: u-boot-main/include/configs/omap3_zoom2.h
===================================================================

include/configs/omap3_zoom2.h line 50

Quoted 8 lines
include/configs/omap3_zoom2.h +5 -0
@@ -43,6 +43,12 @@
 #include <asm/arch/cpu.h>	/* get chip and board defs */
 #include <asm/arch/omap3.h>
 
+/*
+ * Display CPU and Board information
+ */
+#define CONFIG_DISPLAY_CPUINFO		1
+#define CONFIG_DISPLAY_BOARDINFO	1

it will be good to stop to add the '1' as it's not neccessarely at all

Best Regards,
J.

author
#3 lore raw

PATCH 1/1 OMAP3: Zoom2: Fix missing Board and CPU info

Dear Jean-Christophe,

Quoted 5 lines · Jean-Christophe PLAGNIOL-VILLARD
Quoted 3 lines · Dirk Behme

With other OMAP3 boards we recently switched to CPU and Board info API. From parallel merge, this is missing for Zoom2. Enable it for Zoom2, too.

It's an option so it's not a fix

It is a fix. As mentioned above, we fix the issue "Zoom2 doesn't print CPU and Board info after parallel merge of Zoom2 and OMAP3 switch to Board/CPU info API". With old logic, every OMAP3 board got info output by default. Zoom2, too. With parallel merge of Zoom2 and switch to Board/CPU info API, this was lost for Zoom2. Now we fix this to get the same behavior for Zoom2 as before the Baord/CPU API switch.

Best regards

Dirk

P.S.: Do you have already an idea when we will get the documentation for CPU/Board info API as requested in

http://lists.denx.de/pipermail/u-boot/2009-April/051420.html

(1) ? (Note: (2) was already fixed by Wolfgang)