Skip to contentSkip to conversation

nfs: Fix NFS v4 client handling of MAY_EXEC in nfs_permission.

PATCH In review Frank Filz 2 participants 2 messages May 18, 2009 – May 19, 2009

Subsystems (2)
lore
Share & tools
lore

Frank Filz

author
#0 lore raw

PATCH 1/1 nfs: Fix NFS v4 client handling of MAY_EXEC in nfs_permission.

Sorry for the resend, got lkml address wrong...

The problem is that permission checking is skipped if atomic open is possible, but when exec opens a file, it just opens it O_READONLY which means EXEC permission will not be checked at that time.

This problem is observed by the following sequence (executed as root):

mount -t nfs4 server:/ /mnt4
echo "ls" >/mnt4/foo
chmod 744 /mnt4/foo
su guest -c "mnt4/foo"

---
 fs/nfs/dir.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
fs/nfs/dir.c +2 -1
index 370b190..89f98e9 100644
@@ -1943,7 +1943,8 @@ int nfs_permission(struct inode *inode, int mask)
 		case S_IFREG:
 			/* NFSv4 has atomic_open... */
 			if (nfs_server_capable(inode, NFS_CAP_ATOMIC_OPEN)
-					&& (mask & MAY_OPEN))
+					&& (mask & MAY_OPEN)
+					&& !(mask & MAY_EXEC))
 				goto out;
 			break;
 		case S_IFDIR:
Tested-by on v1 1/1
#1 lore raw
Quoted 6 lines · Frank Filz

Sorry for the resend, got lkml address wrong...

The problem is that permission checking is skipped if atomic open is possible, but when exec opens a file, it just opens it O_READONLY which means EXEC permission will not be checked at that time.

Quoted 8 lines

This problem is observed by the following sequence (executed as root):

mount -t nfs4 server:/ /mnt4
echo "ls" >/mnt4/foo
chmod 744 /mnt4/foo
su guest -c "mnt4/foo"

Thanks, Eugene