fix potential deadlock with async scanning

PATCH New James Bottomley 1 participant 1 message May 23, 2009 SCSI

Share & tools

James Bottomley

author maintainer

2009-05-23 21:07 UTC #0 lore raw

PATCH 1/1 fix potential deadlock with async scanning

The recent attempted conversion to the async code exposed a deadlock within the existing async scanning code, whereby all external scan callers take the scan mutex, then wait for the async scans to complete. Unfortunately the async scan threads take, drop and retake this mutex, so they can deadlock.

The fix is to wait for the scans first before taking the scan mutex. The problem would only affect hosts that both call scsi_scan_host() and later add extra devices.

James

---

drivers/scsi/scsi_scan.c +3 -3

index c447838..1363420 100644
@@ -1516,10 +1516,10 @@ struct scsi_device *__scsi_add_device(struct Scsi_Host *shost, uint channel,
 	if (!starget)
 		return ERR_PTR(-ENOMEM);
 
-	mutex_lock(&shost->scan_mutex);
 	if (!shost->async_scan)
 		scsi_complete_async_scans();
 
+	mutex_lock(&shost->scan_mutex);
 	if (scsi_host_scan_allowed(shost))
 		scsi_probe_and_add_lun(starget, lun, NULL, &sdev, 1, hostdata);
 	mutex_unlock(&shost->scan_mutex);

@@ -1631,10 +1631,10 @@ void scsi_scan_target(struct device *parent, unsigned int channel,
 	if (strncmp(scsi_scan_type, "none", 4) == 0)
 		return;
 
-	mutex_lock(&shost->scan_mutex);
 	if (!shost->async_scan)
 		scsi_complete_async_scans();
 
+	mutex_lock(&shost->scan_mutex);
 	if (scsi_host_scan_allowed(shost))
 		__scsi_scan_target(parent, channel, id, lun, rescan);
 	mutex_unlock(&shost->scan_mutex);

@@ -1684,10 +1684,10 @@ int scsi_scan_host_selected(struct Scsi_Host *shost, unsigned int channel,
 	    ((lun != SCAN_WILD_CARD) && (lun > shost->max_lun)))
 		return -EINVAL;
 
-	mutex_lock(&shost->scan_mutex);
 	if (!shost->async_scan)
 		scsi_complete_async_scans();
 
+	mutex_lock(&shost->scan_mutex);
 	if (scsi_host_scan_allowed(shost)) {
 		if (channel == SCAN_WILD_CARD)
 			for (channel = 0; channel <= shost->max_channel;