Fix vga_screen_dump_blank() PPM generation
PATCH 1/1 Fix vga_screen_dump_blank() PPM generation
vga_screen_dump_blank() was not generating a valid PPM file: the width of the image made no sense (why it was multiplied by sizeof(uint32_t)?), and there was only one sample per pixel, instead of three.
Signed-off-by Eduardo Habkost <[email protected]>
--- hw/vga.c | 5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-)
hw/vga.c +3 -2
@@ -2584,8 +2584,9 @@ static void vga_screen_dump_blank(VGAState *s, const char *filename) {FILE *f;unsigned int y, x, w, h; +unsigned char blank_sample[3 ] = {0 ,0 ,0 }; - w = s->last_scr_width *sizeof (uint32_t ); + w = s->last_scr_width; h = s->last_scr_height; f =fopen (filename,"wb" );
@@ -2594,7 +2595,7 @@ static void vga_screen_dump_blank(VGAState *s, const char *filename)fprintf (f,"P6\n%d %d\n%d\n" , w, h,255 );for (y =0 ; y < h; y++) {for (x =0 ; x < w; x++) { -fputc (0 , f); +fwrite (blank_sample,3 ,1 , f); } }fclose (f);
Signature · 1 line
1.6.3.rc4.29.g8146