Skip to contentSkip to conversation

usertools: dpdk-telemetry-client.py run into looping status

PATCH In review Andrius Sirvys 3 participants 5 messages Aug 7, 2019 – Aug 8, 2019

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 usertools: dpdk-telemetry-client.py run into looping status

The ast.literal_eval() was used incorrectly and wouldn't properly retrieve the user option. Was causing the options to keep being listed in a loop. Removed and replaced with raw_input() being cast to an int. Works as expected now.

Fixes 53f293c9a783 ("usertools: replace unsafe input function")

---
v2: Removed unnecessary comments

---
 usertools/dpdk-telemetry-client.py | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
usertools/dpdk-telemetry-client.py +4 -4
index 4b0502ff9..b5b5cdcfe 100755
@@ -16,9 +16,9 @@
 DEFAULT_FP = "/var/run/dpdk/default_client"
 
 try:
-	raw_input  # Python 2
+        raw_input  # Python 2
 except NameError:
-	raw_input = input  # Python 3
+        raw_input = input  # Python 3
 
 class Socket:
 
@@ -78,7 +78,7 @@ def requestMetrics(self): # Requests metrics for given client
 
     def repeatedlyRequestMetrics(self, sleep_time): # Recursively requests metrics for given client
         print("\nPlease enter the number of times you'd like to continuously request Metrics:")
-        n_requests = int(ast.literal_eval(raw_input("\n:")))
+        n_requests = int(raw_input("\n:"))
         print("\033[F") #Removes the user input from screen, cleans it up
         print("\033[K")
         for i in range(n_requests):
@@ -99,7 +99,7 @@ def interactiveMenu(self, sleep_time): # Creates Interactive menu within the scr
             print("[4] Unregister client")
 
             try:
-                self.choice = int(ast.literal_eval(raw_input("\n:")))
+                self.choice = int(raw_input("\n:"))
                 print("\033[F") #Removes the user input for screen, cleans it up
                 print("\033[K")
                 if self.choice == 1:
Signature · 1 line
2.17.1
#1 lore raw

07/08/2019 15:04, Andrius Sirvys:

Quoted 4 lines

The ast.literal_eval() was used incorrectly and wouldn't properly retrieve the user option. Was causing the options to keep being listed in a loop. Removed and replaced with raw_input() being cast to an int. Works as expected now.

You mean you added "ast.literal_eval()" without testing it?

Kevin, that's not the first time I ask,
who is testing this telemetry stuff?
I have the bad feeling this is a toy,
and you send random untested patches for it. How I can know this patch is seriously tested enough before merging it at the last minute in 19.08?

Quoted 6 lines
Fixes 53f293c9a783 ("usertools: replace unsafe input function")

---
v2: Removed unnecessary comments

Please keep all versions in the same email thread by using --in-reply-to

usertools/dpdk-telemetry-client.py line 21

Quoted 6 lines

try:

usertools/dpdk-telemetry-client.py +2 -2
-	raw_input  # Python 2
+        raw_input  # Python 2
 except NameError:
-	raw_input = input  # Python 3
+        raw_input = input  # Python 3

Why changing this indentation?

#2 lore raw

PATCH v3 1/1 usertools: fix input handling in telemetry script

In reply to Andrius Sirvys

This commit removes the unnecesarry ast.literal_eval() function call from the input handling, which now relies just on raw_input() to get its input.

Fixes 53f293c9a783 ("usertools: replace unsafe input function")

---
v2: Removed unnecessary comments
v3: Reduced scope of changes only to required Python 2 fix

Please note that the dpdk-telemetry-client.py script has a number of issues with Python3 support. Fixing Python3 support is being deferred to DPDK 19.11 release.

---
 usertools/dpdk-telemetry-client.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
usertools/dpdk-telemetry-client.py +2 -2
index 4b0502ff9..60fe97af7 100755
@@ -78,7 +78,7 @@ def requestMetrics(self): # Requests metrics for given client
 
     def repeatedlyRequestMetrics(self, sleep_time): # Recursively requests metrics for given client
         print("\nPlease enter the number of times you'd like to continuously request Metrics:")
-        n_requests = int(ast.literal_eval(raw_input("\n:")))
+        n_requests = int(raw_input("\n:"))
         print("\033[F") #Removes the user input from screen, cleans it up
         print("\033[K")
         for i in range(n_requests):
@@ -99,7 +99,7 @@ def interactiveMenu(self, sleep_time): # Creates Interactive menu within the scr
             print("[4] Unregister client")
 
             try:
-                self.choice = int(ast.literal_eval(raw_input("\n:")))
+                self.choice = int(raw_input("\n:"))
                 print("\033[F") #Removes the user input for screen, cleans it up
                 print("\033[K")
                 if self.choice == 1:
Signature · 1 line
2.17.1
Acked-by on v3 1/1
#3 lore raw

Re: [dpdk-dev] [PATCH v3] usertools: fix input handling in telemetry script

Quoted 17 lines

-----Original Message-----
From: Sirvys, Andrius
Sent: Thursday, August 8, 2019 3:38 PM
To: Laatz, Kevin <[email protected]>
Cc: [email protected]; [email protected]; Van Haaren, Harry <[email protected]>; Ferriter, Cian <[email protected]>; Lipiec, Herakliusz <[email protected]>; Sirvys, Andrius <[email protected]>
Subject: [PATCH v3] usertools: fix input handling in telemetry script

This commit removes the unnecesarry ast.literal_eval() function call from the input handling, which now relies just on raw_input() to get its input.

Fixes 53f293c9a783 ("usertools: replace unsafe input function")
Quoted 8 lines

---
v2: Removed unnecessary comments
v3: Reduced scope of changes only to required Python 2 fix

Please note that the dpdk-telemetry-client.py script has a number of issues with Python3 support. Fixing Python3 support is being deferred to DPDK 19.11 release.

Thanks for the patch re-spin Andrius. This is the smallest change possible to fix the current issue, and I recommend including in 19.08 release.

Agree the Python3 support requires larger refactoring, which should be undertaken for 19.11.

#4 lore raw

Re: [dpdk-dev] [PATCH v3] usertools: fix input handling in telemetry script

In reply to Andrius Sirvys

08/08/2019 16:37, Andrius Sirvys:

Quoted 7 lines

This commit removes the unnecesarry ast.literal_eval() function call from the input handling, which now relies just on raw_input() to get its input.

Fixes 53f293c9a783 ("usertools: replace unsafe input function")
Quoted 8 lines

---
v2: Removed unnecessary comments
v3: Reduced scope of changes only to required Python 2 fix

Please note that the dpdk-telemetry-client.py script has a number of issues with Python3 support. Fixing Python3 support is being deferred to DPDK 19.11 release.

OK, hope it will be good enough for 19.08.
Applied, thanks