Skip to contentSkip to conversation

KVM: add localversion to avoid confusion and conflicts

PATCH In review Jaswinder Singh Rajput 4 participants 7 messages May 29, 2009 – Jun 1, 2009 KVM

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 KVM: add localversion to avoid confusion and conflicts

Adding localversion avoids confusion in kernel images :

like Linux version 2.6.30-rc7 does not tell whether it is linus or kvm kernel.

By adding localversion it tells :

Linux version 2.6.30-rc7-kvm , any doubt ;-)

Secondly, by installing modules it overwrites on linus modules.

By adding localversion :

[root@hpdv5 kvm]# make modules_install
INSTALL arch/x86/kernel/cpu/cpu_debug.ko
INSTALL arch/x86/kernel/test_nx.ko
INSTALL arch/x86/kvm/kvm-amd.ko
INSTALL arch/x86/kvm/kvm-intel.ko
INSTALL arch/x86/kvm/kvm.ko
INSTALL arch/x86/oprofile/oprofile.ko
INSTALL drivers/scsi/scsi_wait_scan.ko
INSTALL drivers/virtio/virtio.ko
INSTALL drivers/virtio/virtio_balloon.ko
INSTALL drivers/virtio/virtio_pci.ko
INSTALL drivers/virtio/virtio_ring.ko
DEPMOD 2.6.30-rc7-kvm

I am inspired by Ingo's -tip, I am sure Ingo will tell more advantages, if these are not enough :-)

---
 localversion-kvm |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
 create mode 100644 localversion-kvm
localversion-kvm new file +1 -0
new file mode 100644
index 0000000..d969ff0
@@ -0,0 +1 @@
+-kvm
Signature · 1 line
1.6.0.6
#1 lore raw

Am Freitag 29 Mai 2009 09:18:14 schrieb Jaswinder Singh Rajput:

Quoted 10 lines

Adding localversion avoids confusion in kernel images :

like Linux version 2.6.30-rc7 does not tell whether it is linus or kvm kernel.

By adding localversion it tells :

Linux version 2.6.30-rc7-kvm , any doubt ;-)
I am inspired by Ingo's -tip, I am sure Ingo will tell more advantages, if these are not enough :-)

[...]

localversion-kvm line 1

Quoted 7 lines
localversion-kvm new file +1 -0
new file mode 100644
index 0000000..d969ff0
@@ -0,0 +1 @@
+-kvm

NAK from my side. If you need a distinction, there is always CONFIG_LOCALVERSION_AUTO. If you need this kind of prefix, there is always CONFIG_LOCALVERSION.

Christian

#2 lore raw
Quoted 12 lines · Christian Bornträger

Am Freitag 29 Mai 2009 09:18:14 schrieb Jaswinder Singh Rajput:

Quoted 10 lines

Adding localversion avoids confusion in kernel images :

like Linux version 2.6.30-rc7 does not tell whether it is linus or kvm kernel.

By adding localversion it tells :

Linux version 2.6.30-rc7-kvm , any doubt ;-)
I am inspired by Ingo's -tip, I am sure Ingo will tell more advantages, if these are not enough :-)

[...]

Quoted 12 lines

localversion-kvm line 1

Quoted 7 lines
localversion-kvm new file +1 -0
new file mode 100644
index 0000000..d969ff0
@@ -0,0 +1 @@
+-kvm

NAK from my side. If you need a distinction, there is always CONFIG_LOCALVERSION_AUTO. If you need this kind of prefix, there is always CONFIG_LOCALVERSION.

Here is NAK for your NAK from my side.

This patch is only for KVM tree and not for linus tree.

Lets assume 100 developers are working on kvm tree and they use kvm tree on 2 PCs. So count becomes 200.

Like in my case I have dozen of kernel trees so I keep on swapping config between kernels. And I also need to test config from various users. So this count is countless.
I think this is the biggest point for adding localversion in -tip. It seems Ingo is busy in perfcounter stuff otherwise he will explain you more advantages.

In the least case, Can you differentiate between 1 and 200 ?

So by adding this patch we can save lot of developer's time.

--
JSR

#3 lore raw

Am Freitag 29 Mai 2009 10:43:46 schrieb Jaswinder Singh Rajput:

Quoted 4 lines
Quoted 2 lines
Quoted 1 line

Adding localversion avoids confusion in kernel images :

NAK from my side. If you need a distinction, there is always

Here is NAK for your NAK from my side.
This patch is only for KVM tree and not for linus tree.

I know that this is for the kvm tree.
I personally dont like to have a forced localversion in my kernel trees - it might break my tooling.
Anyway, If it really makes your life better I can live with these localversion files and adopt my tooling.

#4 lore raw
In reply to Jaswinder Singh Rajput
Quoted 26 lines · Jaswinder Singh Rajput
Quoted 12 lines · Christian Bornträger

Am Freitag 29 Mai 2009 09:18:14 schrieb Jaswinder Singh Rajput:

Quoted 10 lines

Adding localversion avoids confusion in kernel images :

like Linux version 2.6.30-rc7 does not tell whether it is linus or kvm kernel.

By adding localversion it tells :

Linux version 2.6.30-rc7-kvm , any doubt ;-)
I am inspired by Ingo's -tip, I am sure Ingo will tell more advantages, if these are not enough :-)

[...]

Quoted 12 lines

localversion-kvm line 1

Quoted 7 lines
localversion-kvm new file +1 -0
new file mode 100644
index 0000000..d969ff0
@@ -0,0 +1 @@
+-kvm

NAK from my side. If you need a distinction, there is always CONFIG_LOCALVERSION_AUTO. If you need this kind of prefix, there is always CONFIG_LOCALVERSION.

Quoted 1 line

Here is NAK for your NAK from my side.

And here is a NACK for your NACK of a NACK!

Quoted 13 lines

This patch is only for KVM tree and not for linus tree.

Lets assume 100 developers are working on kvm tree and they use kvm tree on 2 PCs. So count becomes 200.

Like in my case I have dozen of kernel trees so I keep on swapping config between kernels. And I also need to test config from various users. So this count is countless.
I think this is the biggest point for adding localversion in -tip. It seems Ingo is busy in perfcounter stuff otherwise he will explain you more advantages.

Quoted 3 lines

In the least case, Can you differentiate between 1 and 200 ?

So by adding this patch we can save lot of developer's time.

No this patch wastes a lot of developers time. If we accept it, than any patch that is added after it will need to be rebased before going to Linus. Unless KVM is made up of a bunch of branches like tip is, this will become more of a hassle than a benefit.

Ingo's tip/master is based off of a bunch of branches. It is not recommended to develope against tip/master. I develop against tip/tracing/core, because that is what will get pulled by Linus. tip/master is created automatically from a bunch of branches and gets rebased all the time. One of those branches is tip, which supplies the localversion. Thus, if you use tip/master, you get the localversion file. But if you develop against one of the main branches that will eventually go to Linus, then you will not have that localversion file.

-- Steve

#5 lore raw
Quoted 15 lines · Steven Rostedt
Quoted 15 lines

This patch is only for KVM tree and not for linus tree.

Lets assume 100 developers are working on kvm tree and they use kvm tree on 2 PCs. So count becomes 200.

Like in my case I have dozen of kernel trees so I keep on swapping config between kernels. And I also need to test config from various users. So this count is countless.
I think this is the biggest point for adding localversion in -tip. It seems Ingo is busy in perfcounter stuff otherwise he will explain you more advantages.

In the least case, Can you differentiate between 1 and 200 ?

Quoted 8 lines
Quoted 2 lines

So by adding this patch we can save lot of developer's time.

No this patch wastes a lot of developers time. If we accept it, than any patch that is added after it will need to be rebased before going to Linus. Unless KVM is made up of a bunch of branches like tip is, this will become more of a hassle than a benefit.

kvm.git for-linus branches are rebased anyway, since I fold patches that fix or revert other patches. I also (rarely) delay some patches in my tree but submit others that came later.

localversion would show up in linux-next, not sure if that's a problem. On the other hand, I'm not sure what it's worth.

Signature · 2 lines
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.
#6 lore raw
Quoted 3 lines · Avi Kivity

localversion would show up in linux-next, not sure if that's a problem. On the other hand, I'm not sure what it's worth.

If a localversion file with "-kvm" showed up in linux-next, I would consider that a problem.

-- Steve