Char: mxser, fix ISA board lookup
Subsystems (2)
PATCH 1/1 Char: mxser, fix ISA board lookup
From: "Peter Botha" <[email protected]>
There's a bug in the mxser kernel module that still appears in the 2.6.29.4 kernel.
mxser_get_ISA_conf takes a ioaddress as it's first argument, by passing the not of the ioaddr, you're effectively passing 0
which means it won't be able to talk to an ISA card.
I have tested this, and removing the ! fixes the problem.
--- drivers/char/mxser.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/char/mxser.c +1 -1
@@ -2715,7 +2715,7 @@ static int __init mxser_module_init(void)continue ; brd = &mxser_boards[m]; - retval =mxser_get_ISA_conf (!ioaddr[b], brd); + retval =mxser_get_ISA_conf (ioaddr[b], brd);if (retval <=0 ) { brd->info =NULL ;continue ;
Signature · 1 line
1.6.3
Quoted 11 lines · Jiri Slaby
From: "Peter Botha" <[email protected]>
There's a bug in the mxser kernel module that still appears in the 2.6.29.4 kernel.
mxser_get_ISA_conftakes a ioaddress as it's first argument, by passing the not of the ioaddr, you're effectively passing 0
which means it won't be able to talk to an ISA card.
I have tested this, and removing the ! fixes the problem.Cc "Peter Botha" <[email protected]>
It would be good if you could add your Signed-off-by here.
Quoted 1 line
Signed-off-by Jiri Slaby <[email protected]>