Skip to contentSkip to conversation

cyclictest: fix invalid comment of debugfs mount directory.

PATCH Superseded GeunSik Lim 4 participants 9 messages Jun 1, 2009 – Jun 12, 2009

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 cyclictest: fix invalid comment of debugfs mount directory.

Dear Clark Williams,

Please, Fix the "debugfs/tracing" name in cyclictest.c source file.

P.S: Now, version is differenct between shortlog(v0.39) and tags(v0.40).
Maybe, You have to check version name of shortlog table.
http://git.kernel.org/?p=linux/kernel/git/clrkwllms/rt-tests.git;a=summary

Thanks,
GeunSik Lim.

Subject: [PATCH ]cyclictest: Fix invalid comment of debugfs mount directory.

The "debugfs/tracing" name is invalid. Example,
#> mount -t debugfs nodev /sys/kernel/debug [enter] #> ln -s /sys/kernel/debug /debug [enter]

Fix directory name normally from debugfs/tracing to debug/tracing.

---
 src/cyclictest/cyclictest.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
src/cyclictest/cyclictest.c +1 -1
index be9a3f9..32a120a 100644
@@ -179,7 +179,7 @@ static char functiontracer[MAX_PATH];
 static char traceroptions[MAX_PATH];
 
 /*
- * Finds the path to the debugfs/tracing
+ * Finds the path to the debug/tracing
  */
 static int set_debugfileprefix(void)
 {
Signature · 14 lines
1.6.3.1


-----------------------------------------------
To unsubscribe from this list: send the line "unsubscribe linux-***" 
in the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

GeunSik Lim (  S A M S U N G     E L E C T R O N I C S  )
e-Mail  :1) [email protected]
         2) [email protected] , [email protected]
HomePage: http://blog.naver.com/invain/
-----------------------------------------------
#1 lore raw

On Mon, Jun 01, 2009 at 11:06:27AM +0900, GeunSik Lim wrote:

| 
| 
| Dear Clark Williams, 
| 
| Please, Fix the "debugfs/tracing" name in cyclictest.c source file. 
| 
| P.S: Now, version is differenct between shortlog(v0.39) and tags(v0.40). 
|      Maybe, You have to check version name of shortlog table. 
|      http://git.kernel.org/?p=linux/kernel/git/clrkwllms/rt-tests.git;a=summary
| 
| Thanks,
| GeunSik Lim. 
| 
| 
| 
| Subject: [PATCH ]cyclictest: Fix invalid comment of debugfs mount directory.
| 
| The "debugfs/tracing" name is invalid.
| Example,
| #> mount -t debugfs nodev /sys/kernel/debug [enter]
| #> ln -s /sys/kernel/debug /debug [enter]
| 
| Fix directory name normally from debugfs/tracing to debug/tracing.

GeunSik,

I would suggest changing your comment in the patch to something like:

	/* finds the path to the tracing dir inside debugfs mountpoint */

Because it is not written in the stone where debugfs should be mounted. There is a suggested place, that already changed at least twice. So, the function locates the debugfs mountpoint, wherever it is and looks for the tracing directory.

Luis

|          Signed-off-by: GeunSik Lim <[email protected]>
| ---
|  src/cyclictest/cyclictest.c |    2 +-
|  1 files changed, 1 insertions(+), 1 deletions(-)
| 
| diff --git a/src/cyclictest/cyclictest.c b/src/cyclictest/cyclictest.c
| index be9a3f9..32a120a 100644
| --- a/src/cyclictest/cyclictest.c
| +++ b/src/cyclictest/cyclictest.c
| @@ -179,7 +179,7 @@ static char functiontracer[MAX_PATH];
|  static char traceroptions[MAX_PATH];
|  
|  /*
| - * Finds the path to the debugfs/tracing
| + * Finds the path to the debug/tracing
|   */
|  static int set_debugfileprefix(void)
|  {
| -- 
| 1.6.3.1
Signature · 2 lines
[ Luis Claudio R. Goncalves             Red Hat  -  Realtime Team ]
[ Fingerprint: 4FDD B8C4 3C59 34BD 8BE9  2696 7203 D980 A448 C8F8 ]
#2 lore raw
Quoted 9 lines · Luis Claudio R. Goncalves

GeunSik,
I would suggest changing your comment in the patch to something like:

       /* finds the path to the tracing dir inside debugfs mountpoint */

Because it is not written in the stone where debugfs should be mounted. There is a suggested place, that already changed at least twice. So, the function locates the debugfs mountpoint, wherever it is and looks for the tracing directory.

Thanks your opinion. It's right.
I will modify ftrace directory name from "debug/tracing" to " tracing".

Signature · 14 lines
Regards,
GeunSik Lim ( SAMSUNG ELECTRONICS)
Blog : http://blog.naver.com/invain/
e-Mail: [email protected]
           [email protected] , [email protected]
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/
--
To unsubscribe from this list: send the line "unsubscribe linux-rt-users" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
#3 lore raw

PATCH v2 1/1 cyclictest: fix invalid comment of debugfs mount directory.

In reply to GeunSik Lim

Dear Clark Williams,

This is tracing directory's comment related patch files. Please, merge my patch.

Regards,
GeunSik Lim.

Subject: [PATCH V2] cyclictest: Fix invalid comment of debugfs mount directory.

The "debugfs/tracing" name is invalid in cyclictest.c source file. Example,
#> mount -t debugfs nodev /sys/kernel/debug [enter]
#> ln -s /sys/kernel/debug /debug [enter]
#> ls /debug/tracing [enter]

I updated a initial patch thanks to Luis Claudio R. Goncalves. Fix directory name normally from debugfs/tracing to */tracing.

---
 src/cyclictest/cyclictest.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)
src/cyclictest/cyclictest.c +3 -1
index be9a3f9..2186de2 100644
@@ -179,7 +179,9 @@ static char functiontracer[MAX_PATH];
 static char traceroptions[MAX_PATH];
 
 /*
- * Finds the path to the debugfs/tracing
+ * Finds the path to the tracing direcroty inside the default 
+ * mountpoint of debugfs filesystem.
+ * - debugfs related reference: http://lwn.net/Articles/334546/
  */
 static int set_debugfileprefix(void)
 {
Signature · 15 lines
1.6.3.1



-----------------------------------------------
To unsubscribe from this list: send the line "unsubscribe linux-***" 
in the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

GeunSik Lim ( Samsung Electronics )
e-Mail  :1) [email protected]
         2) [email protected] , [email protected]
HomePage: http://blog.naver.com/invain/
-----------------------------------------------
#4 lore raw

PATCH RESEND v2 1/1 cyclictest: fix invalid comment of debugfs mount directory.

Dear Clark Williams,

This is tracing(ftrace) directory's comment related patch file. Please, merge this patch.

Regards,
GeunSik Lim.

Subject: [RESEND] [PATCH V2 ]cyclictest: Fix invalid comment of debugfs mount directory.

The "debugfs/tracing" name is invalid as the mountpont of debugfs filesystem.

For example,
/sys/kernel/debug/tracing/ or
/debug/tracing/ or
/debugfs/tracing/ ...

Fix directory name normally from debugfs/tracing to */tracing.

---
 src/cyclictest/cyclictest.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)
src/cyclictest/cyclictest.c +3 -1
index be9a3f9..2186de2 100644
@@ -179,7 +179,9 @@ static char functiontracer[MAX_PATH];
 static char traceroptions[MAX_PATH];
 
 /*
- * Finds the path to the debugfs/tracing
+ * Finds the path to the tracing direcroty inside the default 
+ * mountpoint of debugfs filesystem.
+ * - debugfs related reference: http://lwn.net/Articles/334546/
  */
 static int set_debugfileprefix(void)
 {
Signature · 16 lines
1.6.3.1




-----------------------------------------------
To unsubscribe from this list: send the line "unsubscribe linux-***" 
in the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

GeunSik Lim ( Samsung Electronics )
e-Mail  :1) [email protected]
         2) [email protected] , [email protected]
HomePage: http://blog.naver.com/invain/
-----------------------------------------------
#5 lore raw

Hi,

Quoted 20 lines · GeunSik Lim

Dear Clark Williams,

This is tracing(ftrace) directory's comment related patch file. Please, merge this patch.

Regards,
GeunSik Lim.

Subject: [RESEND] [PATCH V2 ]cyclictest: Fix invalid comment of debugfs mount directory.

The "debugfs/tracing" name is invalid as the mountpont of debugfs filesystem.

For example,
/sys/kernel/debug/tracing/ or
/debug/tracing/ or
/debugfs/tracing/ ...

Quoted 4 lines

Fix directory name normally from debugfs/tracing to */tracing.

hhm, I don't know how Clark handles these flags, but I wouldn't count the comments by Luis Claudio R. Goncalves as review. Still more as you didn't follow his advice and I would only add this tag after the reviewer is OK with the result.
<nitpick>
In the kernel the colons and names usually are not aligned. </nitpick>

Quoted 9 lines
---
 src/cyclictest/cyclictest.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)
src/cyclictest/cyclictest.c +0 -0
index be9a3f9..2186de2 100644

src/cyclictest/cyclictest.c static char functiontracer[MAX_PATH]; · line 182

Quoted 5 lines
src/cyclictest/cyclictest.c +1 -1
@@ -179,7 +179,9 @@ static char functiontracer[MAX_PATH];
 static char traceroptions[MAX_PATH];
 
 /*
- * Finds the path to the debugfs/tracing
+ * Finds the path to the tracing direcroty inside the default 

s/direcroty/directory/

src/cyclictest/cyclictest.c static char functiontracer[MAX_PATH]; · line 184

Quoted 2 lines
src/cyclictest/cyclictest.c +2 -0
+ * mountpoint of debugfs filesystem.
+ * - debugfs related reference: http://lwn.net/Articles/334546/

set_debugfileprefix doesn't depend on a "default mountpoint", it parses /proc/mounts, so it should even work if you mount it somewhere below /home.

And I'm not convinced that adding a link to lwn is a good idea. I would expect that the normal cyclictest hacker knows about debugfs.

So what about simply

+ * Finds the tracing directory in a mounted debugfs.

? Ah, just see that is similar to the suggestion by Luis Claudio R. Goncalves.

Best regards
Uwe

Signature · 6 lines
Pengutronix e.K.                              | Uwe Kleine-König            |
Industrial Linux Solutions                    | http://www.pengutronix.de/  |
--
To unsubscribe from this list: send the line "unsubscribe linux-rt-users" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
#6 lore raw

2009/6/8 Uwe Kleine-König <[email protected]>:

Quoted 9 lines
Quoted 2 lines

         Reviewed-by  : Luis Claudio R. Goncalves <[email protected]>

hhm, I don't know how Clark handles these flags, but I wouldn't count the comments by Luis Claudio R. Goncalves as review.  Still more as you didn't follow his advice and I would only add this tag after the reviewer is OK with the result.
<nitpick>
In the kernel the colons and names usually are not aligned. </nitpick>

Thank you for your advice and opinion about my trivital patch. Sorry. Maybe, I mistooked about how to append "Reviewed-by tag".

Quoted 6 lines
Quoted 2 lines

+ * mountpoint of debugfs filesystem.
+ * - debugfs related reference: http://lwn.net/Articles/334546/

set_debugfileprefix doesn't depend on a "default mountpoint", it parses /proc/mounts, so it should even work if you mount it somewhere below /home. And I'm not convinced that adding a link to lwn is a good idea.  I would expect that the normal cyclictest hacker knows about debugfs.

Yes, It's correct. But, I think that a detailed remark is not bad.

Quoted 7 lines

So what about simply

+ * Finds the tracing directory in a mounted debugfs.

?  Ah, just see that is similar to the suggestion by Luis Claudio R. Goncalves.

Your comment is also correct.
Anyway, I want Clark to edit "debugfs/tracing" comment with a suitable expression normally.

Signature · 14 lines
Regards,
GeunSik Lim ( Samsung Electronics )
Blog : http://blog.naver.com/invain/
e-Mail: [email protected]
           [email protected] , [email protected]
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/
--
To unsubscribe from this list: send the line "unsubscribe linux-rt-users" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
#7 lore raw

PATCH 1/1 Make comment describing set_debugfileprefix a bit clearer

In reply to Uwe Kleine-König

This was noticed by GeunSik Lim.

Cc GeunSik Lim <[email protected]>
Cc Luis Claudio R. Goncalves <[email protected]>
Cc Clark Williams <[email protected]>

---
Hello,

just to have the alternative suggestion in patch form, too.

@Clark: If you prefer this version, too, you can pull it from my repo at:

git://git.pengutronix.de/git/ukl/rt-tests.git for-clark

together with a manpage format fix.

Best regards
Uwe

 src/cyclictest/cyclictest.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
src/cyclictest/cyclictest.c +1 -1
index be9a3f9..558091e 100644
@@ -179,7 +179,7 @@ static char functiontracer[MAX_PATH];
 static char traceroptions[MAX_PATH];
 
 /*
- * Finds the path to the debugfs/tracing
+ * Finds the tracing directory in a mounted debugfs
  */
 static int set_debugfileprefix(void)
 {
Signature · 5 lines
1.6.3.1
--
To unsubscribe from this list: send the line "unsubscribe linux-rt-users" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
#8 lore raw

Re: [PATCH] Make comment describing set_debugfileprefix a bit clearer

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Quoted 11 lines · On Fri, 12 Jun 2009 15:41:26 +0200 Uwe Kleine-König…

This was noticed by GeunSik Lim.

Cc GeunSik Lim <[email protected]>
Cc Luis Claudio R. Goncalves <[email protected]>
Cc Clark Williams <[email protected]>

---
Hello,

just to have the alternative suggestion in patch form, too.

Quoted 9 lines

@Clark: If you prefer this version, too, you can pull it from my repo at:

git://git.pengutronix.de/git/ukl/rt-tests.git for-clark

together with a manpage format fix.

Best regards
Uwe

Thanks Uwe (and GeunSik). I pulled from the above and merged.

I'm working on getting hwlatdetect to work properly with jcm's latest version, so it will be a bit before I push a new version of rt-tests.

Clark
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.10 (GNU/Linux)

iEYEARECAAYFAkoydesACgkQHyuj/+TTEp0qEwCeLHj9Z8SzdX1zSLPJnvMV6p0+ VscAn2KTlSinzvkIWSrBNW3oLztgRqKA
=JCFd
-----END PGP SIGNATURE-----