Skip to contentSkip to conversation

x86: perf_counter AMD supports performance monitoring for K7

PATCH In review Jaswinder Singh Rajput 2 participants 3 messages Jun 10, 2009 – Jun 11, 2009 x86

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 x86: perf_counter AMD supports performance monitoring for K7

---
 arch/x86/kernel/cpu/perf_counter.c |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)
arch/x86/kernel/cpu/perf_counter.c +4 -0
index 240ca56..5d56742 100644
@@ -1436,6 +1436,10 @@ static int intel_pmu_init(void)
 
 static int amd_pmu_init(void)
 {
+	/* performance-monitoring supported from K7 */
+	if (boot_cpu_data.x86 < 7)
+		return -ENODEV;
+
 	x86_pmu = amd_pmu;
 
 	switch (boot_cpu_data.x86) {
Signature · 1 line
1.6.1.1
#1 lore raw
Quoted 11 lines · Jaswinder Singh Rajput
---
 arch/x86/kernel/cpu/perf_counter.c |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)
arch/x86/kernel/cpu/perf_counter.c +0 -0
index 240ca56..5d56742 100644

arch/x86/kernel/cpu/perf_counter.c static int intel_pmu_init(void) · line 1445

Quoted 10 lines
arch/x86/kernel/cpu/perf_counter.c +4 -0
@@ -1436,6 +1436,10 @@ static int intel_pmu_init(void)
 
 static int amd_pmu_init(void)
 {
+	/* performance-monitoring supported from K7 */
+	if (boot_cpu_data.x86 < 7)
+		return -ENODEV;
+
 	x86_pmu = amd_pmu;
 
 	switch (boot_cpu_data.x86) {

A commit under Linux consists of three parts:

1) the title
2) the changlog
3) the body

This sloppy patch of yours manages to get _all_ three wrong:

- the title is wrong (it is incorrect)
- the changelog is wrong (it is missing)
- the body is wrong (it is broken - K7 != family 7)

What the heck is going on here?

Ingo

#2 lore raw
Quoted 30 lines · Ingo Molnar
Quoted 11 lines · Jaswinder Singh Rajput
---
 arch/x86/kernel/cpu/perf_counter.c |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)
arch/x86/kernel/cpu/perf_counter.c +0 -0
index 240ca56..5d56742 100644

arch/x86/kernel/cpu/perf_counter.c static int intel_pmu_init(void) · line 1445

Quoted 10 lines
arch/x86/kernel/cpu/perf_counter.c +4 -0
@@ -1436,6 +1436,10 @@ static int intel_pmu_init(void)
 
 static int amd_pmu_init(void)
 {
+	/* performance-monitoring supported from K7 */
+	if (boot_cpu_data.x86 < 7)
+		return -ENODEV;
+
 	x86_pmu = amd_pmu;
 
 	switch (boot_cpu_data.x86) {

A commit under Linux consists of three parts:

1) the title
2) the changlog
3) the body

Quoted 6 lines

This sloppy patch of yours manages to get _all_ three wrong:

- the title is wrong (it is incorrect)
- the changelog is wrong (it is missing)
- the body is wrong (it is broken - K7 != family 7)

oops, sorry here is updated patch :

[PATCH -tip] x86: perf_counter check AMD performance monitoring support

AMD supports performance monitoring from K7.

---
 arch/x86/kernel/cpu/perf_counter.c |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)
arch/x86/kernel/cpu/perf_counter.c +4 -0
index 57ae1be..719a7d5 100644
@@ -1452,6 +1452,10 @@ static int intel_pmu_init(void)
 
 static int amd_pmu_init(void)
 {
+	/* performance-monitoring supported from K7 */
+	if (boot_cpu_data.x86 < 6)
+		return -ENODEV;
+
 	x86_pmu = amd_pmu;
 
 	switch (boot_cpu_data.x86) {
Signature · 1 line
1.6.3.2
Quoted 2 lines

What the heck is going on here?

hmm, I am really surprise how I wrote Signed-off-by line correct, I was really very upset at that time, and you know the reason, Please help me ;-)

Thanks,
--
JSR