Skip to contentSkip to conversation

x86: kvm/x86_emulate.c toggle_interruptibility() should be static

PATCH Applied Jaswinder Singh Rajput 2 participants 3 messages Jun 18, 2009 – Jun 21, 2009

Subsystems (3)
x86 KVM KVM x86
lore
Share & tools
lore

Jaswinder Singh Rajput

author
#0 lore raw

PATCH 1/1 x86: kvm/x86_emulate.c toggle_interruptibility() should be static

toggle_interruptibility() is used only by same file, it should be static.

Fixed following sparse warning :

arch/x86/kvm/x86_emulate.c:1364:6: warning: symbol 'toggle_interruptibility' was not declared. Should it be static?

Signed-off-by Jaswinder Singh Rajput <[email protected]>
---
 arch/x86/kvm/x86_emulate.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
arch/x86/kvm/x86_emulate.c +1 -1
index c1b6c23..616de46 100644
@@ -1361,7 +1361,7 @@ static inline int writeback(struct x86_emulate_ctxt *ctxt,
 	return 0;
 }
 
-void toggle_interruptibility(struct x86_emulate_ctxt *ctxt, u32 mask)
+static void toggle_interruptibility(struct x86_emulate_ctxt *ctxt, u32 mask)
 {
 	u32 int_shadow = kvm_x86_ops->get_interrupt_shadow(ctxt->vcpu, mask);
 	/*
Signature · 1 line
1.6.0.6
author
#1 lore raw

toggle_interruptibility() is used only by same file, it should be static.

Fixed following sparse warning :

arch/x86/kvm/x86_emulate.c:1364:6: warning: symbol 'toggle_interruptibility' was not declared. Should it be static?

Signed-off-by Jaswinder Singh Rajput <[email protected]>
---
 arch/x86/kvm/x86_emulate.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
arch/x86/kvm/x86_emulate.c +1 -1
index c1b6c23..616de46 100644
@@ -1361,7 +1361,7 @@ static inline int writeback(struct x86_emulate_ctxt *ctxt,
 	return 0;
 }
 
-void toggle_interruptibility(struct x86_emulate_ctxt *ctxt, u32 mask)
+static void toggle_interruptibility(struct x86_emulate_ctxt *ctxt, u32 mask)
 {
 	u32 int_shadow = kvm_x86_ops->get_interrupt_shadow(ctxt->vcpu, mask);
 	/*
Signature · 1 line
1.6.0.6
Applied
#2 lore raw
In reply to Jaswinder Singh Rajput
Quoted 6 lines · Jaswinder Singh Rajput

toggle_interruptibility() is used only by same file, it should be static.

Fixed following sparse warning :

arch/x86/kvm/x86_emulate.c:1364:6: warning: symbol 'toggle_interruptibility' was not declared. Should it be static?

Applied, thanks.

Signature · 1 line
error compiling committee.c: too many arguments to function