ath5k: fix beacon_int handling
PATCH 1/1 ath5k: fix beacon_int handling
73ca5203366235f8a43e490767284ba8cfd8c479
(ath5k: remove conf->beacon_int usage)
removed bintval setting from ath5k_config. We need to init the interval earlier and don't touch it in add_interface anymore.
Otherwise it will be set only once by upper layer through bss_info_changed but not on second and further hostap executions.
We ended up having bintval 1000 which rendered the AP useless on many clients.
--- drivers/net/wireless/ath/ath5k/base.c | 4 +--- 1 files changed, 1 insertions(+), 3 deletions(-)
drivers/net/wireless/ath/ath5k/base.c +1 -3
@@ -538,6 +538,7 @@ ath5k_pci_probe(struct pci_dev *pdev, sc->iobase = mem;/* So we can unmap it on detach */ sc->cachelsz = csz *sizeof (u32);/* convert to bytes */ sc->opmode =NL80211_IFTYPE_STATION ; + sc->bintval =1000 ;mutex_init (&sc->lock);spin_lock_init (&sc->rxbuflock);spin_lock_init (&sc->txbuflock);
@@ -2748,9 +2749,6 @@ static int ath5k_add_interface(struct ieee80211_hw *hw, goto end; } -/* Set to a reasonable value. Note that this will -* be set to mac80211's value at ath5k_config(). */ - sc->bintval =1000 ;ath5k_hw_set_lladdr (sc->ah, conf->mac_addr); ret =0 ;
Signature · 1 line
1.6.3.2
Quoted 7 lines · Jiri Slaby
73ca5203366235f8a43e490767284ba8cfd8c479
(ath5k: removeconf->beacon_intusage)
removed bintval setting fromath5k_config. We need to init the interval earlier and don't touch it inadd_interfaceanymore.Otherwise it will be set only once by upper layer through
bss_info_changedbut not on second and further hostap executions.
Shouldn't we just not destroy the value in add_interface?
I thought conf->beacon_int was deprecated.
Signature · 1 line
Bob Copeland %% www.bobcopeland.com
Quoted 4 lines · Bob Copeland
Quoted 2 lines
Otherwise it will be set only once by upper layer through
bss_info_changedbut not on second and further hostap executions.Shouldn't we just not destroy the value in
add_interface?
Err, nevermind, that's exactly what your patch does.
Signature · 1 line
Bob Copeland %% www.bobcopeland.com