Skip to contentSkip to conversation

fusion: mptsas, fix lock imbalance

PATCH In review Jiri Slaby 2 participants 2 messages Jun 21, 2009 – Jun 22, 2009

Subsystems (2)
lore
Share & tools
lore

Jiri Slaby

author
#0 lore raw

PATCH 1/1 fusion: mptsas, fix lock imbalance

Fix two typos in mptsas_not_responding_devices. It was mutex_lock instead of unlock.

---
 drivers/message/fusion/mptsas.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
drivers/message/fusion/mptsas.c +2 -2
index 20e0b44..55ff252 100644
@@ -3518,7 +3518,7 @@ retry_page:
 		} else
 			mptsas_volume_delete(ioc, sas_info->fw.id);
 	}
-	mutex_lock(&ioc->sas_device_info_mutex);
+	mutex_unlock(&ioc->sas_device_info_mutex);
 
 	/* expanders */
 	mutex_lock(&ioc->sas_topology_mutex);
@@ -3549,7 +3549,7 @@ retry_page:
 			goto redo_expander_scan;
 		}
 	}
-	mutex_lock(&ioc->sas_topology_mutex);
+	mutex_unlock(&ioc->sas_topology_mutex);
 }
 
 /**
Signature · 1 line
1.6.3.2
#1 lore raw

Jiri,

Consider this as ACKED patch.

- Kashyap Desai

-----Original Message-----
From: Jiri Slaby [mailto:[email protected]]
Sent: Monday, June 22, 2009 3:29 AM
To: Moore, Eric
Cc: DL-MPT Fusion Linux; [email protected]; Support, Software; [email protected]; Jiri Slaby
Subject: [PATCH] fusion: mptsas, fix lock imbalance

Fix two typos in mptsas_not_responding_devices. It was mutex_lock instead of unlock.

---
 drivers/message/fusion/mptsas.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
drivers/message/fusion/mptsas.c +2 -2
index 20e0b44..55ff252 100644
@@ -3518,7 +3518,7 @@ retry_page:
 		} else
 			mptsas_volume_delete(ioc, sas_info->fw.id);
 	}
-	mutex_lock(&ioc->sas_device_info_mutex);
+	mutex_unlock(&ioc->sas_device_info_mutex);
 
 	/* expanders */
 	mutex_lock(&ioc->sas_topology_mutex);
@@ -3549,7 +3549,7 @@ retry_page:
 			goto redo_expander_scan;
 		}
 	}
-	mutex_lock(&ioc->sas_topology_mutex);
+	mutex_unlock(&ioc->sas_topology_mutex);
 }
 
 /**
Signature · 1 line
1.6.3.2