Skip to contentSkip to conversation

minor fixes for mvBL-M7 and use of common code

PATCH New André Schwarz 3 participants 7 messages Jun 22, 2009 – Jul 8, 2009

lore
Share & tools
lore
#0 lore raw

PATCH 3/3 minor fixes for mvBL-M7 and use of common code

MATRIX VISION GmbH, Talstra?e 16, DE-71570 Oppenweiler
Registergericht: Amtsgericht Stuttgart, HRB 271090
Gesch?ftsf?hrer: Gerhard Thullner, Werner Armingeon, Uwe Furtner, Hans-Joachim Reich -------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-rebased-mvBLM7-with-minor-fixes.patch
Type: text/x-patch
Size: 8370 bytes
Desc: not available
Url : http://lists.denx.de/pipermail/u-boot/attachments/20090622/b8ab5613/attachment.bin

#1 lore raw

PATCH 3/3 minor fixes for mvBL-M7 and use of common code

On Mon, 22 Jun 2009 15:50:29 +0200
Andr? Schwarz <[email protected]> wrote:

Hello Andr?,

Quoted 1 line

X-Mailer: Evolution 2.26.1

...

Quoted 1 line

[0001-rebased-mvBLM7-with-minor-fixes.patch text/x-patch (8.2KB)]

please use
Insert->Text File... (Alt-n x)
to insert the patch.

Review

Quoted 3 lines
(quoted diff) +0 -2
-#define _IO_BASE		0x00000000
-

the above is the reason for the below:

Applying: minor fixes for mvBL-M7 and use of common code
error: patch failed: include/configs/MVBLM7.h:193
error: include/configs/MVBLM7.h: patch does not apply Patch failed at 0001 minor fixes for mvBL-M7 and use of common code

...and because I have the "remove _IO_BASE and KSEG1ADDR from board configuration files" patch already applied, and probably justifiably so, since it arrived earlier to the list than your patch.

btw, I also get this at build time:

Configuring for MVBLM7 board...
mv_common.c: In function 'mv_load_fpga':
mv_common.c:93: warning: implicit declaration of function 'fpga_load'

So did you want 1-3/3 of these to bypass u-boot-mpc83xx and go straight to WD? I'm asking because there's overlap with the mpc5xxx maintainer (WD himself apparently) in this patchseries.

Kim

#2 lore raw

PATCH 3/3 minor fixes for mvBL-M7 and use of common code

Kim,

Quoted 7 lines · Kim Phillips

On Mon, 22 Jun 2009 15:50:29 +0200
Andr?? Schwarz <[email protected]> wrote:

Hello Andr??,

Quoted 1 line

X-Mailer: Evolution 2.26.1

Quoted 7 lines

...

Quoted 1 line

[0001-rebased-mvBLM7-with-minor-fixes.patch text/x-patch (8.2KB)]

please use
Insert->Text File... (Alt-n x)
to insert the patch.

sorry - has been my first patch sent with evolution.

Quoted 6 lines

Review

Quoted 4 lines
(quoted diff) +0 -2
-#define _IO_BASE		0x00000000
-

the above is the reason for the below:

ok - understood. Didn't expect your patch being applied that quickly, i.e. obviously missed all ACK's.

Quoted 12 lines

Applying: minor fixes for mvBL-M7 and use of common code
error: patch failed: include/configs/MVBLM7.h:193
error: include/configs/MVBLM7.h: patch does not apply Patch failed at 0001 minor fixes for mvBL-M7 and use of common code

...and because I have the "remove _IO_BASE and KSEG1ADDR from board configuration files" patch already applied, and probably justifiably so, since it arrived earlier to the list than your patch.

btw, I also get this at build time:

Quoted 7 lines

Configuring for MVBLM7 board...
mv_common.c: In function 'mv_load_fpga':
mv_common.c:93: warning: implicit declaration of function 'fpga_load'

So did you want 1-3/3 of these to bypass u-boot-mpc83xx and go straight to WD? I'm asking because there's overlap with the mpc5xxx maintainer (WD himself apparently) in this patchseries.

Will wait for all replies. As far as I know WD is on vacation, i.e. this is going to take some time.
I'm in no hurry - if it's ok for you I'll fix all remaining issues with a single rebase/resend.

Cheers,
Andr??

Quoted 2 lines

Kim

MATRIX VISION GmbH, Talstra?e 16, DE-71570 Oppenweiler
Registergericht: Amtsgericht Stuttgart, HRB 271090
Gesch?ftsf?hrer: Gerhard Thullner, Werner Armingeon, Uwe Furtner, Hans-Joachim Reich

#3 lore raw

PATCH 3/3 minor fixes for mvBL-M7 and use of common code

Quoted 7 lines · On Wed, 24 Jun 2009 16:19:06 +0200 Andr? Schwarz…
Quoted 4 lines

Review

Quoted 2 lines
(quoted diff) +0 -2
-#define _IO_BASE		0x00000000
-

the above is the reason for the below:

ok - understood. Didn't expect your patch being applied that quickly, i.e. obviously missed all ACK's.

WD hasn't applied it yet - I applied it to my local tree. None of this means your patch should touch the same line and thus cause unnecessary conflicts.

Quoted 8 lines
Quoted 3 lines

So did you want 1-3/3 of these to bypass u-boot-mpc83xx and go straight to WD? I'm asking because there's overlap with the mpc5xxx maintainer (WD himself apparently) in this patchseries.

Will wait for all replies. As far as I know WD is on vacation, i.e. this is going to take some time.
I'm in no hurry - if it's ok for you I'll fix all remaining issues with a single rebase/resend.

sure, go ahead - I guess we have to wait for WD to pick them up. I'll try and ack them before he gets back.

Kim

#4 lore raw

PATCH 3/3 minor fixes for mvBL-M7 and use of common code

Dear Kim Phillips,

Quoted 4 lines · In message <[email protected]> you wrote:

WD hasn't applied it yet - I applied it to my local tree. None of this means your patch should touch the same line and thus cause unnecessary conflicts.

...

Quoted 2 lines

sure, go ahead - I guess we have to wait for WD to pick them up. I'll try and ack them before he gets back.

I'm pretty sure that I lost track of what you are talking here. So if ther eis anything you expect me to do please tell me (ideally in short and easy sentences :-)

Best regards,

Wolfgang Denk

Signature · 6 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
This all sounds complicated, but it mostly does excatly what you  ex-
pect. It's just difficult for us to explain what you expect...
                       - L. Wall & R. L. Schwartz, _Programming Perl_
#5 lore raw

PATCH 3/3 minor fixes for mvBL-M7 and use of common code

Quoted 7 lines · On Tue, 07 Jul 2009 21:04:43 +0200 Wolfgang Denk <[email protected]> wrote:

Dear Kim Phillips,

Quoted 4 lines · In message <[email protected]> you wrote:

WD hasn't applied it yet - I applied it to my local tree. None of this means your patch should touch the same line and thus cause unnecessary conflicts.

Quoted 7 lines

...

Quoted 2 lines

sure, go ahead - I guess we have to wait for WD to pick them up. I'll try and ack them before he gets back.

I'm pretty sure that I lost track of what you are talking here. So if ther eis anything you expect me to do please tell me (ideally in short and easy sentences :-)

no, there isn't, WD. Glad you're back, though.

Andr?, feel free to re-send your patchseries to WD now.

Thanks both,

Kim

#6 lore raw

PATCH 3/3 minor fixes for mvBL-M7 and use of common code

Quoted 17 lines · Kim Phillips
Quoted 13 lines · On Tue, 07 Jul 2009 21:04:43 +0200 Wolfgang Denk <[email protected]> wrote:

Dear Kim Phillips,

Quoted 4 lines · In message <[email protected]> you wrote:

WD hasn't applied it yet - I applied it to my local tree. None of this means your patch should touch the same line and thus cause unnecessary conflicts.

...

Quoted 3 lines

sure, go ahead - I guess we have to wait for WD to pick them up. I'll try and ack them before he gets back.

Quoted 9 lines
Quoted 4 lines

I'm pretty sure that I lost track of what you are talking here. So if ther eis anything you expect me to do please tell me (ideally in short and easy sentences :-)

no, there isn't, WD. Glad you're back, though.

Andr?, feel free to re-send your patchseries to WD now.

thanks - need to wait for other patches (e.g. Heiko) and rebase.

Quoted 4 lines

Thanks both,

Kim

MATRIX VISION GmbH, Talstra?e 16, DE-71570 Oppenweiler
Registergericht: Amtsgericht Stuttgart, HRB 271090
Gesch?ftsf?hrer: Gerhard Thullner, Werner Armingeon, Uwe Furtner, Hans-Joachim Reich