zalon: fix oops on attach failure
James Bottomley
maintainerPATCH 1/1 zalon: fix oops on attach failure
I recently discovered on my zalon that if the attachment fails because of a bus misconfiguration (I scrapped my HVD array, so the card is now unterminated) then the system oopses. The reason is that if ncr_attach() returns NULL (signalling failure) that NULL is passed by the goto failed straight into ncr_detach() which oopses.
The fix is just to return -ENODEV in this case.
James
---
drivers/scsi/zalon.c +1 -1
@@ -134,7 +134,7 @@ zalon_probe(struct parisc_device *dev) host =ncr_attach (&zalon7xx_template, unit, &device);if (!host) - goto fail; +return -ENODEV ;if (request_irq (dev->irq, ncr53c8xx_intr,IRQF_SHARED ,"zalon" , host)) { dev_printk(KERN_ERR, &dev->dev, "irq problem with %d, detaching\n ",