Skip to contentSkip to conversation

LED: Reply-To: use correct name for /sys/devices/virtual/leds/ entries

PATCH In review Greg KH 2 participants 5 messages Jun 24, 2009 – Jun 26, 2009

Subsystems (2)
lore
Share & tools
lore

Greg KH

author
#0 lore raw

PATCH 1/1 LED: Reply-To: use correct name for /sys/devices/virtual/leds/ entries

From: Olaf Hering <[email protected]>

This is needed to get kde-powersave to work properly on some g4 powerbooks.

From: Olaf Hering <[email protected]>

---
This has been shipping in the SuSE kernels for a while. I do not know why it was not sent to you previously, sorry - gregkh

 drivers/leds/leds-cobalt-qube.c   |    2 +-
 drivers/leds/leds-cobalt-raq.c    |    4 ++--
 drivers/leds/ledtrig-default-on.c |    2 +-
 drivers/macintosh/via-pmu-led.c   |    2 +-
 4 files changed, 5 insertions(+), 5 deletions(-)
drivers/leds/leds-cobalt-qube.c +1 -1
@@ -28,7 +28,7 @@ static void qube_front_led_set(struct le
 }
 
 static struct led_classdev qube_front_led = {
-	.name			= "qube-front",
+	.name			= "qube::front",
 	.brightness		= LED_FULL,
 	.brightness_set		= qube_front_led_set,
 	.default_trigger	= "ide-disk",
drivers/leds/leds-cobalt-raq.c +2 -2
@@ -49,7 +49,7 @@ static void raq_web_led_set(struct led_c
 }
 
 static struct led_classdev raq_web_led = {
-	.name		= "raq-web",
+	.name		= "raq::web",
 	.brightness_set	= raq_web_led_set,
 };
 
@@ -70,7 +70,7 @@ static void raq_power_off_led_set(struct
 }
 
 static struct led_classdev raq_power_off_led = {
-	.name			= "raq-power-off",
+	.name			= "raq::power-off",
 	.brightness_set		= raq_power_off_led_set,
 	.default_trigger	= "power-off",
 };
drivers/leds/ledtrig-default-on.c +1 -1
@@ -23,7 +23,7 @@ static void defon_trig_activate(struct l
 }
 
 static struct led_trigger defon_led_trigger = {
-	.name     = "default-on",
+	.name     = "default::on",
 	.activate = defon_trig_activate,
 };
 
drivers/macintosh/via-pmu-led.c +1 -1
@@ -72,7 +72,7 @@ static void pmu_led_set(struct led_class
 }
 
 static struct led_classdev pmu_led = {
-	.name = "pmu-front-led",
+	.name = "pmu-led::front",
 #ifdef CONFIG_ADB_PMU_LED_IDE
 	.default_trigger = "ide-disk",
 #endif
#1 lore raw
Quoted 7 lines · Greg KH

From: Olaf Hering <[email protected]>

This is needed to get kde-powersave to work properly on some g4 powerbooks.

From: Olaf Hering <[email protected]>

I'm ok with this apart from:

drivers/leds/ledtrig-default-on.c static void defon_trig_activate(struct l · line 28

Quoted 10 lines
drivers/leds/ledtrig-default-on.c +1 -1
@@ -23,7 +23,7 @@ static void defon_trig_activate(struct l
 }
 
 static struct led_trigger defon_led_trigger = {
-	.name     = "default-on",
+	.name     = "default::on",
 	.activate = defon_trig_activate,
 };

which doesn't seem to match the patch description. Why does the trigger name need to be changed?

Cheers,

Richard

Signature · 2 lines
Richard Purdie
Intel Open Source Technology Centre
author
#2 lore raw
Quoted 16 lines · Richard Purdie
Quoted 7 lines · Greg KH

From: Olaf Hering <[email protected]>

This is needed to get kde-powersave to work properly on some g4 powerbooks.

From: Olaf Hering <[email protected]>

I'm ok with this apart from:

Quoted 5 lines
drivers/leds/ledtrig-default-on.c +0 -0
@@ -23,7 +23,7 @@ static void defon_trig_activate(struct l
 }
 
Quoted 8 lines

drivers/leds/ledtrig-default-on.c static void defon_trig_activate(struct l · line 28

Quoted 5 lines
drivers/leds/ledtrig-default-on.c +1 -1
 static struct led_trigger defon_led_trigger = {
-	.name     = "default-on",
+	.name     = "default::on",
 	.activate = defon_trig_activate,
 };

which doesn't seem to match the patch description. Why does the trigger name need to be changed?

I really don't know, I took this patch from the suse tree, and Olaf is gone and I can't ask him :(

If you don't think it is needed/correct, please drop that part. Or I can redo it without it.

thanks,

greg k-h

#3 lore raw
Quoted 26 lines · Greg KH
Quoted 16 lines · Richard Purdie
Quoted 7 lines · Greg KH

From: Olaf Hering <[email protected]>

This is needed to get kde-powersave to work properly on some g4 powerbooks.

From: Olaf Hering <[email protected]>

I'm ok with this apart from:

Quoted 5 lines
drivers/leds/ledtrig-default-on.c +0 -0
@@ -23,7 +23,7 @@ static void defon_trig_activate(struct l
 }
 
Quoted 8 lines

drivers/leds/ledtrig-default-on.c static void defon_trig_activate(struct l · line 28

Quoted 5 lines
drivers/leds/ledtrig-default-on.c +1 -1
 static struct led_trigger defon_led_trigger = {
-	.name     = "default-on",
+	.name     = "default::on",
 	.activate = defon_trig_activate,
 };

which doesn't seem to match the patch description. Why does the trigger name need to be changed?

Quoted 5 lines

I really don't know, I took this patch from the suse tree, and Olaf is gone and I can't ask him :(

If you don't think it is needed/correct, please drop that part. Or I can redo it without it.

I'll just drop that bit. As far as I can see it would just break any users of that trigger for no good reason...

Cheers,

Richard

Signature · 2 lines
Richard Purdie
Intel Open Source Technology Centre
author
#4 lore raw
Quoted 27 lines · Richard Purdie
Quoted 26 lines · Greg KH
Quoted 24 lines · Richard Purdie
Quoted 7 lines · Greg KH

From: Olaf Hering <[email protected]>

This is needed to get kde-powersave to work properly on some g4 powerbooks.

From: Olaf Hering <[email protected]>

I'm ok with this apart from:

drivers/leds/ledtrig-default-on.c static void defon_trig_activate(struct l · line 28

Quoted 10 lines
drivers/leds/ledtrig-default-on.c +1 -1
@@ -23,7 +23,7 @@ static void defon_trig_activate(struct l
 }
 
 static struct led_trigger defon_led_trigger = {
-	.name     = "default-on",
+	.name     = "default::on",
 	.activate = defon_trig_activate,
 };

which doesn't seem to match the patch description. Why does the trigger name need to be changed?

Quoted 8 lines
Quoted 5 lines

I really don't know, I took this patch from the suse tree, and Olaf is gone and I can't ask him :(

If you don't think it is needed/correct, please drop that part. Or I can redo it without it.

I'll just drop that bit. As far as I can see it would just break any users of that trigger for no good reason...

Thanks for dropping it, I'll go change the suse patch as well.

thanks,

greg k-h