Skip to contentSkip to conversation

headers_check fix: linux/pps.h

PATCH In review Jaswinder Singh Rajput 2 participants 4 messages Jun 27, 2009 – Jun 28, 2009 PPS support

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 headers_check fix: linux/pps.h

fix the following 'make headers_check' warnings:

usr/include/linux/pps.h:52: found __[us]{8,16,32,64} type without #include <linux/types.h>

---
 include/linux/pps.h |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
include/linux/pps.h +2 -0
index cfe5c72..0194ab0 100644
@@ -22,6 +22,8 @@
 #ifndef _PPS_H_
 #define _PPS_H_
 
+#include <linux/types.h>
+
 #define PPS_VERSION		"5.3.6"
 #define PPS_MAX_SOURCES		16		/* should be enough... */
 
Signature · 1 line
1.6.0.6
#1 lore raw
Quoted 15 lines · Jaswinder Singh Rajput

fix the following 'make headers_check' warnings:

usr/include/linux/pps.h:52: found __[us]{8,16,32,64} type without #include <linux/types.h>

---
 include/linux/pps.h |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
include/linux/pps.h +0 -0
index cfe5c72..0194ab0 100644

include/linux/pps.h line 28

Quoted 7 lines
include/linux/pps.h +2 -0
@@ -22,6 +22,8 @@
 #ifndef _PPS_H_
 #define _PPS_H_
 
+#include <linux/types.h>
+
 #define PPS_VERSION		"5.3.6"
 #define PPS_MAX_SOURCES		16		/* should be enough... */

That file has other issues that should be addresses too.
1) It uses int rather than wide specific types
2) It uses structs with questionable alignmner as per David's comment

Keeping the warning until all issues are sorted out is preferred. If we 'fix' the warning then we loose the reminder that this file needs to be eyeballed.

This is not a quest to eliminate warnings - this is a quest to raise the quality and correctness of the exported headers. The warnings serves as reminders where to focus attention.

Sam

#2 lore raw
Quoted 19 lines · Sam Ravnborg
Quoted 18 lines · Jaswinder Singh Rajput

fix the following 'make headers_check' warnings:

usr/include/linux/pps.h:52: found __[us]{8,16,32,64} type without #include <linux/types.h>

---
 include/linux/pps.h |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
include/linux/pps.h +0 -0
index cfe5c72..0194ab0 100644
@@ -22,6 +22,8 @@
 #ifndef _PPS_H_
 #define _PPS_H_
 
Quoted 9 lines

include/linux/pps.h line 28

Quoted 4 lines
include/linux/pps.h +2 -0
+#include <linux/types.h>
+
 #define PPS_VERSION		"5.3.6"
 #define PPS_MAX_SOURCES		16		/* should be enough... */

That file has other issues that should be addresses too.
1) It uses int rather than wide specific types
2) It uses structs with questionable alignmner as per David's comment

This should be send in different patch.

Quoted 4 lines

Keeping the warning until all issues are sorted out is preferred. If we 'fix' the warning then we loose the reminder that this file needs to be eyeballed.

You mean files which do not get headers_check warning are absolutely OK. This is totally insane.

This are different issues and need to send by different series of patches. Please do not mix up things.

Quoted 4 lines

This is not a quest to eliminate warnings - this is a quest to raise the quality and correctness of the exported headers. The warnings serves as reminders where to focus attention.

ditto.

--
JSR

#3 lore raw
Quoted 37 lines · Jaswinder Singh Rajput
Quoted 19 lines · Sam Ravnborg
Quoted 18 lines · Jaswinder Singh Rajput

fix the following 'make headers_check' warnings:

usr/include/linux/pps.h:52: found __[us]{8,16,32,64} type without #include <linux/types.h>

---
 include/linux/pps.h |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
include/linux/pps.h +0 -0
index cfe5c72..0194ab0 100644
@@ -22,6 +22,8 @@
 #ifndef _PPS_H_
 #define _PPS_H_
 
Quoted 9 lines

include/linux/pps.h line 28

Quoted 4 lines
include/linux/pps.h +2 -0
+#include <linux/types.h>
+
 #define PPS_VERSION		"5.3.6"
 #define PPS_MAX_SOURCES		16		/* should be enough... */

That file has other issues that should be addresses too.
1) It uses int rather than wide specific types
2) It uses structs with questionable alignmner as per David's comment

This should be send in different patch.

Quoted 4 lines

Keeping the warning until all issues are sorted out is preferred. If we 'fix' the warning then we loose the reminder that this file needs to be eyeballed.

Quoted 5 lines

You mean files which do not get headers_check warning are absolutely OK. This is totally insane.

This are different issues and need to send by different series of patches. Please do not mix up things.

If others maintainers will be like you they will never get any patch. If they keep on saying go and fix complete source file first.

Do you get some idea, what are you requesting for.

If you find the problem why do not you submit patches ?

Thanks,
--
JSR