Skip to contentSkip to conversation

KVM: fix lock imbalance

PATCH Applied Jiri Slaby 2 participants 2 messages Jun 29, 2009 – Jul 1, 2009 KVM

lore
Share & tools
lore

Jiri Slaby

author
#0 lore raw

PATCH 1/1 KVM: fix lock imbalance

There is a missing unlock on one fail path in ioapic_mmio_write, fix that.

---
 virt/kvm/ioapic.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
virt/kvm/ioapic.c +2 -1
index d8b2eca..2b3307b 100644
@@ -290,7 +290,7 @@ static void ioapic_mmio_write(struct kvm_io_device *this, gpa_t addr, int len,
 		data = *(u32 *) val;
 	else {
 		printk(KERN_WARNING "ioapic: Unsupported size %d\n", len);
-		return;
+		goto unlock;
 	}
 
 	addr &= 0xff;
@@ -311,6 +311,7 @@ static void ioapic_mmio_write(struct kvm_io_device *this, gpa_t addr, int len,
 	default:
 		break;
 	}
+unlock:
 	mutex_unlock(&ioapic->kvm->irq_lock);
 }
 
Signature · 1 line
1.6.3.2
Applied
#1 lore raw
Quoted 3 lines · Jiri Slaby

There is a missing unlock on one fail path in ioapic_mmio_write, fix that.

Applied, thanks.

Signature · 1 line
error compiling committee.c: too many arguments to function