Skip to contentSkip to conversation

x86: ptrace.c ptrace_get_debugreg() should be static

PATCH RESEND In review Jaswinder Singh Rajput 1 participant 2 messages Jul 1, 2009

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH RESEND 1/1 x86: ptrace.c ptrace_get_debugreg() should be static

ptrace_get_debugreg() is used only by the same file, so it should be static.

Also fixed sparse warning :

CHECK arch/x86/kernel/ptrace.c
arch/x86/kernel/ptrace.c:560:15: warning: symbol 'ptrace_get_debugreg' was not declared. Should it be static?

---
 arch/x86/kernel/ptrace.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
arch/x86/kernel/ptrace.c +1 -1
index b457f78..cabdabc 100644
@@ -557,7 +557,7 @@ restore:
 /*
  * Handle PTRACE_PEEKUSR calls for the debug register area.
  */
-unsigned long ptrace_get_debugreg(struct task_struct *tsk, int n)
+static unsigned long ptrace_get_debugreg(struct task_struct *tsk, int n)
 {
 	struct thread_struct *thread = &(tsk->thread);
 	unsigned long val = 0;
Signature · 1 line
1.6.0.6
#1 lore raw
Quoted 9 lines · Jaswinder Singh Rajput

ptrace_get_debugreg() is used only by the same file, so it should be static.

Also fixed sparse warning :

CHECK arch/x86/kernel/ptrace.c
arch/x86/kernel/ptrace.c:560:15: warning: symbol 'ptrace_get_debugreg' was not declared. Should it be static?

---

Please apply this :

[PATCH] x86: ptrace ptrace_get_debugreg() should be static

This sparse warning:

arch/x86/kernel/ptrace.c:560:15: warning: symbol 'ptrace_get_debugreg' was not declared. Should it be static?

triggers because ptrace_get_debugreg() is global but is only used in a single .c file. change ptrace_get_debugreg() to static to fix that - this also address the sparse warning.

---
 arch/x86/kernel/ptrace.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
arch/x86/kernel/ptrace.c +1 -1
index b457f78..cabdabc 100644
@@ -557,7 +557,7 @@ restore:
 /*
  * Handle PTRACE_PEEKUSR calls for the debug register area.
  */
-unsigned long ptrace_get_debugreg(struct task_struct *tsk, int n)
+static unsigned long ptrace_get_debugreg(struct task_struct *tsk, int n)
 {
 	struct thread_struct *thread = &(tsk->thread);
 	unsigned long val = 0;
Signature · 1 line
1.6.0.6