Skip to contentSkip to conversation

includecheck: fix multiple includes

PATCH In review Jaswinder Singh Rajput 23 participants 90 messages Jul 8, 2009 – Jul 24, 2009

Subsystems (43)
lore
Share & tools
lore
#0 lore raw

cover includecheck: fix multiple includes

The following changes since commit faf80d62e44dc627efb741f48db50c1858d1667c:
Linus Torvalds (1):

        Merge branch 'x86-fixes-for-linus' of git://git.kernel.org/.../tip/linux-2.6-tip

are available in the git repository at:

git://git.kernel.org/pub/scm/linux/kernel/git/jaswinder/headers-check-2.6.git master

Jaswinder Singh Rajput (44):
includecheck fix: arm, misc.c
includecheck fix: arm, atomic.h
includecheck fix: arm, board-dm355-evm.c includecheck fix: arm, board-dm355-leopard.c includecheck fix: arm, board-dm644x-evm.c includecheck fix: arm, board-dm646x-evm.c includecheck fix: arm, board-sffsdr.c includecheck fix: arm, mach-mx3/devices.c includecheck fix: arm, mach-omap1/mcbsp.c includecheck fix: arm, mach-omap2/mcbsp.c includecheck fix: arm, plat-s3c64xx/pm.c includecheck fix: arm, plat-stmp3xxx/pinmux.c includecheck fix: mn10300, sys_mn10300.c includecheck fix: powerpc, mpc7450-pmu.c includecheck fix: powerpc, ppc970-pmu.c includecheck fix: s390, sys_s390.c includecheck fix: um, helper.c
includecheck fix: x86, dumpstack.c includecheck fix: x86, traps.c
includecheck fix: x86, shadow.c
includecheck fix: Documentation, cfag12864b-example.c includecheck fix: drivers/char, vt.c includecheck fix: drivers/net, sja1000.c includecheck fix: drivers/net, axnet_cs.c includecheck fix: drivers/net, smc911x.h includecheck fix: drivers/parisc, ccio-dma.c includecheck fix: drivers/scsi, libfcoe.c includecheck fix: drivers/scsi, ibmvscsi.c includecheck fix: drivers/spi, amba-pl022.c includecheck fix: drivers/staging, usbdrv.c includecheck fix: drivers/staging, rt_linux.h includecheck fix: drivers/video, vgacon.c includecheck fix: drivers/xen, evtchn.c includecheck fix: fs/xfs, xfs_iops.c includecheck fix: include/acpi, acpi_bus.h includecheck fix: include/drm, drm_memory.h includecheck fix: include/linux, aio.h includecheck fix: include/linux, ftrace.h includecheck fix: include/linux, icmpv6.h includecheck fix: include/linux, net_dropmon.h includecheck fix: include/linux, rfkill.h includecheck fix: kernel/trace, ring_buffer.c includecheck fix: mm, nommu.c
includecheck fix: mm, shmem.c

 Documentation/auxdisplay/cfag12864b-example.c |    1 -
 arch/arm/boot/compressed/misc.c               |    1 -
 arch/arm/include/asm/atomic.h                 |    2 --
 arch/arm/mach-davinci/board-dm355-evm.c       |    1 -
 arch/arm/mach-davinci/board-dm355-leopard.c   |    1 -
 arch/arm/mach-davinci/board-dm644x-evm.c      |    1 -
 arch/arm/mach-davinci/board-dm646x-evm.c      |    1 -
 arch/arm/mach-davinci/board-sffsdr.c          |    1 -
 arch/arm/mach-mx3/devices.c                   |    1 -
 arch/arm/mach-omap1/mcbsp.c                   |    1 -
 arch/arm/mach-omap2/mcbsp.c                   |    1 -
 arch/arm/plat-s3c64xx/pm.c                    |    2 --
 arch/arm/plat-stmp3xxx/pinmux.c               |    1 -
 arch/mn10300/kernel/sys_mn10300.c             |    1 -
 arch/powerpc/kernel/mpc7450-pmu.c             |    1 -
 arch/powerpc/kernel/ppc970-pmu.c              |    1 -
 arch/s390/kernel/sys_s390.c                   |    1 -
 arch/um/os-Linux/helper.c                     |    1 -
 arch/x86/kernel/dumpstack.c                   |    1 -
 arch/x86/kernel/traps.c                       |    1 -
 arch/x86/mm/kmemcheck/shadow.c                |    1 -
 drivers/char/vt.c                             |    1 -
 drivers/net/can/sja1000/sja1000.c             |    1 -
 drivers/net/pcmcia/axnet_cs.c                 |    2 --
 drivers/net/smc911x.h                         |    1 -
 drivers/parisc/ccio-dma.c                     |    1 -
 drivers/scsi/fcoe/libfcoe.c                   |    1 -
 drivers/scsi/ibmvscsi/ibmvscsi.c              |    1 -
 drivers/spi/amba-pl022.c                      |    2 --
 drivers/staging/otus/usbdrv.c                 |    3 ---
 drivers/staging/rt2860/rt_linux.h             |    4 ----
 drivers/video/console/vgacon.c                |    1 -
 drivers/xen/evtchn.c                          |    1 -
 fs/xfs/linux-2.6/xfs_iops.c                   |    1 -
 include/acpi/acpi_bus.h                       |    1 -
 include/drm/drm_memory.h                      |    2 --
 include/linux/aio.h                           |    2 --
 include/linux/ftrace.h                        |    1 -
 include/linux/icmpv6.h                        |    2 --
 include/linux/net_dropmon.h                   |    1 -
 include/linux/rfkill.h                        |    1 -
 kernel/trace/ring_buffer.c                    |    2 --
 mm/nommu.c                                    |    2 --
 mm/shmem.c                                    |    1 -
 44 files changed, 0 insertions(+), 58 deletions(-)
#1 lore raw

PATCH 1/44 includecheck fix: arm, misc.c

fix the following 'make includecheck' warning:

arch/arm/boot/compressed/misc.c: linux/compiler.h is included more than once.

---
 arch/arm/boot/compressed/misc.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
arch/arm/boot/compressed/misc.c +0 -1
index 9e6e512..17153b5 100644
@@ -29,7 +29,6 @@ unsigned int __machine_arch_type;
 
 static void putstr(const char *ptr);
 
-#include <linux/compiler.h>
 #include <mach/uncompress.h>
 
 #ifdef CONFIG_DEBUG_ICEDCC
Signature · 1 line
1.6.0.6
#2 lore raw

PATCH 2/44 includecheck fix: arm, atomic.h

In reply to Jaswinder Singh Rajput

fix the following 'make includecheck' warning:

arch/arm/include/asm/atomic.h: asm/system.h is included more than once.

---
 arch/arm/include/asm/atomic.h |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)
arch/arm/include/asm/atomic.h +0 -2
index 9e07fe5..9ed2377 100644
@@ -159,8 +159,6 @@ static inline void atomic_clear_mask(unsigned long mask, unsigned long *addr)
 
 #else /* ARM_ARCH_6 */
 
-#include <asm/system.h>
-
 #ifdef CONFIG_SMP
 #error SMP not supported on pre-ARMv6 CPUs
 #endif
Signature · 1 line
1.6.0.6
#3 lore raw

PATCH 3/44 includecheck fix: arm, board-dm355-evm.c

In reply to Jaswinder Singh Rajput

fix the following 'make includecheck' warning:

arch/arm/mach-davinci/board-dm355-evm.c: mach/common.h is included more than once.

---
 arch/arm/mach-davinci/board-dm355-evm.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
arch/arm/mach-davinci/board-dm355-evm.c +0 -1
index 5ac2f56..d6ab64c 100644
@@ -37,7 +37,6 @@
 #include <mach/serial.h>
 #include <mach/nand.h>
 #include <mach/mmc.h>
-#include <mach/common.h>
 
 #define DAVINCI_ASYNC_EMIF_CONTROL_BASE		0x01e10000
 #define DAVINCI_ASYNC_EMIF_DATA_CE0_BASE	0x02000000
Signature · 1 line
1.6.0.6
Acked-by on v1 3/44
#4 lore raw

Re: [PATCH 3/44] includecheck fix: arm, board-dm355-evm.c

Quoted 5 lines · Jaswinder Singh Rajput

fix the following 'make includecheck' warning:

arch/arm/mach-davinci/board-dm355-evm.c: mach/common.h is included more than once.

Quoted 18 lines
---
 arch/arm/mach-davinci/board-dm355-evm.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
arch/arm/mach-davinci/board-dm355-evm.c +0 -1
index 5ac2f56..d6ab64c 100644
@@ -37,7 +37,6 @@
 #include <mach/serial.h>
 #include <mach/nand.h>
 #include <mach/mmc.h>
-#include <mach/common.h>
 
 #define DAVINCI_ASYNC_EMIF_CONTROL_BASE		0x01e10000
 #define DAVINCI_ASYNC_EMIF_DATA_CE0_BASE	0x02000000
Signature · 1 line
1.6.0.6
#5 lore raw

PATCH 4/44 includecheck fix: arm, board-dm355-leopard.c

In reply to Jaswinder Singh Rajput

fix the following 'make includecheck' warning:

arch/arm/mach-davinci/board-dm355-leopard.c: mach/common.h is included more than once.

---
 arch/arm/mach-davinci/board-dm355-leopard.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
arch/arm/mach-davinci/board-dm355-leopard.c +0 -1
index 28c9008..84ad5d1 100644
@@ -36,7 +36,6 @@
 #include <mach/serial.h>
 #include <mach/nand.h>
 #include <mach/mmc.h>
-#include <mach/common.h>
 
 #define DAVINCI_ASYNC_EMIF_CONTROL_BASE		0x01e10000
 #define DAVINCI_ASYNC_EMIF_DATA_CE0_BASE	0x02000000
Signature · 1 line
1.6.0.6
Acked-by on v1 4/44
#6 lore raw

Re: [PATCH 4/44] includecheck fix: arm, board-dm355-leopard.c

Quoted 5 lines · Jaswinder Singh Rajput

fix the following 'make includecheck' warning:

arch/arm/mach-davinci/board-dm355-leopard.c: mach/common.h is included more than once.

Quoted 18 lines
---
 arch/arm/mach-davinci/board-dm355-leopard.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
arch/arm/mach-davinci/board-dm355-leopard.c +0 -1
index 28c9008..84ad5d1 100644
@@ -36,7 +36,6 @@
 #include <mach/serial.h>
 #include <mach/nand.h>
 #include <mach/mmc.h>
-#include <mach/common.h>
 
 #define DAVINCI_ASYNC_EMIF_CONTROL_BASE		0x01e10000
 #define DAVINCI_ASYNC_EMIF_DATA_CE0_BASE	0x02000000
Signature · 1 line
1.6.0.6
#7 lore raw

PATCH 5/44 includecheck fix: arm, board-dm644x-evm.c

In reply to Jaswinder Singh Rajput

fix the following 'make includecheck' warning:

arch/arm/mach-davinci/board-dm644x-evm.c: mach/common.h is included more than once.

---
 arch/arm/mach-davinci/board-dm644x-evm.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
arch/arm/mach-davinci/board-dm644x-evm.c +0 -1
index d9d4045..56c8cd0 100644
@@ -45,7 +45,6 @@
 #include <mach/nand.h>
 #include <mach/mmc.h>
 #include <mach/emac.h>
-#include <mach/common.h>
 
 #define DM644X_EVM_PHY_MASK		(0x2)
 #define DM644X_EVM_MDIO_FREQUENCY	(2200000) /* PHY bus frequency */
Signature · 1 line
1.6.0.6
Acked-by on v1 5/44
#8 lore raw

Re: [PATCH 5/44] includecheck fix: arm, board-dm644x-evm.c

Quoted 5 lines · Jaswinder Singh Rajput

fix the following 'make includecheck' warning:

arch/arm/mach-davinci/board-dm644x-evm.c: mach/common.h is included more than once.

Quoted 18 lines
---
 arch/arm/mach-davinci/board-dm644x-evm.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
arch/arm/mach-davinci/board-dm644x-evm.c +0 -1
index d9d4045..56c8cd0 100644
@@ -45,7 +45,6 @@
 #include <mach/nand.h>
 #include <mach/mmc.h>
 #include <mach/emac.h>
-#include <mach/common.h>
 
 #define DM644X_EVM_PHY_MASK		(0x2)
 #define DM644X_EVM_MDIO_FREQUENCY	(2200000) /* PHY bus frequency */
Signature · 1 line
1.6.0.6
#9 lore raw

PATCH 6/44 includecheck fix: arm, board-dm646x-evm.c

In reply to Jaswinder Singh Rajput

fix the following 'make includecheck' warning:

arch/arm/mach-davinci/board-dm646x-evm.c: mach/common.h is included more than once.

---
 arch/arm/mach-davinci/board-dm646x-evm.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
arch/arm/mach-davinci/board-dm646x-evm.c +0 -1
index e17de63..8657e72 100644
@@ -47,7 +47,6 @@
 #include <mach/i2c.h>
 #include <mach/mmc.h>
 #include <mach/emac.h>
-#include <mach/common.h>
 
 #define DM646X_EVM_PHY_MASK		(0x2)
 #define DM646X_EVM_MDIO_FREQUENCY	(2200000) /* PHY bus frequency */
Signature · 1 line
1.6.0.6
Acked-by on v1 6/44
#10 lore raw

Re: [PATCH 6/44] includecheck fix: arm, board-dm646x-evm.c

Quoted 5 lines · Jaswinder Singh Rajput

fix the following 'make includecheck' warning:

arch/arm/mach-davinci/board-dm646x-evm.c: mach/common.h is included more than once.

Quoted 18 lines
---
 arch/arm/mach-davinci/board-dm646x-evm.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
arch/arm/mach-davinci/board-dm646x-evm.c +0 -1
index e17de63..8657e72 100644
@@ -47,7 +47,6 @@
 #include <mach/i2c.h>
 #include <mach/mmc.h>
 #include <mach/emac.h>
-#include <mach/common.h>
 
 #define DM646X_EVM_PHY_MASK		(0x2)
 #define DM646X_EVM_MDIO_FREQUENCY	(2200000) /* PHY bus frequency */
Signature · 1 line
1.6.0.6
#11 lore raw

PATCH 7/44 includecheck fix: arm, board-sffsdr.c

In reply to Jaswinder Singh Rajput

fix the following 'make includecheck' warning:

arch/arm/mach-davinci/board-sffsdr.c: mach/common.h is included more than once.

---
 arch/arm/mach-davinci/board-sffsdr.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
arch/arm/mach-davinci/board-sffsdr.c +0 -1
index 748a8e4..7acdfd8 100644
@@ -52,7 +52,6 @@
 #include <mach/serial.h>
 #include <mach/psc.h>
 #include <mach/mux.h>
-#include <mach/common.h>
 
 #define SFFSDR_PHY_MASK		(0x2)
 #define SFFSDR_MDIO_FREQUENCY	(2200000) /* PHY bus frequency */
Signature · 1 line
1.6.0.6
Acked-by on v1 7/44
#12 lore raw

Re: [PATCH 7/44] includecheck fix: arm, board-sffsdr.c

Quoted 5 lines · Jaswinder Singh Rajput

fix the following 'make includecheck' warning:

arch/arm/mach-davinci/board-sffsdr.c: mach/common.h is included more than once.

Quoted 18 lines
---
 arch/arm/mach-davinci/board-sffsdr.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
arch/arm/mach-davinci/board-sffsdr.c +0 -1
index 748a8e4..7acdfd8 100644
@@ -52,7 +52,6 @@
 #include <mach/serial.h>
 #include <mach/psc.h>
 #include <mach/mux.h>
-#include <mach/common.h>
 
 #define SFFSDR_PHY_MASK		(0x2)
 #define SFFSDR_MDIO_FREQUENCY	(2200000) /* PHY bus frequency */
Signature · 1 line
1.6.0.6
#13 lore raw

PATCH 8/44 includecheck fix: arm, mach-mx3/devices.c

In reply to Jaswinder Singh Rajput

fix the following 'make includecheck' warning:

arch/arm/mach-mx3/devices.c: linux/dma-mapping.h is included more than once.

---
 arch/arm/mach-mx3/devices.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
arch/arm/mach-mx3/devices.c +0 -1
index d927edd..9e87e08 100644
@@ -22,7 +22,6 @@
 #include <linux/platform_device.h>
 #include <linux/serial.h>
 #include <linux/gpio.h>
-#include <linux/dma-mapping.h>
 #include <mach/hardware.h>
 #include <mach/irqs.h>
 #include <mach/common.h>
Signature · 1 line
1.6.0.6
#14 lore raw

PATCH 9/44 includecheck fix: arm, mach-omap1/mcbsp.c

In reply to Jaswinder Singh Rajput

fix the following 'make includecheck' warning:

arch/arm/mach-omap1/mcbsp.c: mach/irqs.h is included more than once.

---
 arch/arm/mach-omap1/mcbsp.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
arch/arm/mach-omap1/mcbsp.c +0 -1
index a2d7814..505d98c 100644
@@ -19,7 +19,6 @@
 
 #include <mach/irqs.h>
 #include <mach/dma.h>
-#include <mach/irqs.h>
 #include <mach/mux.h>
 #include <mach/cpu.h>
 #include <mach/mcbsp.h>
Signature · 1 line
1.6.0.6
Acked-by on v1 9/44
#15 lore raw

Re: [PATCH 9/44] includecheck fix: arm, mach-omap1/mcbsp.c

Quoted 5 lines · Jaswinder Singh Rajput

fix the following 'make includecheck' warning:

arch/arm/mach-omap1/mcbsp.c: mach/irqs.h is included more than once.

Tony's on vacation, so I'll ack these minor OMAP changes on his behalf.

Quoted 18 lines
---
 arch/arm/mach-omap1/mcbsp.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
arch/arm/mach-omap1/mcbsp.c +0 -1
index a2d7814..505d98c 100644
@@ -19,7 +19,6 @@
 
 #include <mach/irqs.h>
 #include <mach/dma.h>
-#include <mach/irqs.h>
 #include <mach/mux.h>
 #include <mach/cpu.h>
 #include <mach/mcbsp.h>
Signature · 1 line
1.6.0.6
#16 lore raw

PATCH 10/44 includecheck fix: arm, mach-omap2/mcbsp.c

In reply to Jaswinder Singh Rajput

fix the following 'make includecheck' warning:

arch/arm/mach-omap2/mcbsp.c: mach/irqs.h is included more than once.

---
 arch/arm/mach-omap2/mcbsp.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
arch/arm/mach-omap2/mcbsp.c +0 -1
index a5c0f04..99b6e15 100644
@@ -19,7 +19,6 @@
 
 #include <mach/irqs.h>
 #include <mach/dma.h>
-#include <mach/irqs.h>
 #include <mach/mux.h>
 #include <mach/cpu.h>
 #include <mach/mcbsp.h>
Signature · 1 line
1.6.0.6
Acked-by on v1 10/44
#17 lore raw

Re: [PATCH 10/44] includecheck fix: arm, mach-omap2/mcbsp.c

Quoted 5 lines · Jaswinder Singh Rajput

fix the following 'make includecheck' warning:

arch/arm/mach-omap2/mcbsp.c: mach/irqs.h is included more than once.

Quoted 18 lines
---
 arch/arm/mach-omap2/mcbsp.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
arch/arm/mach-omap2/mcbsp.c +0 -1
index a5c0f04..99b6e15 100644
@@ -19,7 +19,6 @@
 
 #include <mach/irqs.h>
 #include <mach/dma.h>
-#include <mach/irqs.h>
 #include <mach/mux.h>
 #include <mach/cpu.h>
 #include <mach/mcbsp.h>
Signature · 1 line
1.6.0.6
#18 lore raw

PATCH 11/44 includecheck fix: arm, plat-s3c64xx/pm.c

In reply to Jaswinder Singh Rajput

fix the following 'make includecheck' warning:

arch/arm/plat-s3c64xx/pm.c: plat/regs-gpio.h is included more than once.

---
 arch/arm/plat-s3c64xx/pm.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)
arch/arm/plat-s3c64xx/pm.c +0 -2
index 07a6516..47632fc 100644
@@ -117,8 +117,6 @@ void s3c_pm_save_core(void)
  * this.
  */
 
-#include <plat/regs-gpio.h>
-
 static void s3c64xx_cpu_suspend(void)
 {
 	unsigned long tmp;
Signature · 1 line
1.6.0.6
#19 lore raw

PATCH 12/44 includecheck fix: arm, plat-stmp3xxx/pinmux.c

In reply to Jaswinder Singh Rajput

fix the following 'make includecheck' warning:

arch/arm/plat-stmp3xxx/pinmux.c: linux/sysdev.h is included more than once.

---
 arch/arm/plat-stmp3xxx/pinmux.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
arch/arm/plat-stmp3xxx/pinmux.c +0 -1
index d412003..6d6b1a4 100644
@@ -22,7 +22,6 @@
 #include <linux/sysdev.h>
 #include <linux/string.h>
 #include <linux/bitops.h>
-#include <linux/sysdev.h>
 #include <linux/irq.h>
 
 #include <mach/hardware.h>
Signature · 1 line
1.6.0.6
#20 lore raw

PATCH 13/44 includecheck fix: mn10300, sys_mn10300.c

In reply to Jaswinder Singh Rajput

includecheck fix: mn10300, sys_mn10300.c

fix the following 'make includecheck' warning:

arch/mn10300/kernel/sys_mn10300.c: linux/syscalls.h is included more than once.

---
 arch/mn10300/kernel/sys_mn10300.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
arch/mn10300/kernel/sys_mn10300.c +0 -1
index bca5a84..6551ada 100644
@@ -21,7 +21,6 @@
 #include <linux/mman.h>
 #include <linux/file.h>
 #include <linux/utsname.h>
-#include <linux/syscalls.h>
 #include <linux/tty.h>
 
 #include <asm/uaccess.h>
Signature · 1 line
1.6.0.6
#21 lore raw

PATCH 14/44 includecheck fix: powerpc, mpc7450-pmu.c

In reply to Jaswinder Singh Rajput

fix the following 'make includecheck' warning:

arch/powerpc/kernel/mpc7450-pmu.c: linux/string.h is included more than once.

---
 arch/powerpc/kernel/mpc7450-pmu.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
arch/powerpc/kernel/mpc7450-pmu.c +0 -1
index 75ff47f..c244133 100644
@@ -10,7 +10,6 @@
  */
 #include <linux/string.h>
 #include <linux/perf_counter.h>
-#include <linux/string.h>
 #include <asm/reg.h>
 #include <asm/cputable.h>
 
Signature · 1 line
1.6.0.6
#22 lore raw

PATCH 15/44 includecheck fix: powerpc, ppc970-pmu.c

In reply to Jaswinder Singh Rajput

fix the following 'make includecheck' warning:

arch/powerpc/kernel/ppc970-pmu.c: linux/string.h is included more than once.

---
 arch/powerpc/kernel/ppc970-pmu.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
arch/powerpc/kernel/ppc970-pmu.c +0 -1
index 6637c87..833097a 100644
@@ -10,7 +10,6 @@
  */
 #include <linux/string.h>
 #include <linux/perf_counter.h>
-#include <linux/string.h>
 #include <asm/reg.h>
 #include <asm/cputable.h>
 
Signature · 1 line
1.6.0.6
#23 lore raw

PATCH 16/44 includecheck fix: s390, sys_s390.c

In reply to Jaswinder Singh Rajput

fix the following 'make includecheck' warning:

arch/s390/kernel/sys_s390.c: linux/syscalls.h is included more than once.

---
 arch/s390/kernel/sys_s390.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
arch/s390/kernel/sys_s390.c +0 -1
index c7ae4b1..e9d94f6 100644
@@ -29,7 +29,6 @@
 #include <linux/personality.h>
 #include <linux/unistd.h>
 #include <linux/ipc.h>
-#include <linux/syscalls.h>
 #include <asm/uaccess.h>
 #include "entry.h"
 
Signature · 1 line
1.6.0.6
#24 lore raw

PATCH 17/44 includecheck fix: um, helper.c

In reply to Jaswinder Singh Rajput

fix the following 'make includecheck' warning:

arch/um/os-Linux/helper.c: linux/limits.h is included more than once.

---
 arch/um/os-Linux/helper.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
arch/um/os-Linux/helper.c +0 -1
index 30860b8..b6b1096 100644
@@ -15,7 +15,6 @@
 #include "os.h"
 #include "um_malloc.h"
 #include "user.h"
-#include <linux/limits.h>
 
 struct helper_data {
 	void (*pre_exec)(void*);
Signature · 1 line
1.6.0.6
Acked-by on v1 17/44
#25 lore raw

Re: [PATCH 17/44] includecheck fix: um, helper.c

Quoted 15 lines · Jaswinder Singh Rajput

fix the following 'make includecheck' warning:

arch/um/os-Linux/helper.c: linux/limits.h is included more than once.

---
arch/um/os-Linux/helper.c | 1 -

1 files changed, 0 insertions(+), 1 deletions(-)
arch/um/os-Linux/helper.c +0 -0
index 30860b8..b6b1096 100644

arch/um/os-Linux/helper.c line 20

Quoted 7 lines
arch/um/os-Linux/helper.c +0 -1
@@ -15,7 +15,6 @@
 #include "os.h"
 #include "um_malloc.h"
 #include "user.h"
-#include <linux/limits.h>
 
 struct helper_data {
 	void (*pre_exec)(void*);

Definitely yes.

#26 lore raw

PATCH 18/44 includecheck fix: x86, dumpstack.c

In reply to Jaswinder Singh Rajput

fix the following 'make includecheck' warning:

arch/x86/kernel/dumpstack.c: linux/ftrace.h is included more than once.

---
 arch/x86/kernel/dumpstack.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
arch/x86/kernel/dumpstack.c +0 -1
index c840571..2d8a371 100644
@@ -15,7 +15,6 @@
 #include <linux/bug.h>
 #include <linux/nmi.h>
 #include <linux/sysfs.h>
-#include <linux/ftrace.h>
 
 #include <asm/stacktrace.h>
 
Signature · 1 line
1.6.0.6
Acked-by on v1 18/44
#27 lore raw

Re: [PATCH 18/44] includecheck fix: x86, dumpstack.c

[Jaswinder Singh Rajput - Wed, Jul 08, 2009 at 08:27:05PM +0530]

| 
| fix the following 'make includecheck' warning:
| 
|   arch/x86/kernel/dumpstack.c: linux/ftrace.h is included more than once.
| 
| Signed-off-by: Jaswinder Singh Rajput <[email protected]>
| ---
|  arch/x86/kernel/dumpstack.c |    1 -
|  1 files changed, 0 insertions(+), 1 deletions(-)
| 
| diff --git a/arch/x86/kernel/dumpstack.c b/arch/x86/kernel/dumpstack.c
| index c840571..2d8a371 100644
| --- a/arch/x86/kernel/dumpstack.c
| +++ b/arch/x86/kernel/dumpstack.c
| @@ -15,7 +15,6 @@
|  #include <linux/bug.h>
|  #include <linux/nmi.h>
|  #include <linux/sysfs.h>
| -#include <linux/ftrace.h>
|  
|  #include <asm/stacktrace.h>
|  
| -- 
| 1.6.0.6

Looks good to me.

-- Cyrill

#28 lore raw

PATCH 19/44 includecheck fix: x86, traps.c

In reply to Jaswinder Singh Rajput

fix the following 'make includecheck' warning:

arch/x86/kernel/traps.c: asm/traps.h is included more than once.

---
 arch/x86/kernel/traps.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
arch/x86/kernel/traps.c +0 -1
index 5204332..de96b50 100644
@@ -64,7 +64,6 @@
 #else
 #include <asm/processor-flags.h>
 #include <asm/setup.h>
-#include <asm/traps.h>
 
 asmlinkage int system_call(void);
 
Signature · 1 line
1.6.0.6
#29 lore raw

PATCH 20/44 includecheck fix: x86, shadow.c

In reply to Jaswinder Singh Rajput

fix the following 'make includecheck' warning:

arch/x86/mm/kmemcheck/shadow.c: linux/module.h is included more than once.

---
 arch/x86/mm/kmemcheck/shadow.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
arch/x86/mm/kmemcheck/shadow.c +0 -1
index e773b6b..3f66b82 100644
@@ -1,7 +1,6 @@
 #include <linux/kmemcheck.h>
 #include <linux/module.h>
 #include <linux/mm.h>
-#include <linux/module.h>
 
 #include <asm/page.h>
 #include <asm/pgtable.h>
Signature · 1 line
1.6.0.6
#30 lore raw

Re: [PATCH 20/44] includecheck fix: x86, shadow.c

[Jaswinder Singh Rajput - Wed, Jul 08, 2009 at 08:29:39PM +0530]

| 
| fix the following 'make includecheck' warning:
| 
|   arch/x86/mm/kmemcheck/shadow.c: linux/module.h is included more than once.
| 
| Signed-off-by: Jaswinder Singh Rajput <[email protected]>
| ---
|  arch/x86/mm/kmemcheck/shadow.c |    1 -
|  1 files changed, 0 insertions(+), 1 deletions(-)
| 
| diff --git a/arch/x86/mm/kmemcheck/shadow.c b/arch/x86/mm/kmemcheck/shadow.c
| index e773b6b..3f66b82 100644
| --- a/arch/x86/mm/kmemcheck/shadow.c
| +++ b/arch/x86/mm/kmemcheck/shadow.c
| @@ -1,7 +1,6 @@
|  #include <linux/kmemcheck.h>
|  #include <linux/module.h>
|  #include <linux/mm.h>
| -#include <linux/module.h>
|  
|  #include <asm/page.h>
|  #include <asm/pgtable.h>
| -- 
| 1.6.0.6
|

Better to CC Vegard on this.

-- Cyrill

#31 lore raw

Re: [PATCH 20/44] includecheck fix: x86, shadow.c

Quoted 11 lines · Cyrill Gorcunov
|  #include <linux/kmemcheck.h>
|  #include <linux/module.h>
|  #include <linux/mm.h>
| -#include <linux/module.h>
|  
|  #include <asm/page.h>
|  #include <asm/pgtable.h>
| -- 
| 1.6.0.6
|
Quoted 1 line

Better to CC Vegard on this.

Can we stop this kindergarden already? The patch is so obvious that it just should be applied. I'll pick up all x86 ones and fold them in.

Thanks,

tglx

#32 lore raw

Re: [PATCH 20/44] includecheck fix: x86, shadow.c

Hi Thomas,

Quoted 13 lines · Cyrill Gorcunov
Quoted 12 lines
|  #include <linux/kmemcheck.h>
|  #include <linux/module.h>
|  #include <linux/mm.h>
| -#include <linux/module.h>
|
|  #include <asm/page.h>
|  #include <asm/pgtable.h>
| --
| 1.6.0.6
|

Better to CC Vegard on this.

Quoted 2 lines · Thomas Gleixner

Can we stop this kindergarden already? The patch is so obvious that it just should be applied. I'll pick up all x86 ones and fold them in.

What kindergarten are you talking about? Technically Ingo "kicked" kmemcheck out of the x86 tree so the patch should go through kmemcheck.git which makes Cyrill's CC correction spot on.

Pekka

#33 lore raw

Re: [PATCH 20/44] includecheck fix: x86, shadow.c

Quoted 7 lines · Pekka Enberg
Quoted 2 lines · Thomas Gleixner

Can we stop this kindergarden already? The patch is so obvious that it just should be applied. I'll pick up all x86 ones and fold them in.

What kindergarten are you talking about? Technically Ingo "kicked" kmemcheck out of the x86 tree so the patch should go through kmemcheck.git which makes Cyrill's CC correction spot on.

I'm referring to the fact that these changes are so obvious that we do neither need dozens separate commits nor the ack of everyone plus some more. My inbox is full enough already.

Thanks,

tglx

#34 lore raw

Re: [PATCH 20/44] includecheck fix: x86, shadow.c

Quoted 5 lines · Thomas Gleixner
Quoted 4 lines · Pekka Enberg
Quoted 2 lines · Thomas Gleixner

Can we stop this kindergarden already? The patch is so obvious that it just should be applied. I'll pick up all x86 ones and fold them in.

Quoted 8 lines
Quoted 3 lines

What kindergarten are you talking about? Technically Ingo "kicked" kmemcheck out of the x86 tree so the patch should go through kmemcheck.git which makes Cyrill's CC correction spot on.

I'm referring to the fact that these changes are so obvious that we do neither need dozens separate commits nor the ack of everyone plus some more. My inbox is full enough already.

Hey kindergarten kid,

What the hell you are talking about, I did not send even one email to you.

Hey kid here is your today's lesson:

If you and your inbox is upset with x86 maintainers <[email protected]> emails then quit x86 maintainer-ship.

If you and your inbox is upset with LKML emails then quit LKML.

If you upset with life then ...

--
JSR

#35 lore raw

Re: [PATCH 20/44] includecheck fix: x86, shadow.c

Quoted 5 lines · Jaswinder Singh Rajput

Hey kindergarten kid,

What the hell you are talking about, I did not send even one email to you.

Quoted 8 lines

Hey kid here is your today's lesson:

If you and your inbox is upset with x86 maintainers <[email protected]> emails then quit x86 maintainer-ship.

If you and your inbox is upset with LKML emails then quit LKML.

If you upset with life then ...

Jaswinder, you might want wait for few days to calm down before writing more emails on LKML. Yes, I do realize you're upset after Ingo stopped nurturing your patches. But in the last 24 hours, you've told two Linux kernel maintainers to quit (and insulted them in the process) which is bit over the top, wouldn't you agree? If you continue doing this, I suspect you will end up in more killfiles and have all your patches ignored.

Pekka

#36 lore raw

PATCH 21/44 includecheck fix: Documentation, cfag12864b-example.c

In reply to Jaswinder Singh Rajput

fix the following 'make includecheck' warning:

Documentation/auxdisplay/cfag12864b-example.c: string.h is included more than once.

---
 Documentation/auxdisplay/cfag12864b-example.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
Documentation/auxdisplay/cfag12864b-example.c +0 -1
index 2caeea5..156bcaa 100644
@@ -194,7 +194,6 @@ void cfag12864b_blit(void)
  */
 
 #include <stdio.h>
-#include <string.h>
 
 #define EXAMPLES	6
 
Signature · 1 line
1.6.0.6
Acked-by on v1 21/44
#37 lore raw

Re: [PATCH 21/44] includecheck fix: Documentation, cfag12864b-example.c

Quoted 6 lines · On Wed, 08 Jul 2009 20:32:49 +0530 Jaswinder Singh Rajput wrote:

fix the following 'make includecheck' warning:

Documentation/auxdisplay/cfag12864b-example.c: string.h is included more than once.

Quoted 10 lines
---
 Documentation/auxdisplay/cfag12864b-example.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
Documentation/auxdisplay/cfag12864b-example.c +0 -0
index 2caeea5..156bcaa 100644

Documentation/auxdisplay/cfag12864b-example.c void cfag12864b_blit(void) · line 199

Quoted 7 lines
Documentation/auxdisplay/cfag12864b-example.c +0 -1
@@ -194,7 +194,6 @@ void cfag12864b_blit(void)
  */
 
 #include <stdio.h>
-#include <string.h>
 
 #define EXAMPLES	6
 

---
~Randy
LPC 2009, Sept. 23-25, Portland, Oregon
http://linuxplumbersconf.org/2009/

#38 lore raw

PATCH 22/44 includecheck fix: drivers/char, vt.c

In reply to Jaswinder Singh Rajput

fix the following 'make includecheck' warning:

drivers/char/vt.c: linux/device.h is included more than once.

---
 drivers/char/vt.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
drivers/char/vt.c +0 -1
index d9113b4..4330980 100644
@@ -2963,7 +2963,6 @@ int __init vty_init(const struct file_operations *console_fops)
 }
 
 #ifndef VT_SINGLE_DRIVER
-#include <linux/device.h>
 
 static struct class *vtconsole_class;
 
Signature · 1 line
1.6.0.6
#39 lore raw

PATCH 23/44 includecheck fix: drivers/net, sja1000.c

In reply to Jaswinder Singh Rajput

fix the following 'make includecheck' warning:

drivers/net/can/sja1000/sja1000.c: linux/can/dev.h is included more than once.

---
 drivers/net/can/sja1000/sja1000.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
drivers/net/can/sja1000/sja1000.c +0 -1
index 571f133..08ebee7 100644
@@ -63,7 +63,6 @@
 #include <linux/can.h>
 #include <linux/can/dev.h>
 #include <linux/can/error.h>
-#include <linux/can/dev.h>
 
 #include "sja1000.h"
 
Signature · 1 line
1.6.0.6
#40 lore raw

PATCH 24/44 includecheck fix: drivers/net, axnet_cs.c

In reply to Jaswinder Singh Rajput

fix the following 'make includecheck' warning:

drivers/net/pcmcia/axnet_cs.c: linux/etherdevice.h is included more than once.

---
 drivers/net/pcmcia/axnet_cs.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)
drivers/net/pcmcia/axnet_cs.c +0 -2
index 0e38d80..5a17117 100644
@@ -893,8 +893,6 @@ static const char version_8390[] = KERN_INFO \
 #include <linux/in.h>
 #include <linux/interrupt.h>
 
-#include <linux/etherdevice.h>
-
 #define BUG_83C690
 
 /* These are the operational function interfaces to board-specific
Signature · 1 line
1.6.0.6
#41 lore raw

PATCH 25/44 includecheck fix: drivers/net, smc911x.h

In reply to Jaswinder Singh Rajput

fix the following 'make includecheck' warning:

drivers/net/smc911x.h: mach/dma.h is included more than once.

---
 drivers/net/smc911x.h |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
drivers/net/smc911x.h +0 -1
index 8140f7c..05adb6a 100644
@@ -236,7 +236,6 @@ static inline void SMC_outsl(struct smc911x_local *lp, int reg,
  * Use a DMA for RX and TX packets.
  */
 #include <linux/dma-mapping.h>
-#include <mach/dma.h>
 
 static dma_addr_t rx_dmabuf, tx_dmabuf;
 static int rx_dmalen, tx_dmalen;
Signature · 1 line
1.6.0.6
#42 lore raw

PATCH 26/44 includecheck fix: drivers/parisc, ccio-dma.c

In reply to Jaswinder Singh Rajput

fix the following 'make includecheck' warning:

drivers/parisc/ccio-dma.c: linux/proc_fs.h is included more than once.

---
 drivers/parisc/ccio-dma.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
drivers/parisc/ccio-dma.c +0 -1
index 0f0e0b9..a45b0c0 100644
@@ -70,7 +70,6 @@
 #undef CCIO_COLLECT_STATS
 #endif
 
-#include <linux/proc_fs.h>
 #include <asm/runway.h>		/* for proc_runway_root */
 
 #ifdef DEBUG_CCIO_INIT
Signature · 1 line
1.6.0.6
#43 lore raw

PATCH 27/44 includecheck fix: drivers/scsi, libfcoe.c

In reply to Jaswinder Singh Rajput

fix the following 'make includecheck' warning:

drivers/scsi/fcoe/libfcoe.c: linux/netdevice.h is included more than once.

---
 drivers/scsi/fcoe/libfcoe.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
drivers/scsi/fcoe/libfcoe.c +0 -1
index f544340..c7d8ca4 100644
@@ -29,7 +29,6 @@
 #include <linux/ethtool.h>
 #include <linux/if_ether.h>
 #include <linux/if_vlan.h>
-#include <linux/netdevice.h>
 #include <linux/errno.h>
 #include <linux/bitops.h>
 #include <net/rtnetlink.h>
Signature · 1 line
1.6.0.6
#44 lore raw

PATCH 28/44 includecheck fix: drivers/scsi, ibmvscsi.c

In reply to Jaswinder Singh Rajput

fix the following 'make includecheck' warning:

drivers/scsi/ibmvscsi/ibmvscsi.c: asm/firmware.h is included more than once.

---
 drivers/scsi/ibmvscsi/ibmvscsi.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
drivers/scsi/ibmvscsi/ibmvscsi.c +0 -1
index 9928704..d9b0e9d 100644
@@ -73,7 +73,6 @@
 #include <linux/of.h>
 #include <asm/firmware.h>
 #include <asm/vio.h>
-#include <asm/firmware.h>
 #include <scsi/scsi.h>
 #include <scsi/scsi_cmnd.h>
 #include <scsi/scsi_host.h>
Signature · 1 line
1.6.0.6
#45 lore raw

PATCH 29/44 includecheck fix: drivers/spi, amba-pl022.c

In reply to Jaswinder Singh Rajput

fix the following 'make includecheck' warnings:

drivers/spi/amba-pl022.c: linux/delay.h is included more than once. drivers/spi/amba-pl022.c: linux/errno.h is included more than once.

---
 drivers/spi/amba-pl022.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)
drivers/spi/amba-pl022.c +0 -2
index da76797..c0f950a 100644
@@ -38,14 +38,12 @@
 #include <linux/interrupt.h>
 #include <linux/spi/spi.h>
 #include <linux/workqueue.h>
-#include <linux/errno.h>
 #include <linux/delay.h>
 #include <linux/clk.h>
 #include <linux/err.h>
 #include <linux/amba/bus.h>
 #include <linux/amba/pl022.h>
 #include <linux/io.h>
-#include <linux/delay.h>
 
 /*
  * This macro is used to define some register default values.
Signature · 1 line
1.6.0.6
Acked-by on v1 29/44
#46 lore raw

Re: [PATCH 29/44] includecheck fix: drivers/spi, amba-pl022.c

2009/7/8 Jaswinder Singh Rajput <[email protected]>:

Quoted 4 lines

fix the following 'make includecheck' warnings:

 drivers/spi/amba-pl022.c: linux/delay.h is included more than once. drivers/spi/amba-pl022.c: linux/errno.h is included more than once.

David are you merging this?

Linus Walleij

#47 lore raw

Re: [PATCH 29/44] includecheck fix: drivers/spi, amba-pl022.c

Quoted 11 lines · Linus Walleij

2009/7/8 Jaswinder Singh Rajput <[email protected]>:

Quoted 4 lines

fix the following 'make includecheck' warnings:

drivers/spi/amba-pl022.c: linux/delay.h is included more than once. drivers/spi/amba-pl022.c: linux/errno.h is included more than once.

David are you merging this?

This is a big patchset, So better me or Sam will send this to Linus after collecting some more ACKs.

Thanks,
--
JSR

#48 lore raw

Re: [PATCH 29/44] includecheck fix: drivers/spi, amba-pl022.c

2009/7/8 Jaswinder Singh Rajput <[email protected]>:

Quoted 8 lines · Linus Walleij
Quoted 7 lines

2009/7/8 Jaswinder Singh Rajput <[email protected]>:

Quoted 4 lines

fix the following 'make includecheck' warnings:

 drivers/spi/amba-pl022.c: linux/delay.h is included more than once. drivers/spi/amba-pl022.c: linux/errno.h is included more than once.

Quoted 6 lines
Quoted 3 lines

David are you merging this?

This is a big patchset, So better me or Sam will send this to Linus after collecting some more ACKs.

Not me I hope (damned I knew this would happen sooner or later). return -ELINWAL

Having this name is very convenient, people review my drivers like crazy.

Linus Walleij

#49 lore raw

Re: [PATCH 29/44] includecheck fix: drivers/spi, amba-pl022.c

Quoted 3 lines · Linus Walleij

Having this name is very convenient, people review my drivers like crazy.

ROTFL.

the-other-Linus

Acked-by on v1 29/44
#50 lore raw

Re: [PATCH 29/44] includecheck fix: drivers/spi, amba-pl022.c

In reply to Jaswinder Singh Rajput
Quoted 7 lines · Jaswinder Singh Rajput

fix the following 'make includecheck' warnings:

drivers/spi/amba-pl022.c: linux/delay.h is included more than once. drivers/spi/amba-pl022.c: linux/errno.h is included more than once.

Quoted 29 lines
---
 drivers/spi/amba-pl022.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)
drivers/spi/amba-pl022.c +0 -2
index da76797..c0f950a 100644
@@ -38,14 +38,12 @@
 #include <linux/interrupt.h>
 #include <linux/spi/spi.h>
 #include <linux/workqueue.h>
-#include <linux/errno.h>
 #include <linux/delay.h>
 #include <linux/clk.h>
 #include <linux/err.h>
 #include <linux/amba/bus.h>
 #include <linux/amba/pl022.h>
 #include <linux/io.h>
-#include <linux/delay.h>
 
 /*
  * This macro is used to define some register default values.
Signature · 1 line
1.6.0.6
#51 lore raw

PATCH 30/44 includecheck fix: drivers/staging, usbdrv.c

In reply to Jaswinder Singh Rajput

fix the following 'make includecheck' warning:

drivers/staging/otus/usbdrv.c: net/iw_handler.h is included more than once.

---
 drivers/staging/otus/usbdrv.c |    3 ---
 1 files changed, 0 insertions(+), 3 deletions(-)
drivers/staging/otus/usbdrv.c +0 -3
index 540cbbb..ec98518 100644
@@ -113,9 +113,6 @@ extern u8_t zfLnxCreateThread(zdev_t *dev);
 
 /* Definition of Wireless Extension */
 
-#if WIRELESS_EXT > 12
-#include <net/iw_handler.h>
-#endif
 //wireless extension helper functions
 extern int usbdrv_ioctl_setessid(struct net_device *dev, struct iw_point *erq);
 extern int usbdrv_ioctl_setrts(struct net_device *dev, struct iw_param *rrq);
Signature · 1 line
1.6.0.6
#52 lore raw

PATCH 31/44 includecheck fix: drivers/staging, rt_linux.h

In reply to Jaswinder Singh Rajput

fix the following 'make includecheck' warning:

drivers/staging/rt2860/rt_linux.h: linux/wireless.h is included more than once.

---
 drivers/staging/rt2860/rt_linux.h |    4 ----
 1 files changed, 0 insertions(+), 4 deletions(-)
drivers/staging/rt2860/rt_linux.h +0 -4
index 85175c1..ed75673 100644
@@ -66,10 +66,6 @@
 #include <linux/ctype.h>
 #include <linux/vmalloc.h>
 
-
-#ifdef RT30xx
-#include <linux/wireless.h>
-#endif
 #include <net/iw_handler.h>
 
 // load firmware
Signature · 1 line
1.6.0.6
#53 lore raw

PATCH 32/44 includecheck fix: drivers/video, vgacon.c

In reply to Jaswinder Singh Rajput

fix the following 'make includecheck' warning:

drivers/video/console/vgacon.c: linux/slab.h is included more than once.

---
 drivers/video/console/vgacon.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
drivers/video/console/vgacon.c +0 -1
index 59d7d5e..74e96cf 100644
@@ -180,7 +180,6 @@ static inline void vga_set_mem_top(struct vc_data *c)
 }
 
 #ifdef CONFIG_VGACON_SOFT_SCROLLBACK
-#include <linux/slab.h>
 /* software scrollback */
 static void *vgacon_scrollback;
 static int vgacon_scrollback_tail;
Signature · 1 line
1.6.0.6
#54 lore raw

PATCH 33/44 includecheck fix: drivers/xen, evtchn.c

In reply to Jaswinder Singh Rajput

fix the following 'make includecheck' warning:

drivers/xen/evtchn.c: linux/errno.h is included more than once.

---
 drivers/xen/evtchn.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
drivers/xen/evtchn.c +0 -1
index af03195..79bedba 100644
@@ -38,7 +38,6 @@
 #include <linux/string.h>
 #include <linux/errno.h>
 #include <linux/fs.h>
-#include <linux/errno.h>
 #include <linux/miscdevice.h>
 #include <linux/major.h>
 #include <linux/proc_fs.h>
Signature · 1 line
1.6.0.6
Acked-by on v1 33/44
#55 lore raw

Re: [PATCH 33/44] includecheck fix: drivers/xen, evtchn.c

Quoted 6 lines · Jaswinder Singh Rajput

fix the following 'make includecheck' warning:

drivers/xen/evtchn.c: linux/errno.h is included more than once.

Thanks,
J

Quoted 17 lines
---
 drivers/xen/evtchn.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
drivers/xen/evtchn.c +0 -1
index af03195..79bedba 100644
@@ -38,7 +38,6 @@
 #include <linux/string.h>
 #include <linux/errno.h>
 #include <linux/fs.h>
-#include <linux/errno.h>
 #include <linux/miscdevice.h>
 #include <linux/major.h>
 #include <linux/proc_fs.h>
#56 lore raw

PATCH 34/44 includecheck fix: fs/xfs, xfs_iops.c

In reply to Jaswinder Singh Rajput

fix the following 'make includecheck' warning:

fs/xfs/linux-2.6/xfs_iops.c: xfs_acl.h is included more than once.

---
 fs/xfs/linux-2.6/xfs_iops.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
fs/xfs/linux-2.6/xfs_iops.c +0 -1
index 58973bb..793a146 100644
@@ -43,7 +43,6 @@
 #include "xfs_error.h"
 #include "xfs_itable.h"
 #include "xfs_rw.h"
-#include "xfs_acl.h"
 #include "xfs_attr.h"
 #include "xfs_buf_item.h"
 #include "xfs_utils.h"
Signature · 8 lines
1.6.0.6



_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs
Acked-by on v1 34/44
#57 lore raw

Re: [PATCH 34/44] includecheck fix: fs/xfs, xfs_iops.c

Quoted 5 lines · Jaswinder Singh Rajput

fix the following 'make includecheck' warning:

fs/xfs/linux-2.6/xfs_iops.c: xfs_acl.h is included more than once.

Quoted 18 lines
---
 fs/xfs/linux-2.6/xfs_iops.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
fs/xfs/linux-2.6/xfs_iops.c +0 -1
index 58973bb..793a146 100644
@@ -43,7 +43,6 @@
 #include "xfs_error.h"
 #include "xfs_itable.h"
 #include "xfs_rw.h"
-#include "xfs_acl.h"
 #include "xfs_attr.h"
 #include "xfs_buf_item.h"
 #include "xfs_utils.h"
Signature · 1 line
1.6.0.6
Signature · 9 lines
Olaf Weber                 SGI               Phone:  +31(0)30-6696752
                           Veldzigt 2b       Fax:    +31(0)30-6696799
Technical Lead             3454 PW de Meern  Vnet:   955-7151
Storage Software           The Netherlands   Email:  [email protected]

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs
#58 lore raw

PATCH 35/44 includecheck fix: include/acpi, acpi_bus.h

In reply to Jaswinder Singh Rajput

fix the following 'make includecheck' warning:

include/acpi/acpi_bus.h: linux/device.h is included more than once.

---
 include/acpi/acpi_bus.h |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
include/acpi/acpi_bus.h +0 -1
index c65e4ce..2d8f6ef 100644
@@ -356,7 +356,6 @@ void acpi_remove_dir(struct acpi_device *);
 /*
  * Bind physical devices with ACPI devices
  */
-#include <linux/device.h>
 struct acpi_bus_type {
 	struct list_head list;
 	struct bus_type *bus;
Signature · 1 line
1.6.0.6
#59 lore raw

PATCH 36/44 includecheck fix: include/drm, drm_memory.h

In reply to Jaswinder Singh Rajput

fix the following 'make includecheck' warning:

include/drm/drm_memory.h: linux/vmalloc.h is included more than once.

---
 include/drm/drm_memory.h |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)
include/drm/drm_memory.h +0 -2
index 63e425b..15af9b3 100644
@@ -44,8 +44,6 @@
 
 #if __OS_HAS_AGP
 
-#include <linux/vmalloc.h>
-
 #ifdef HAVE_PAGE_AGP
 #include <asm/agp.h>
 #else
Signature · 1 line
1.6.0.6
Acked-by on v1 36/44
#60 lore raw

Re: [PATCH 36/44] includecheck fix: include/drm, drm_memory.h

Quoted 6 lines

fix the following 'make includecheck' warning:

include/drm/drm_memory.h: linux/vmalloc.h is included more than once.

Dave.

Quoted 18 lines
---
 include/drm/drm_memory.h |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)
include/drm/drm_memory.h +0 -2
index 63e425b..15af9b3 100644
@@ -44,8 +44,6 @@
 
 #if __OS_HAS_AGP
 
-#include <linux/vmalloc.h>
-
 #ifdef HAVE_PAGE_AGP
 #include <asm/agp.h>
 #else
#61 lore raw

PATCH 37/44 includecheck fix: include/linux, aio.h

In reply to Jaswinder Singh Rajput

fix the following 'make includecheck' warning:

include/linux/aio.h: linux/aio_abi.h is included more than once.

---
 include/linux/aio.h |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)
include/linux/aio.h +0 -2
index 47f7d93..aea219d 100644
@@ -225,8 +225,6 @@ static inline void exit_aio(struct mm_struct *mm) { }
 
 #define io_wait_to_kiocb(wait) container_of(wait, struct kiocb, ki_wait)
 
-#include <linux/aio_abi.h>
-
 static inline struct kiocb *list_kiocb(struct list_head *h)
 {
 	return list_entry(h, struct kiocb, ki_list);
Signature · 1 line
1.6.0.6
#62 lore raw

PATCH 38/44 includecheck fix: include/linux, ftrace.h

In reply to Jaswinder Singh Rajput

fix the following 'make includecheck' warning:

include/linux/ftrace.h: linux/sched.h is included more than once.

---
 include/linux/ftrace.h |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
include/linux/ftrace.h +0 -1
index dc3b132..3c0924a 100644
@@ -446,7 +446,6 @@ static inline void unpause_graph_tracing(void) { }
 #endif /* CONFIG_FUNCTION_GRAPH_TRACER */
 
 #ifdef CONFIG_TRACING
-#include <linux/sched.h>
 
 /* flags for current->trace */
 enum {
Signature · 1 line
1.6.0.6
#63 lore raw

PATCH 39/44 includecheck fix: include/linux, icmpv6.h

In reply to Jaswinder Singh Rajput

fix the following 'make includecheck' warning:

include/linux/icmpv6.h: linux/skbuff.h is included more than once.

---
 include/linux/icmpv6.h |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)
include/linux/icmpv6.h +0 -2
index b6a8518..c0d8357 100644
@@ -171,8 +171,6 @@ struct icmp6_filter {
 #ifdef __KERNEL__
 
 #include <linux/netdevice.h>
-#include <linux/skbuff.h>
-
 
 extern void				icmpv6_send(struct sk_buff *skb,
 						    u8 type, u8 code,
Signature · 1 line
1.6.0.6
#64 lore raw

PATCH 40/44 includecheck fix: include/linux, net_dropmon.h

In reply to Jaswinder Singh Rajput

fix the following 'make includecheck' warning:

include/linux/net_dropmon.h: linux/types.h is included more than once.

---
 include/linux/net_dropmon.h |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
include/linux/net_dropmon.h +0 -1
index 3ceb0cc..2a73946 100644
@@ -3,7 +3,6 @@
 
 #include <linux/types.h>
 #include <linux/netlink.h>
-#include <linux/types.h>
 
 struct net_dm_drop_point {
 	__u8 pc[8];
Signature · 1 line
1.6.0.6
#65 lore raw

PATCH 41/44 includecheck fix: include/linux, rfkill.h

In reply to Jaswinder Singh Rajput

fix the following 'make includecheck' warning:

include/linux/rfkill.h: linux/types.h is included more than once.

---
 include/linux/rfkill.h |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
include/linux/rfkill.h +0 -1
index e73e242..2ce2983 100644
@@ -99,7 +99,6 @@ enum rfkill_user_states {
 #undef RFKILL_STATE_UNBLOCKED
 #undef RFKILL_STATE_HARD_BLOCKED
 
-#include <linux/types.h>
 #include <linux/kernel.h>
 #include <linux/list.h>
 #include <linux/mutex.h>
Signature · 1 line
1.6.0.6
#66 lore raw

Re: [PATCH 41/44] includecheck fix: include/linux, rfkill.h

Hi Jaswinder,

Quoted 14 lines

fix the following 'make includecheck' warning:

include/linux/rfkill.h: linux/types.h is included more than once.

---
 include/linux/rfkill.h |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
include/linux/rfkill.h +0 -0
index e73e242..2ce2983 100644

include/linux/rfkill.h enum rfkill_user_states { · line 104

Quoted 7 lines
include/linux/rfkill.h +0 -1
@@ -99,7 +99,6 @@ enum rfkill_user_states {
 #undef RFKILL_STATE_UNBLOCKED
 #undef RFKILL_STATE_HARD_BLOCKED
 
-#include <linux/types.h>
 #include <linux/kernel.h>
 #include <linux/list.h>
 #include <linux/mutex.h>

with the #ifdef __KERNEL__ in between it is kinda weird, but patch seems correct.

Regards

Marcel

#67 lore raw

Re: [PATCH 41/44] includecheck fix: include/linux, rfkill.h

Hello Marcel,

Quoted 19 lines · Marcel Holtmann

Hi Jaswinder,

Quoted 17 lines

fix the following 'make includecheck' warning:

include/linux/rfkill.h: linux/types.h is included more than once.

---
 include/linux/rfkill.h |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
include/linux/rfkill.h +0 -0
index e73e242..2ce2983 100644
@@ -99,7 +99,6 @@ enum rfkill_user_states {
 #undef RFKILL_STATE_UNBLOCKED
 #undef RFKILL_STATE_HARD_BLOCKED
 
Quoted 8 lines

include/linux/rfkill.h enum rfkill_user_states { · line 104

Quoted 4 lines
include/linux/rfkill.h +0 -1
-#include <linux/types.h>
 #include <linux/kernel.h>
 #include <linux/list.h>
 #include <linux/mutex.h>

with the #ifdef __KERNEL__ in between it is kinda weird, but patch seems correct.

ACK or Reviewed-by ?

Thanks,
--
JSR

#68 lore raw

Re: [PATCH 41/44] includecheck fix: include/linux, rfkill.h

Hi Jaswinder,

Quoted 26 lines
Quoted 17 lines
Quoted 17 lines

fix the following 'make includecheck' warning:

include/linux/rfkill.h: linux/types.h is included more than once.

---
 include/linux/rfkill.h |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
include/linux/rfkill.h +0 -0
index e73e242..2ce2983 100644
@@ -99,7 +99,6 @@ enum rfkill_user_states {
 #undef RFKILL_STATE_UNBLOCKED
 #undef RFKILL_STATE_HARD_BLOCKED
 
Quoted 8 lines

include/linux/rfkill.h enum rfkill_user_states { · line 104

Quoted 4 lines
include/linux/rfkill.h +0 -1
-#include <linux/types.h>
 #include <linux/kernel.h>
 #include <linux/list.h>
 #include <linux/mutex.h>

with the #ifdef __KERNEL__ in between it is kinda weird, but patch seems correct.

Quoted 1 line

ACK or Reviewed-by ?

both if you want to, but John already picked it up for wireless-testing if I am not mistaken. So it is on its way into 2.6.32 somehow.

Regards

Marcel

#69 lore raw

PATCH 42/44 includecheck fix: kernel/trace, ring_buffer.c

In reply to Jaswinder Singh Rajput

fix the following 'make includecheck' warning:

kernel/trace/ring_buffer.c: trace.h is included more than once.

---
 kernel/trace/ring_buffer.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)
kernel/trace/ring_buffer.c +0 -2
index bf27bb7..636cee9 100644
@@ -201,8 +201,6 @@ int tracing_is_on(void)
 }
 EXPORT_SYMBOL_GPL(tracing_is_on);
 
-#include "trace.h"
-
 #define RB_EVNT_HDR_SIZE (offsetof(struct ring_buffer_event, array))
 #define RB_ALIGNMENT		4U
 #define RB_MAX_SMALL_DATA	(RB_ALIGNMENT * RINGBUF_TYPE_DATA_TYPE_LEN_MAX)
Signature · 1 line
1.6.0.6
#70 lore raw

PATCH 43/44 includecheck fix: mm, nommu.c

In reply to Jaswinder Singh Rajput

fix the following 'make includecheck' warning:

mm/nommu.c: internal.h is included more than once.

---
 mm/nommu.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)
mm/nommu.c +0 -2
index 53cab10..e1ae0f9 100644
@@ -56,8 +56,6 @@ void no_printk(const char *fmt, ...)
 	no_printk(KERN_DEBUG FMT"\n", ##__VA_ARGS__)
 #endif
 
-#include "internal.h"
-
 void *high_memory;
 struct page *mem_map;
 unsigned long max_mapnr;
Signature · 1 line
1.6.0.6
#71 lore raw

PATCH 44/44 includecheck fix: mm, shmem.c

In reply to Jaswinder Singh Rajput

fix the following 'make includecheck' warning:

mm/shmem.c: linux/vfs.h is included more than once.

---
 mm/shmem.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
mm/shmem.c +0 -1
index d713239..34e56aa 100644
@@ -49,7 +49,6 @@ static struct vfsmount *shm_mnt;
 #include <linux/backing-dev.h>
 #include <linux/shmem_fs.h>
 #include <linux/writeback.h>
-#include <linux/vfs.h>
 #include <linux/blkdev.h>
 #include <linux/security.h>
 #include <linux/swapops.h>
Signature · 1 line
1.6.0.6
author Acked-by Randy Dunlap Acked-by Linus Walleij Acked-by David Brownell Acked-by Jeremy Fitzhardinge Acked-by Len Brown on the v1 series
#72 lore raw
In reply to Jaswinder Singh Rajput

Hello all,

Quoted 9 lines · Jaswinder Singh Rajput

The following changes since commit faf80d62e44dc627efb741f48db50c1858d1667c:
Linus Torvalds (1):

        Merge branch 'x86-fixes-for-linus' of git://git.kernel.org/.../tip/linux-2.6-tip

are available in the git repository at:

git://git.kernel.org/pub/scm/linux/kernel/git/jaswinder/headers-check-2.6.git master

Jaswinder Singh Rajput (44):

This is a big patchset, so it will be better that either me or Sam will send it to Linus after collecting ACKs.

So far I received ACKs for:

includecheck fix: Documentation, cfag12864b-example.c

includecheck fix: drivers/spi, amba-pl022.c

includecheck fix: drivers/xen, evtchn.c

includecheck fix: include/acpi, acpi_bus.h

I am still waiting ACK/NAK for :

includecheck fix: arm, misc.c includecheck fix: arm, atomic.h includecheck fix: arm, board-dm355-evm.c includecheck fix: arm, board-dm355-leopard.c includecheck fix: arm, board-dm644x-evm.c includecheck fix: arm, board-dm646x-evm.c includecheck fix: arm, board-sffsdr.c includecheck fix: arm, mach-mx3/devices.c includecheck fix: arm, mach-omap1/mcbsp.c includecheck fix: arm, mach-omap2/mcbsp.c includecheck fix: arm, plat-s3c64xx/pm.c includecheck fix: arm, plat-stmp3xxx/pinmux.c

includecheck fix: mn10300, sys_mn10300.c

includecheck fix: powerpc, mpc7450-pmu.c
includecheck fix: powerpc, ppc970-pmu.c

includecheck fix: s390, sys_s390.c

includecheck fix: um, helper.c

includecheck fix: x86, dumpstack.c
includecheck fix: x86, traps.c
includecheck fix: x86, shadow.c

includecheck fix: drivers/char, vt.c

includecheck fix: drivers/net, sja1000.c
includecheck fix: drivers/net, axnet_cs.c
includecheck fix: drivers/net, smc911x.h

includecheck fix: drivers/parisc, ccio-dma.c

includecheck fix: drivers/scsi, libfcoe.c
includecheck fix: drivers/scsi, ibmvscsi.c

includecheck fix: drivers/staging, usbdrv.c includecheck fix: drivers/staging, rt_linux.h

includecheck fix: drivers/video, vgacon.c

includecheck fix: fs/xfs, xfs_iops.c

includecheck fix: include/drm, drm_memory.h

includecheck fix: include/linux, aio.h

includecheck fix: include/linux, ftrace.h

includecheck fix: include/linux, icmpv6.h includecheck fix: include/linux, net_dropmon.h

includecheck fix: include/linux, rfkill.h

includecheck fix: kernel/trace, ring_buffer.c

includecheck fix: mm, nommu.c
includecheck fix: mm, shmem.c

Thanks,
--
JSR

Acked-by
#73 lore raw
Quoted 14 lines · Jaswinder Singh Rajput

I am still waiting ACK/NAK for :

includecheck fix: arm, misc.c includecheck fix: arm, atomic.h includecheck fix: arm, board-dm355-evm.c includecheck fix: arm, board-dm355-leopard.c includecheck fix: arm, board-dm644x-evm.c includecheck fix: arm, board-dm646x-evm.c includecheck fix: arm, board-sffsdr.c includecheck fix: arm, mach-mx3/devices.c includecheck fix: arm, mach-omap1/mcbsp.c includecheck fix: arm, mach-omap2/mcbsp.c includecheck fix: arm, plat-s3c64xx/pm.c includecheck fix: arm, plat-stmp3xxx/pinmux.c

You're still waiting because apparantly you never sent this set anywhere near any ARM people before.

For the first two, I'll ack them:

The remainder look sane to me, but you'll have to seek acks from the individual platform maintainer(s).

Signature · 3 lines
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:
#74 lore raw
Quoted 19 lines · Russell King
Quoted 14 lines · Jaswinder Singh Rajput

I am still waiting ACK/NAK for :

includecheck fix: arm, misc.c includecheck fix: arm, atomic.h includecheck fix: arm, board-dm355-evm.c includecheck fix: arm, board-dm355-leopard.c includecheck fix: arm, board-dm644x-evm.c includecheck fix: arm, board-dm646x-evm.c includecheck fix: arm, board-sffsdr.c includecheck fix: arm, mach-mx3/devices.c includecheck fix: arm, mach-omap1/mcbsp.c includecheck fix: arm, mach-omap2/mcbsp.c includecheck fix: arm, plat-s3c64xx/pm.c includecheck fix: arm, plat-stmp3xxx/pinmux.c

You're still waiting because apparantly you never sent this set anywhere near any ARM people before.

Quoted 7 lines

For the first two, I'll ack them:

The remainder look sane to me, but you'll have to seek acks from the individual platform maintainer(s).

OK, adding some more ARM people and ARM lists to get remaining ACK/NAK.

Patches are already posted to LKML and also available at :

http://git.kernel.org/?p=linux/kernel/git/jaswinder/headers-check-2.6.git;a=summary

In case if you are not able to find these patches let me know.

Thanks,
--
JSR

#75 lore raw
Quoted 3 lines · Jaswinder Singh Rajput
Quoted 2 lines · Russell King
Quoted 1 line · Jaswinder Singh Rajput

I am still waiting ACK/NAK for :

for this:

Quoted 1 line
Quoted 1 line
Quoted 1 line

includecheck fix: arm, plat-stmp3xxx/pinmux.c

Quoted 25 lines
Quoted 11 lines

You're still waiting because apparantly you never sent this set anywhere near any ARM people before.

For the first two, I'll ack them:

The remainder look sane to me, but you'll have to seek acks from the individual platform maintainer(s).

OK, adding some more ARM people and ARM lists to get remaining ACK/NAK.

Patches are already posted to LKML and also available at :

http://git.kernel.org/?p=linux/kernel/git/jaswinder/headers-check-2.6.git;a=summary

In case if you are not able to find these patches let me know.

Thanks,
--
JSR

Acked-by
#76 lore raw
In reply to Jaswinder Singh Rajput
Quoted 19 lines · Jaswinder Singh Rajput
Quoted 18 lines · Russell King
Quoted 14 lines · Jaswinder Singh Rajput

I am still waiting ACK/NAK for :

includecheck fix: arm, misc.c includecheck fix: arm, atomic.h includecheck fix: arm, board-dm355-evm.c includecheck fix: arm, board-dm355-leopard.c includecheck fix: arm, board-dm644x-evm.c includecheck fix: arm, board-dm646x-evm.c includecheck fix: arm, board-sffsdr.c includecheck fix: arm, mach-mx3/devices.c includecheck fix: arm, mach-omap1/mcbsp.c includecheck fix: arm, mach-omap2/mcbsp.c includecheck fix: arm, plat-s3c64xx/pm.c includecheck fix: arm, plat-stmp3xxx/pinmux.c

You're still waiting because apparantly you never sent this set anywhere near any ARM people before.

Quoted 7 lines
Quoted 7 lines

For the first two, I'll ack them:

The remainder look sane to me, but you'll have to seek acks from the individual platform maintainer(s).

Ack for plat-s3c64xx/pm.c:

Signature · 3 lines
Ben Dooks, Software Engineer, Simtec Electronics

http://www.simtec.co.uk/
#77 lore raw
In reply to Jaswinder Singh Rajput
Quoted 19 lines · Jaswinder Singh Rajput
Quoted 18 lines · Russell King
Quoted 14 lines · Jaswinder Singh Rajput

I am still waiting ACK/NAK for :

includecheck fix: arm, misc.c includecheck fix: arm, atomic.h includecheck fix: arm, board-dm355-evm.c includecheck fix: arm, board-dm355-leopard.c includecheck fix: arm, board-dm644x-evm.c includecheck fix: arm, board-dm646x-evm.c includecheck fix: arm, board-sffsdr.c includecheck fix: arm, mach-mx3/devices.c includecheck fix: arm, mach-omap1/mcbsp.c includecheck fix: arm, mach-omap2/mcbsp.c includecheck fix: arm, plat-s3c64xx/pm.c includecheck fix: arm, plat-stmp3xxx/pinmux.c

You're still waiting because apparantly you never sent this set anywhere near any ARM people before.

Quoted 7 lines
Quoted 7 lines

For the first two, I'll ack them:

The remainder look sane to me, but you'll have to seek acks from the individual platform maintainer(s).

Ack for board-sffsdr.c:

Quoted 14 lines

OK, adding some more ARM people and ARM lists to get remaining ACK/NAK.

Patches are already posted to LKML and also available at :

http://git.kernel.org/?p=linux/kernel/git/jaswinder/headers-check-2.6.git;a=summary

In case if you are not able to find these patches let me know.

Thanks,
--
JSR

Acked-by
#78 lore raw
In reply to Jaswinder Singh Rajput
Quoted 4 lines · Jaswinder Singh Rajput
Quoted 3 lines · Russell King
Quoted 2 lines · Jaswinder Singh Rajput

I am still waiting ACK/NAK for :

Quoted 12 lines
Quoted 4 lines
Quoted 4 lines

includecheck fix: arm, misc.c includecheck fix: arm, atomic.h includecheck fix: arm, board-dm355-evm.c includecheck fix: arm, board-dm355-leopard.c

Quoted 8 lines
Quoted 8 lines

includecheck fix: arm, board-dm644x-evm.c includecheck fix: arm, board-dm646x-evm.c includecheck fix: arm, board-sffsdr.c includecheck fix: arm, mach-mx3/devices.c includecheck fix: arm, mach-omap1/mcbsp.c includecheck fix: arm, mach-omap2/mcbsp.c includecheck fix: arm, plat-s3c64xx/pm.c includecheck fix: arm, plat-stmp3xxx/pinmux.c

For mach-mx3/devices.c:

Signature · 4 lines
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
#79 lore raw
In reply to Jaswinder Singh Rajput
Quoted 30 lines · ext Jaswinder Singh Rajput
Quoted 19 lines · Russell King
Quoted 14 lines · Jaswinder Singh Rajput

I am still waiting ACK/NAK for :

includecheck fix: arm, misc.c includecheck fix: arm, atomic.h includecheck fix: arm, board-dm355-evm.c includecheck fix: arm, board-dm355-leopard.c includecheck fix: arm, board-dm644x-evm.c includecheck fix: arm, board-dm646x-evm.c includecheck fix: arm, board-sffsdr.c includecheck fix: arm, mach-mx3/devices.c includecheck fix: arm, mach-omap1/mcbsp.c includecheck fix: arm, mach-omap2/mcbsp.c includecheck fix: arm, plat-s3c64xx/pm.c includecheck fix: arm, plat-stmp3xxx/pinmux.c

You're still waiting because apparantly you never sent this set anywhere near any ARM people before.

Quoted 7 lines

For the first two, I'll ack them:

The remainder look sane to me, but you'll have to seek acks from the individual platform maintainer(s).

OK, adding some more ARM people and ARM lists to get remaining ACK/NAK.

Quoted 7 lines

Patches are already posted to LKML and also available at :

http://git.kernel.org/?p=linux/kernel/git/jaswinder/headers-check-2.6.git;a=summary

In case if you are not able to find these patches let me know.

Thanks,

In behalf of mach-omap[1,2]/mcbsp.c:

Quoted 3 lines

--
JSR

Signature · 1 line
Eduardo Valentin
#80 lore raw

Hello all,

Quoted 35 lines · Eduardo Valentin
Quoted 34 lines · ext Jaswinder Singh Rajput
Quoted 19 lines · Russell King
Quoted 14 lines · Jaswinder Singh Rajput

I am still waiting ACK/NAK for :

includecheck fix: arm, misc.c includecheck fix: arm, atomic.h includecheck fix: arm, board-dm355-evm.c includecheck fix: arm, board-dm355-leopard.c includecheck fix: arm, board-dm644x-evm.c includecheck fix: arm, board-dm646x-evm.c includecheck fix: arm, board-sffsdr.c includecheck fix: arm, mach-mx3/devices.c includecheck fix: arm, mach-omap1/mcbsp.c includecheck fix: arm, mach-omap2/mcbsp.c includecheck fix: arm, plat-s3c64xx/pm.c includecheck fix: arm, plat-stmp3xxx/pinmux.c

You're still waiting because apparantly you never sent this set anywhere near any ARM people before.

Quoted 7 lines

For the first two, I'll ack them:

The remainder look sane to me, but you'll have to seek acks from the individual platform maintainer(s).

OK, adding some more ARM people and ARM lists to get remaining ACK/NAK.

Patches are already posted to LKML and also available at :

http://git.kernel.org/?p=linux/kernel/git/jaswinder/headers-check-2.6.git;a=summary

Quoted 8 lines
Quoted 3 lines

In case if you are not able to find these patches let me know.

Thanks,

In behalf of mach-omap[1,2]/mcbsp.c:

These patches are still not applied anywhere, If you want you can apply respective patch in your respective trees.

Thanks,
--
JSR

#81 lore raw
In reply to Jaswinder Singh Rajput

Hello all,

Quoted 9 lines · Jaswinder Singh Rajput

Hello all,

Quoted 6 lines · Jaswinder Singh Rajput

The following changes since commit faf80d62e44dc627efb741f48db50c1858d1667c:
Linus Torvalds (1):

        Merge branch 'x86-fixes-for-linus' of git://git.kernel.org/.../tip/linux-2.6-tip

are available in the git repository at:

Quoted 9 lines
Quoted 3 lines

git://git.kernel.org/pub/scm/linux/kernel/git/jaswinder/headers-check-2.6.git master

Jaswinder Singh Rajput (44):

This is a big patchset, so it will be better that either me or Sam will send it to Linus after collecting ACKs.

I am still waiting ACK/NAK for :

Thanks for all your ACKs and support.

Sorry guys, I give up and do not want to hear more crap from crapy people just for nothing and withdrawing pull request.

If you want, apply these patches or just trashed it.

Thanks,
--
JSR

#82 lore raw

[GIT-PULL] includecheck fixes

In reply to Jaswinder Singh Rajput

Linus,

Please pull includecheck fixes, these all are clean and safe patches with relevant Acks.

The following changes since commit 34f25476ace556263784ea2f8173e22b25557a13:
Linus Torvalds (1):
Merge branch 'fixes' of git://git.kernel.org/.../davej/cpufreq

are available in the git repository at:

git://git.kernel.org/pub/scm/linux/kernel/git/jaswinder/include-check-2.6.git master

Jaswinder Singh Rajput (42):
includecheck fix: arm, misc.c
includecheck fix: arm, atomic.h
includecheck fix: arm, board-dm355-evm.c includecheck fix: arm, board-dm355-leopard.c includecheck fix: arm, board-dm644x-evm.c includecheck fix: arm, board-dm646x-evm.c includecheck fix: arm, board-sffsdr.c includecheck fix: arm, mach-mx3/devices.c includecheck fix: arm, mach-omap1/mcbsp.c includecheck fix: arm, mach-omap2/mcbsp.c includecheck fix: arm, plat-s3c64xx/pm.c includecheck fix: arm, plat-stmp3xxx/pinmux.c includecheck fix: mn10300, sys_mn10300.c includecheck fix: s390, sys_s390.c includecheck fix: um, helper.c
includecheck fix: x86, dumpstack.c includecheck fix: x86, traps.c
includecheck fix: x86, shadow.c
includecheck fix: Documentation, cfag12864b-example.c includecheck fix: drivers/char, vt.c includecheck fix: drivers/net, sja1000.c includecheck fix: drivers/net, axnet_cs.c includecheck fix: drivers/net, smc911x.h includecheck fix: drivers/parisc, ccio-dma.c includecheck fix: drivers/scsi, libfcoe.c includecheck fix: drivers/scsi, ibmvscsi.c includecheck fix: drivers/spi, amba-pl022.c includecheck fix: drivers/staging, usbdrv.c includecheck fix: drivers/staging, rt_linux.h includecheck fix: drivers/video, vgacon.c includecheck fix: drivers/xen, evtchn.c includecheck fix: fs/xfs, xfs_iops.c includecheck fix: include/acpi, acpi_bus.h includecheck fix: include/drm, drm_memory.h includecheck fix: include/linux, aio.h includecheck fix: include/linux, ftrace.h includecheck fix: include/linux, icmpv6.h includecheck fix: include/linux, net_dropmon.h includecheck fix: include/linux, rfkill.h includecheck fix: kernel/trace, ring_buffer.c includecheck fix: mm, nommu.c
includecheck fix: mm, shmem.c

 Documentation/auxdisplay/cfag12864b-example.c |    1 -
 arch/arm/boot/compressed/misc.c               |    1 -
 arch/arm/include/asm/atomic.h                 |    2 --
 arch/arm/mach-davinci/board-dm355-evm.c       |    1 -
 arch/arm/mach-davinci/board-dm355-leopard.c   |    1 -
 arch/arm/mach-davinci/board-dm644x-evm.c      |    1 -
 arch/arm/mach-davinci/board-dm646x-evm.c      |    1 -
 arch/arm/mach-davinci/board-sffsdr.c          |    1 -
 arch/arm/mach-mx3/devices.c                   |    1 -
 arch/arm/mach-omap1/mcbsp.c                   |    1 -
 arch/arm/mach-omap2/mcbsp.c                   |    1 -
 arch/arm/plat-s3c64xx/pm.c                    |    2 --
 arch/arm/plat-stmp3xxx/pinmux.c               |    1 -
 arch/mn10300/kernel/sys_mn10300.c             |    1 -
 arch/s390/kernel/sys_s390.c                   |    1 -
 arch/um/os-Linux/helper.c                     |    1 -
 arch/x86/kernel/dumpstack.c                   |    1 -
 arch/x86/kernel/traps.c                       |    1 -
 arch/x86/mm/kmemcheck/shadow.c                |    1 -
 drivers/char/vt.c                             |    1 -
 drivers/net/can/sja1000/sja1000.c             |    1 -
 drivers/net/pcmcia/axnet_cs.c                 |    2 --
 drivers/net/smc911x.h                         |    1 -
 drivers/parisc/ccio-dma.c                     |    1 -
 drivers/scsi/fcoe/libfcoe.c                   |    1 -
 drivers/scsi/ibmvscsi/ibmvscsi.c              |    1 -
 drivers/spi/amba-pl022.c                      |    2 --
 drivers/staging/otus/usbdrv.c                 |    3 ---
 drivers/staging/rt2860/rt_linux.h             |    4 ----
 drivers/video/console/vgacon.c                |    1 -
 drivers/xen/evtchn.c                          |    1 -
 fs/xfs/linux-2.6/xfs_iops.c                   |    1 -
 include/acpi/acpi_bus.h                       |    1 -
 include/drm/drm_memory.h                      |    2 --
 include/linux/aio.h                           |    2 --
 include/linux/ftrace.h                        |    1 -
 include/linux/icmpv6.h                        |    2 --
 include/linux/net_dropmon.h                   |    1 -
 include/linux/rfkill.h                        |    1 -
 kernel/trace/ring_buffer.c                    |    2 --
 mm/nommu.c                                    |    2 --
 mm/shmem.c                                    |    1 -
 42 files changed, 0 insertions(+), 56 deletions(-)
#83 lore raw

Re: [GIT-PULL] includecheck fixes

Quoted 4 lines · Jaswinder Singh Rajput

Linus,

Please pull includecheck fixes, these all are clean and safe patches with relevant Acks.

Shouldn't stuff like this go through the trivial tree? And stuff like that is relevant for the main pre-rc1 merge, not this late in the merge cycle, right?

thanks,

greg k-h

#84 lore raw

Re: [GIT-PULL] includecheck fixes

Hello Greg,

Quoted 10 lines · Greg KH
Quoted 4 lines · Jaswinder Singh Rajput

Linus,

Please pull includecheck fixes, these all are clean and safe patches with relevant Acks.

Shouldn't stuff like this go through the trivial tree? And stuff like that is relevant for the main pre-rc1 merge, not this late in the merge cycle, right?

You did not specified what is your problem ? and where was you when we discussed it earlier ?

Normally brain is above then the eyes, do you know why ?

To use your brain instead of follow things blindly.

The point of watching patches for some time means test and wait so that they can show their real faces.

BTW, it is not late, it is not going to hit stable in next week or so.

Keeping these sane patches waiting for complete cycle will be insaner.

Thanks,
--
JSR

maintainer
#85 lore raw

Re: [GIT-PULL] includecheck fixes

Quoted 9 lines · Jaswinder Singh Rajput

Hello Greg,

Quoted 6 lines · Greg KH
Quoted 4 lines · Jaswinder Singh Rajput

Linus,

Please pull includecheck fixes, these all are clean and safe patches with relevant Acks.

Quoted 7 lines
Quoted 4 lines

Shouldn't stuff like this go through the trivial tree? And stuff like that is relevant for the main pre-rc1 merge, not this late in the merge cycle, right?

You did not specified what is your problem ? and where was you when we discussed it earlier ?

The problem, as you have been told several times, is that maintainers are very busy people and don't necessarily have time to deal with mechanical replacement trivia like this.

The point is that Jiri Kosina takes that burden on himself to verify and submit the changes like this, so something like this should go through him.

Quoted 6 lines

Normally brain is above then the eyes, do you know why ?

To use your brain instead of follow things blindly.

The point of watching patches for some time means test and wait so that they can show their real faces.

Abusing people who do real work, particularly when you manifestly do not, is a gross breach of etiquette ... welcome to my killfile.

James

#86 lore raw

Re: [GIT-PULL] includecheck fixes

Hello James,

Quoted 15 lines · James Bottomley
Quoted 14 lines · Jaswinder Singh Rajput

Hello Greg,

Quoted 10 lines · Greg KH
Quoted 4 lines · Jaswinder Singh Rajput

Linus,

Please pull includecheck fixes, these all are clean and safe patches with relevant Acks.

Shouldn't stuff like this go through the trivial tree? And stuff like that is relevant for the main pre-rc1 merge, not this late in the merge cycle, right?

Quoted 7 lines
Quoted 2 lines

You did not specified what is your problem ? and where was you when we discussed it earlier ?

The problem, as you have been told several times, is that maintainers are very busy people and don't necessarily have time to deal with mechanical replacement trivia like this.

Am I asking you ?

If you are very busy and not able to handle things properly, so better quit the maintainer-ship. Others can handle more better than you.

Quoted 4 lines

The point is that Jiri Kosina takes that burden on himself to verify and submit the changes like this, so something like this should go through him.

Who will take burden of Jiri, I already send another PULL request to Jiri.

Quoted 10 lines
Quoted 6 lines

Normally brain is above then the eyes, do you know why ?

To use your brain instead of follow things blindly.

The point of watching patches for some time means test and wait so that they can show their real faces.

Abusing people who do real work, particularly when you manifestly do not, is a gross breach of etiquette ... welcome to my killfile.

So what you mean, you can do any crap and no one can blame you ... welcome to my killknife.

--
JSR

#87 lore raw

Re: [GIT-PULL] includecheck fixes

Quoted 5 lines · Jaswinder Singh Rajput
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 2 lines

Please pull includecheck fixes, these all are clean and safe patches with relevant Acks.

Shouldn't stuff like this go through the trivial tree? And stuff like that is relevant for the main pre-rc1 merge, not this late in the merge cycle, right?

Quoted 8 lines
Quoted 5 lines
Quoted 2 lines

You did not specified what is your problem ? and where was you when we discussed it earlier ?

The problem, as you have been told several times, is that maintainers are very busy people and don't necessarily have time to deal with mechanical replacement trivia like this.

Am I asking you ? If you are very busy and not able to handle things properly, so better quit the maintainer-ship. Others can handle more better than you.

Come on Jaswinder ... trivial grammar/typo fixes are really not that important stuff to argue about in longish threads. Let's rather find a more interesting and important topic to flame each other about :) This is really not worth it.

Quoted 5 lines
Quoted 3 lines

The point is that Jiri Kosina takes that burden on himself to verify and submit the changes like this, so something like this should go through him.

Who will take burden of Jiri, I already send another PULL request to Jiri.

If you mean the "foo foo" replacement request, the repository you asked me to pull from doesn't seem to have any extra patches on top of current tree, so I guess you forgot to push.

Also you can't expect that I react to trivial patches very promptly. There are a lot of more urgent things that I am taking care of, this is just an "add-on".

Thanks,

Signature · 2 lines
Jiri Kosina
SUSE Labs
#88 lore raw

Re: [GIT-PULL] includecheck fixes

In reply to Jaswinder Singh Rajput
Quoted 9 lines · Jaswinder Singh Rajput

Hello Greg,

Quoted 6 lines · Greg KH
Quoted 4 lines · Jaswinder Singh Rajput

Linus,

Please pull includecheck fixes, these all are clean and safe patches with relevant Acks.

Quoted 7 lines
Quoted 4 lines

Shouldn't stuff like this go through the trivial tree? And stuff like that is relevant for the main pre-rc1 merge, not this late in the merge cycle, right?

You did not specified what is your problem ? and where was you when we discussed it earlier ?

Earlier when? I responded to your query about the individual patches you copied me on, saying they were in my "to-apply" queue and I didn't want them to go to Linus at this point in time. You seem quite rushed about these patches, which is odd to me.

Quoted 6 lines

Normally brain is above then the eyes, do you know why ?

To use your brain instead of follow things blindly.

The point of watching patches for some time means test and wait so that they can show their real faces.

Which is what I am asking you to do here. So why are you arguing with this concept?

Quoted 3 lines

BTW, it is not late, it is not going to hit stable in next week or so.

Keeping these sane patches waiting for complete cycle will be insaner.

Accepting trivial patches like these, for which a full build cycle of all arches has yet to be accomplished due to a lack of inclusion in the -next tree, at a point in the development series in which bug fixes and regressions are the only thing to be accepted, seems to be a risk, don't you think?

But hey, I'm not Linus, it's up to him to decide to take untested stuff like this or not, not me :)

best of luck,

greg k-h

#89 lore raw

Re: [GIT-PULL] includecheck fixes

Quoted 15 lines · Greg KH
Quoted 14 lines · Jaswinder Singh Rajput

Hello Greg,

Quoted 10 lines · Greg KH
Quoted 4 lines · Jaswinder Singh Rajput

Linus,

Please pull includecheck fixes, these all are clean and safe patches with relevant Acks.

Shouldn't stuff like this go through the trivial tree? And stuff like that is relevant for the main pre-rc1 merge, not this late in the merge cycle, right?

Quoted 4 lines
Quoted 2 lines

You did not specified what is your problem ? and where was you when we discussed it earlier ?

Earlier when?

Check LKML emails of this thread, I have send half-dozen of emails to you earlier.

Thanks,
--
JSR