Skip to contentSkip to conversation

arm/kirkwood: Add Keymile SUEN3 support

PATCH New Stefan Roese 3 participants 5 messages Jul 8, 2009 – Jul 9, 2009 Kbuild

lore
Share & tools
lore
#0 lore raw

PATCH 4/4 arm/kirkwood: Add Keymile SUEN3 support

This patch adds support for the Keymile SUEN3 board which is based on the Marvell Kirkwood (88F6281) SoC.

Cc Jean-Christophe PLAGNIOL-VILLARD <[email protected]>
---
 MAINTAINERS                       |    1 +
 MAKEALL                           |    1 +
 Makefile                          |    3 +
 board/keymile/suen3/Makefile      |   51 +++++++++
 board/keymile/suen3/config.mk     |   25 ++++
 board/keymile/suen3/sdramregs.txt |   28 +++++
 board/keymile/suen3/suen3.c       |  127 +++++++++++++++++++++
 include/configs/suen3.h           |  221 +++++++++++++++++++++++++++++++++++++
 8 files changed, 457 insertions(+), 0 deletions(-)
 create mode 100644 board/keymile/suen3/Makefile
 create mode 100644 board/keymile/suen3/config.mk
 create mode 100644 board/keymile/suen3/sdramregs.txt
 create mode 100644 board/keymile/suen3/suen3.c
 create mode 100644 include/configs/suen3.h
MAINTAINERS +1 -0
index 705bac5..ce117e1 100644
@@ -637,6 +637,7 @@ Stefan Roese <[email protected]>
 	ixdpg425	xscale
 	pdnb3		xscale
 	scpu		xscale
+	suen3		ARM926EJS (Kirkwood SoC)
 
 Alessandro Rubini <[email protected]>
 Nomadik Linux Team <[email protected]>
MAKEALL +1 -0
index 41f1445..6c80694 100755
@@ -524,6 +524,7 @@ LIST_ARM9="			\
 	scb9328			\
 	smdk2400		\
 	smdk2410		\
+	suen3			\
 	trab			\
 	VCMA9			\
 	versatile		\
Makefile +3 -0
index 2a06440..3afc4ba 100644
@@ -2925,6 +2925,9 @@ smdk2400_config	:	unconfig
 smdk2410_config	:	unconfig
 	@$(MKCONFIG) $(@:_config=) arm arm920t smdk2410 samsung s3c24x0
 
+suen3_config: unconfig
+	@$(MKCONFIG) $(@:_config=) arm arm926ejs $(@:_config=) keymile kirkwood
+
 SX1_stdout_serial_config \
 SX1_config:		unconfig
 	@mkdir -p $(obj)include
board/keymile/suen3/Makefile new file +51 -0

51 lines not on this page · raw message

board/keymile/suen3/config.mk new file +25 -0
new file mode 100644
index 0000000..fb29a1b
@@ -0,0 +1,25 @@
+#
+# (C) Copyright 2009
+# Marvell Semiconductor <www.marvell.com>
+# Prafulla Wadaskar <[email protected]>
+#
+# See file CREDITS for list of people who contributed to this
+# project.
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License as
+# published by the Free Software Foundation; either version 2 of
+# the License, or (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston,
+# MA 02110-1301 USA
+#
+
+TEXT_BASE = 0x00600000
board/keymile/suen3/sdramregs.txt new file +28 -0
new file mode 100644
index 0000000..74abb20
@@ -0,0 +1,28 @@
+0xFFD10000 0x01111111
+0xFFD10008 0x00001100
+0xFFD100E0 0x1B1B1B1B
+0xFFD20134 0xBBBBBBBB
+0xFFD20138 0x00BBBBBB
+0xFFD20154 0x00000200
+0xFFD2014C 0x00001C00
+0xFFD20148 0x00000001
+0xFFD01400 0x43000400
+0xFFD01404 0x36343000
+0xFFD01408 0x2302544B
+0xFFD0140C 0x00000032
+0xFFD01410 0x0000000D
+0xFFD01414 0x00000000
+0xFFD01418 0x00000000
+0xFFD0141C 0x00000642
+0xFFD01420 0x00000040
+0xFFD01424 0x0000F07F
+0xFFD01504 0x07FFFFF1
+0xFFD01508 0x00000000
+0xFFD0150C 0x00000000
+0xFFD01514 0x00000000
+0xFFD0151C 0x00000000
+0xFFD01494 0x00000000
+0xFFD01498 0x00000000
+0xFFD0149C 0x0000E90F
+0xFFD01480 0x00000001
+0x0 0x0
board/keymile/suen3/suen3.c new file +127 -0

127 lines not on this page · raw message

include/configs/suen3.h new file +221 -0

221 lines not on this page · raw message

Signature · 1 line
1.6.3.3
#1 lore raw

PATCH 4/4 arm/kirkwood: Add Keymile SUEN3 support

Please disregard the "4/4" above. It's only one patch.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
=====================================================================

#2 lore raw

PATCH 4/4 arm/kirkwood: Add Keymile SUEN3 support

In reply to Stefan Roese

Dear Stefan Roese,

Quoted 2 lines · In message <[email protected]> you wrote:

This patch adds support for the Keymile SUEN3 board which is based on the Marvell Kirkwood (88F6281) SoC.

...

MAKEALL LIST_ARM9=" \ · line 530

Quoted 12 lines
MAKEALL +1 -0
index 41f1445..6c80694 100755
@@ -524,6 +524,7 @@ LIST_ARM9="			\
 	scb9328			\
 	smdk2400		\
 	smdk2410		\
+	suen3			\
 	trab			\
 	VCMA9			\
 	versatile		\

This is the ARM9 list. Are you sure the board belongs there?

Makefile smdk2400_config : unconfig · line 2930

Quoted 11 lines
Makefile +3 -0
index 2a06440..3afc4ba 100644
@@ -2925,6 +2925,9 @@ smdk2400_config	:	unconfig
 smdk2410_config	:	unconfig
 	@$(MKCONFIG) $(@:_config=) arm arm920t smdk2410 samsung s3c24x0
 
+suen3_config: unconfig
+	@$(MKCONFIG) $(@:_config=) arm arm926ejs $(@:_config=) keymile kirkwood
+

This is the ARM9xxx section. Are you sure the board belongs there?

...

Quoted 6 lines
board/keymile/suen3/suen3.c new file +0 -0
new file mode 100644
index 0000000..231745f
@@ -0,0 +1,127 @@

...

board/keymile/suen3/suen3.c line 115

Quoted 10 lines
board/keymile/suen3/suen3.c new file +10 -0
+int dram_init(void)
+{
+	int i;
+
+	for (i = 0; i < CONFIG_NR_DRAM_BANKS; i++) {
+		gd->bd->bi_dram[i].start = kw_sdram_bar(i);
+		gd->bd->bi_dram[i].size = kw_sdram_bs(i);
+	}
+	return 0;
+}

Maybe we can have get_ram_size() support with auto-sizing and testing here?

Quoted 5 lines
include/configs/suen3.h new file +0 -0
new file mode 100644
index 0000000..1b971e0

...

include/configs/suen3.h

Quoted 6 lines
include/configs/suen3.h new file +6 -0
+#define CONFIG_EXTRA_ENV_SETTINGS					\
+	"load=tftp 400000 suen3/u-boot.bin\0"				\
+	"update=nand erase 0 60000;nand write 400000 0 60000\0"		\
+	"upd=run load update\0"						\
+	"mtdparts=orion_nand:512k(uboot),512k at 512k(env),"		\
+		"2m at 1m(kernel),13m at 3m(rootfs)\0"			\

^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
...

include/configs/suen3.h line 219

Quoted 6 lines
include/configs/suen3.h new file +6 -0
+#define MTDPARTS_DEFAULT	"mtdparts=orion_nand:512k(u-boot),"	\
+					"256k(env),"		\
+					"2m(kernel),"		\
+					"16m(rootfs),"		\
+					"32m(fs),"		\
+					"-(ubifs)"

This seems inconsistent to me. How about defining MTDPARTS_DEFAULT first, and then just inserting the already defined value, so you can be sure that this doesn;t happen again?

Best regards,

Wolfgang Denk

Signature · 6 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
On the subject of C program indentation: "In My Egotistical  Opinion,
most  people's  C  programs  should be indented six feet downward and
covered with dirt."                               - Blair P. Houghton
#3 lore raw

PATCH 4/4 arm/kirkwood: Add Keymile SUEN3 support

Hi Wolfgang,

Quoted 6 lines · On Wednesday 08 July 2009 20:53:58 Wolfgang Denk wrote:
Quoted 6 lines
MAKEALL +0 -0
index 41f1445..6c80694 100755
@@ -524,6 +524,7 @@ LIST_ARM9="			\
 	scb9328			\
Quoted 8 lines

MAKEALL LIST_ARM9=" \ · line 530

Quoted 6 lines
MAKEALL +1 -0
 	smdk2400		\
 	smdk2410		\
+	suen3			\
 	trab			\
 	VCMA9			\
 	versatile		\

This is the ARM9 list. Are you sure the board belongs there?

It's using the U-Boot ARM926EJS infrastructure (ARMv5TE). Which the board in this list seem to be using as well. So yes, I guess the board belongs here.

Quoted 8 lines
Quoted 8 lines
Makefile +0 -0
index 2a06440..3afc4ba 100644
@@ -2925,6 +2925,9 @@ smdk2400_config	:	unconfig
 smdk2410_config	:	unconfig
 	@$(MKCONFIG) $(@:_config=) arm arm920t smdk2410 samsung s3c24x0
 
Quoted 5 lines

Makefile smdk2400_config : unconfig · line 2930

Quoted 3 lines
Makefile +3 -0
+suen3_config: unconfig
+	@$(MKCONFIG) $(@:_config=) arm arm926ejs $(@:_config=) keymile kirkwood
+

This is the ARM9xxx section. Are you sure the board belongs there?

Yes.

Quoted 9 lines
Quoted 6 lines
board/keymile/suen3/suen3.c new file +0 -0
new file mode 100644
index 0000000..231745f
@@ -0,0 +1,127 @@

..

Quoted 13 lines

board/keymile/suen3/suen3.c line 115

Quoted 10 lines
board/keymile/suen3/suen3.c new file +10 -0
+int dram_init(void)
+{
+	int i;
+
+	for (i = 0; i < CONFIG_NR_DRAM_BANKS; i++) {
+		gd->bd->bi_dram[i].start = kw_sdram_bar(i);
+		gd->bd->bi_dram[i].size = kw_sdram_bs(i);
+	}
+	return 0;
+}

Maybe we can have get_ram_size() support with auto-sizing and testing here?

OK, I'll will change it.

Quoted 18 lines
Quoted 5 lines
include/configs/suen3.h new file +0 -0
new file mode 100644
index 0000000..1b971e0

..

include/configs/suen3.h

Quoted 6 lines
include/configs/suen3.h new file +6 -0
+#define CONFIG_EXTRA_ENV_SETTINGS					\
+	"load=tftp 400000 suen3/u-boot.bin\0"				\
+	"update=nand erase 0 60000;nand write 400000 0 60000\0"		\
+	"upd=run load update\0"						\
+	"mtdparts=orion_nand:512k(uboot),512k at 512k(env),"		\
+		"2m at 1m(kernel),13m at 3m(rootfs)\0"			\

^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ..

Quoted 10 lines

include/configs/suen3.h line 219

Quoted 6 lines
include/configs/suen3.h new file +6 -0
+#define MTDPARTS_DEFAULT	"mtdparts=orion_nand:512k(u-boot),"	\
+					"256k(env),"		\
+					"2m(kernel),"		\
+					"16m(rootfs),"		\
+					"32m(fs),"		\
+					"-(ubifs)"

This seems inconsistent to me. How about defining MTDPARTS_DEFAULT first, and then just inserting the already defined value, so you can be sure that this doesn;t happen again?

Yes, good catch. Will change. Thanks for spotting.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
=====================================================================

#4 lore raw

PATCH 4/4 arm/kirkwood: Add Keymile SUEN3 support

Hello Stefan,

Quoted 5 lines · Stefan Roese
Quoted 4 lines · On Wednesday 08 July 2009 20:53:58 Wolfgang Denk wrote:
Quoted 4 lines
MAKEALL +0 -0
index 41f1445..6c80694 100755

[...]

Quoted 19 lines
Quoted 9 lines

MAKEALL

Quoted 6 lines
MAKEALL +6 -0
+#define CONFIG_EXTRA_ENV_SETTINGS					\
+	"load=tftp 400000 suen3/u-boot.bin\0"				\
+	"update=nand erase 0 60000;nand write 400000 0 60000\0"		\
+	"upd=run load update\0"						\
+	"mtdparts=orion_nand:512k(uboot),512k at 512k(env),"		\
+		"2m at 1m(kernel),13m at 3m(rootfs)\0"			\

^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ..

Quoted 9 lines

MAKEALL

Quoted 6 lines
MAKEALL +6 -0
+#define MTDPARTS_DEFAULT	"mtdparts=orion_nand:512k(u-boot),"	\
+					"256k(env),"		\
+					"2m(kernel),"		\
+					"16m(rootfs),"		\
+					"32m(fs),"		\
+					"-(ubifs)"

This seems inconsistent to me. How about defining MTDPARTS_DEFAULT first, and then just inserting the already defined value, so you can be sure that this doesn;t happen again?

Quoted 1 line

Yes, good catch. Will change. Thanks for spotting.

Maybe you have a look at:

include/configs/km8xx.h

for an example.

bye
Heiko

Signature · 2 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany