Skip to contentSkip to conversation

Check write to slab memory which freed already using mudflap v2

RFC PATCH In review Janboe Ye 2 participants 2 messages Jul 9, 2009 – Jul 10, 2009

Subsystems (5)
lore
Share & tools
lore

Janboe Ye

author
#0 lore raw

RFC PATCH 1/1 Check write to slab memory which freed already using mudflap v2

Hi

slab debug detects the corruption when it allocates and frees the slab. But if someone write to slab memory when it already freed, slab debug could only report its last free point when slab allocates the same block.

This information is not enough for debugging when system has complex memory usage. gcc mudflap could insert some check point when a memory is writing and it is helpful to check if the address is writing freed.

Because most codes of kernel are drivers, it is most possible that drivers have such problem. So I use mudflap to compile all drivers.

kmemcheck is also helpful to check same issue, and it triggers trap every reading and writing, and it need to analysis the instruct which trigger the trap to get the memory address. This heavy depends on the cpu capability. arm has no single-step like x86, so kmemcheck is too heavy to run on real arm system. mudflap way is lighter than kmemcheck for this purpose.

As stack allocation is useless for checking slab, kernel mudflap does not implement alloc which is required by gcc mudflap when codes use variable array. So variable array, such as array[i] which i could not determined by compiler, is not supported.

Note: gcc 4.1.2 generates a wrong code in kbd_init of drivers/char/keyboard.c when use mudflap flag. Version 4.2 and 4.3 are ok.

mudflap link: http://gcc.gnu.org/wiki/Mudflap_Pointer_Debugging

Changeslong:
V2: add slub support according to Pekka Enberg comments
V1: add mudflap core and slab support

Thanks a lot for comments!

 arch/arm/include/asm/elf.h |    1 +
 arch/arm/kernel/module.c   |    1 +
 drivers/Makefile           |    4 +-
 include/mf-runtime.h       |   49 ++++++++++++++++
 kernel/Makefile            |    2 +-
 kernel/mudflap.c           |  132 ++++++++++++++++++++++++++++++++++++++++++++
 lib/Kconfig.debug          |    7 ++
 mm/slab.c                  |   38 +++++++++++++
 mm/slub.c                  |   29 ++++++++++
 9 files changed, 261 insertions(+), 2 deletions(-)
arch/arm/include/asm/elf.h +1 -0
index c207504..30cb4b7 100644
@@ -50,6 +50,7 @@ typedef struct user_fp elf_fpregset_t;
 #define R_ARM_ABS32		2
 #define R_ARM_CALL		28
 #define R_ARM_JUMP24		29
+#define R_ARM_TARGET1		38
 #define R_ARM_V4BX		40
 #define R_ARM_PREL31		42
 #define R_ARM_MOVW_ABS_NC	43
arch/arm/kernel/module.c +1 -0
index bac03c8..8cfe5f5 100644
@@ -128,6 +128,7 @@ apply_relocate(Elf32_Shdr *sechdrs, const char *strtab, unsigned int symindex,
 			break;
 
 		case R_ARM_ABS32:
+		case R_ARM_TARGET1:
 			*(u32 *)loc += sym->st_value;
 			break;
 
drivers/Makefile +3 -1
index bc4205d..d5e5063 100644
@@ -4,7 +4,9 @@
 # 15 Sep 2000, Christoph Hellwig <[email protected]>
 # Rewritten to use lists instead of if-statements.
 #
-
+ifdef CONFIG_MUDFLAP
+subdir-ccflags-y += -fmudflap -fmudflapir
+endif
 obj-y				+= gpio/
 obj-$(CONFIG_PCI)		+= pci/
 obj-$(CONFIG_PARISC)		+= parisc/
include/mf-runtime.h new file +49 -0

49 lines not on this page · raw message

kernel/Makefile +1 -1
index 2093a69..c4c2402 100644
@@ -22,7 +22,7 @@ CFLAGS_REMOVE_rtmutex-debug.o = -pg
 CFLAGS_REMOVE_cgroup-debug.o = -pg
 CFLAGS_REMOVE_sched_clock.o = -pg
 endif
-
+obj-$(CONFIG_MUDFLAP) += mudflap.o
 obj-$(CONFIG_FREEZER) += freezer.o
 obj-$(CONFIG_PROFILING) += profile.o
 obj-$(CONFIG_SYSCTL_SYSCALL_CHECK) += sysctl_check.o
kernel/mudflap.c new file +132 -0

132 lines not on this page · raw message

lib/Kconfig.debug +7 -0
index 12327b2..5e1f7ff 100644
@@ -35,6 +35,13 @@ config FRAME_WARN
 	  Setting this too low will cause a lot of warnings.
 	  Setting it to 0 disables the warning.
 	  Requires gcc 4.4
+config MUDFLAP
+	bool "Enable mudflap to check slab write after free"
+	depends on DEBUG_SLAB_LEAK || SLUB_DEBUG_ON
+	help
+	  This uses mudflap which introduced by gcc4 to check slab corruption
+	  which is caused by writing after free.
+	  This is smaller and faster than kmemcheck.
 
 config MAGIC_SYSRQ
 	bool "Magic SysRq key"
mm/slab.c +38 -0
index 7b5d4de..f4433d4 100644
@@ -4503,3 +4503,41 @@ size_t ksize(const void *objp)
 	return obj_size(virt_to_cache(objp));
 }
 EXPORT_SYMBOL(ksize);
+
+#ifdef CONFIG_MUDFLAP
+void check_slab_write(void *ptr, unsigned int sz, const char *location)
+{
+	struct page *page;
+	struct kmem_cache *cachep;
+	struct slab *slabp;
+	char *realobj;
+	void *objp;
+	int objnr, size;
+
+	page = virt_to_head_page(ptr);
+	if (!PageSlab(page))
+		return;
+
+	cachep = page_get_cache(page);
+	slabp = page_get_slab(page);
+	objnr = (unsigned)(ptr - slabp->s_mem) / cachep->buffer_size;
+	objp = index_to_obj(cachep, slabp, objnr);
+	realobj = (char *)objp + obj_offset(cachep);
+	size = obj_size(cachep);
+	if (slab_bufctl(slabp)[objnr] == BUFCTL_FREE) {
+		printk(KERN_ERR "ptr: %p, sz: %d, location: %s\n",
+				ptr, sz, location);
+		printk(KERN_ERR "write to freed object, size %d\n",
+				size);
+		if (cachep->flags & SLAB_STORE_USER) {
+			printk(KERN_ERR "Last user: [<%p>]",
+					*dbg_userword(cachep, objp));
+			print_symbol("(%s)",
+				(unsigned long)*dbg_userword(cachep, objp));
+			printk("\n");
+		}
+
+		dump_stack();
+	}
+}
+#endif
mm/slub.c +29 -0
index a9201d8..b3fdd93 100644
@@ -4729,3 +4729,32 @@ static int __init slab_proc_init(void)
 }
 module_init(slab_proc_init);
 #endif /* CONFIG_SLABINFO */
+
+#ifdef CONFIG_MUDFLAP
+void check_slab_write(void *ptr, unsigned int sz, const char *location)
+{
+	struct page *page;
+	struct kmem_cache *cachep;
+	struct slab *slabp;
+	char *realobj;
+	void *objp, *start;
+	int objnr, size;
+
+	page = virt_to_head_page(ptr);
+	if (!PageSlab(page))
+		return;
+
+	cachep = page->slab;
+	start = page_address(page);
+	objnr = (unsigned)(ptr - start) / cachep->size;
+	objp = start + cachep->size * objnr;
+	if (on_freelist(cachep, page, objp)) {
+		printk(KERN_ERR "ptr: %p, sz: %d, location: %s\n",
+				ptr, sz, location);
+		printk(KERN_ERR "write to freed object, size %d\n",
+				cachep->size);
+		print_tracking(cachep, objp);
+		dump_stack();
+	}
+}
+#endif
#1 lore raw

Hi Janboe!

include/mf-runtime.h line 26

Quoted 5 lines · Janboe Ye
include/mf-runtime.h new file +5 -0
+#include<linux/kernel.h>
+
+#define LOOKUP_CACHE_MASK_DFL 1023
+#define LOOKUP_CACHE_SIZE_MAX 65536 /* Allows max CACHE_MASK 0xFFFF */
+#define LOOKUP_CACHE_SHIFT_DFL 2

These are probably too generic names if this is going to be included by default. Maybe you could just add a KMUDFLAP prefix or something?

Quoted 58 lines
include/mf-runtime.h new file +23 -0
+
+typedef void *__mf_ptr_t;
+typedef unsigned int __mf_uintptr_t;
+struct __mf_cache { __mf_uintptr_t low; __mf_uintptr_t high; };
+
+void __mf_check(void *ptr, unsigned int sz, int type, const char *location);
+void __mf_register(void *ptr, size_t sz, int type, const char *name);
+void __mf_init(void);
+void __mf_unregister(void *ptr, size_t sz, int type);
+
+#ifdef _MUDFLAP
+#pragma redefine_extname memcpy __mfwrap_memcpy
+#pragma redefine_extname memset __mfwrap_memset
+#pragma redefine_extname strcpy __mfwrap_strcpy
+#pragma redefine_extname strncpy __mfwrap_strncpy
+
+#ifdef CONFIG_ARM
+#pragma redefine_extname __memzero __mfwrap_memzero
+#endif
+
+#endif /* _MUDFLAP */
+
+#endif
kernel/Makefile +1 -1
index 2093a69..c4c2402 100644
@@ -22,7 +22,7 @@ CFLAGS_REMOVE_rtmutex-debug.o = -pg
 CFLAGS_REMOVE_cgroup-debug.o = -pg
 CFLAGS_REMOVE_sched_clock.o = -pg
 endif
-
+obj-$(CONFIG_MUDFLAP) += mudflap.o
 obj-$(CONFIG_FREEZER) += freezer.o
 obj-$(CONFIG_PROFILING) += profile.o
 obj-$(CONFIG_SYSCTL_SYSCALL_CHECK) += sysctl_check.o
kernel/mudflap.c new file +16 -0
new file mode 100644
index 0000000..5734dff
@@ -0,0 +1,132 @@
+/*
+ * kernel/mudflap.c
+ *
+ * Copyright (C) 2009 Motorola Inc.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ * General Public License for more details.
+ */
+
+#include<linux/kernel.h>

kernel/mudflap.c line 26

Quoted 10 lines
kernel/mudflap.c new file +10 -0
+#include<linux/slab.h>
+#include<linux/module.h>
+#include<linux/mm.h>
+#undef DEBUG
+
+#ifdef DEBUG
+#define DPRINTK(fmt, args...) printk(fmt, ## args)
+#else
+#define DPRINTK(fmt, args...)
+#endif

This is core kernel code so this DEBUG thing needs to go. Check the previous email for suggestions how to do it.

kernel/mudflap.c line 38

Quoted 12 lines
kernel/mudflap.c new file +12 -0
+
+/* Codes to describe the type of access to check */
+#define __MF_CHECK_READ 0
+#define __MF_CHECK_WRITE 1
+
+typedef void *__mf_ptr_t;
+typedef unsigned int __mf_uintptr_t;
+struct __mf_cache { __mf_uintptr_t low; __mf_uintptr_t high; };
+
+#define LOOKUP_CACHE_MASK_DFL 1023
+#define LOOKUP_CACHE_SIZE_MAX 65536 /* Allows max CACHE_MASK 0xFFFF */
+#define LOOKUP_CACHE_SHIFT_DFL 2

Why are we redefining these here?

kernel/mudflap.c line 49

Quoted 11 lines
kernel/mudflap.c new file +11 -0
+
+struct __mf_cache __mf_lookup_cache[LOOKUP_CACHE_SIZE_MAX];
+EXPORT_SYMBOL(__mf_lookup_cache);
+
+uintptr_t __mf_lc_mask = LOOKUP_CACHE_MASK_DFL;
+EXPORT_SYMBOL(__mf_lc_mask);
+
+unsigned char __mf_lc_shift = LOOKUP_CACHE_SHIFT_DFL;
+EXPORT_SYMBOL(__mf_lc_shift);
+
+void check_slab_write(void *ptr, unsigned int sz, const char *location);

This needs to go into <linux/slab_def.h> and <linux/slub_def.h> and probably renamed to "slab_check_write()"

kernel/mudflap.c line 54

Quoted 4 lines
kernel/mudflap.c new file +4 -0
+static inline int verify_ptr(unsigned long ptr)
+{
+	if (ptr < PAGE_OFFSET ||
+		(ptr > (unsigned long)high_memory && high_memory != 0))

s/0/NULL/

kernel/mudflap.c line 58

Quoted 4 lines
kernel/mudflap.c new file +4 -0
+		return -EFAULT;
+
+	return 0;
+}

OTOH, can't we use virt_addr_valid() instead? It should be safe to do virt_to_head_page() if it passes and the PageSlab check in check_slab_write() will take care of the rest.

Furthermore, you could just move all this processing to check_slab_write() and nuke verity_ptr() completely.

kernel/mudflap.c line 69

Quoted 11 lines
kernel/mudflap.c new file +11 -0
+
+void __mf_check(void *ptr, unsigned int sz, int type, const char *location)
+{
+	if (verify_ptr((unsigned long)ptr))
+		return;
+	if (type) /* write */
+		check_slab_write(ptr, sz, location);
+}
+EXPORT_SYMBOL(__mf_check);
+
+void *__mfwrap_memset(void *s, int c, size_t count)

Is the __mfwrap prefix mandated by mudflap? Can we use kmudflap or similar instead?

Quoted 20 lines
kernel/mudflap.c new file +20 -0
+{
+	__mf_check(s, count, __MF_CHECK_WRITE, "memset dest");
+	return memset(s, c, count);
+}
+EXPORT_SYMBOL(__mfwrap_memset);
+
+void *__mfwrap_memcpy(void *dest, const void *src, size_t count)
+{
+	__mf_check(dest, count, __MF_CHECK_WRITE, "memcpy dest");
+	return memcpy(dest, src, count);
+}
+EXPORT_SYMBOL(__mfwrap_memcpy);
+
+char *__mfwrap_strcpy(char *dest, const char *src)
+{
+	size_t n = strlen(src);
+	 __mf_check(dest, n, __MF_CHECK_WRITE, "strcpy dest");
+	return strcpy(dest, src);
+}
+EXPORT_SYMBOL(__mfwrap_strcpy);

kernel/mudflap.c line 99

Quoted 10 lines
kernel/mudflap.c new file +10 -0
+
+void *__mfwrap_strncpy(char *dest, const char *src, size_t count)
+{
+	size_t len = strnlen(src, count);
+	 __mf_check(dest, len, __MF_CHECK_WRITE, "strncpy dest");
+	return strncpy(dest, src, count);
+}
+EXPORT_SYMBOL(__mfwrap_strncpy);
+
+#ifdef CONFIG_ARM

Like I said, this doesn't really belong into generic kernel code. Can we just move this function under arch/arm/kernel?

Quoted 38 lines
kernel/mudflap.c new file +33 -0
+void __mfwrap_memzero(void *ptr, __kernel_size_t n)
+{
+	__mf_check(ptr, n, __MF_CHECK_WRITE, "memzero dest");
+	return __memzero(ptr, n);
+}
+EXPORT_SYMBOL(__mfwrap_memzero);
+#endif
+
+void
+__mf_register(void *ptr, size_t sz, int type, const char *name)
+{
+	DPRINTK("ptr: %p, sz: %d, type: %d, %s\n", ptr, sz, type, name);
+}
+EXPORT_SYMBOL(__mf_register);
+
+void
+__mf_unregister(void *ptr, size_t sz, int type)
+{
+	DPRINTK("ptr: %p, sz: %d, type: %d\n", ptr, sz, type);
+}
+EXPORT_SYMBOL(__mf_unregister);
+
+void __mf_init(void)
+{
+}
+EXPORT_SYMBOL(__mf_init);
+
+int
+__mf_set_options(const char *optstr)
+{
+	return 0;
+}
+EXPORT_SYMBOL(__mf_set_options);
mm/slab.c +0 -0
index 7b5d4de..f4433d4 100644

mm/slab.c size_t ksize(const void *objp) · line 4508

Quoted 6 lines
mm/slab.c +3 -0
@@ -4503,3 +4503,41 @@ size_t ksize(const void *objp)
 	return obj_size(virt_to_cache(objp));
 }
 EXPORT_SYMBOL(ksize);
+
+#ifdef CONFIG_MUDFLAP
+void check_slab_write(void *ptr, unsigned int sz, const char *location)

s/sz/size/ and use size_t

mm/slab.c size_t ksize(const void *objp) · line 4515

Quoted 7 lines
mm/slab.c +7 -0
+{
+	struct page *page;
+	struct kmem_cache *cachep;
+	struct slab *slabp;
+	char *realobj;
+	void *objp;
+	int objnr, size;

s/cachep/cache/ and same for slabp and objp too, please.

mm/slab.c size_t ksize(const void *objp) · line 4523

Quoted 8 lines
mm/slab.c +8 -0
+
+	page = virt_to_head_page(ptr);
+	if (!PageSlab(page))
+		return;
+
+	cachep = page_get_cache(page);
+	slabp = page_get_slab(page);
+	objnr = (unsigned)(ptr - slabp->s_mem) / cachep->buffer_size;

Cast to unsigned long and make obnr unsigned long too?

mm/slab.c size_t ksize(const void *objp) · line 4525

Quoted 2 lines
mm/slab.c +2 -0
+	objp = index_to_obj(cachep, slabp, objnr);
+	realobj = (char *)objp + obj_offset(cachep);

The char pointer casting looks unnecessary here.

mm/slab.c size_t ksize(const void *objp) · line 4527

Quoted 2 lines
mm/slab.c +2 -0
+	size = obj_size(cachep);
+	if (slab_bufctl(slabp)[objnr] == BUFCTL_FREE) {

You could do:

if (slab_bufctl(slabp)[objnr] != BUFCTL_FREE)

          return;

to reduce nesting here.

mm/slab.c size_t ksize(const void *objp) · line 4538

Quoted 11 lines
mm/slab.c +11 -0
+		printk(KERN_ERR "ptr: %p, sz: %d, location: %s\n",
+				ptr, sz, location);
+		printk(KERN_ERR "write to freed object, size %d\n",
+				size);
+		if (cachep->flags & SLAB_STORE_USER) {
+			printk(KERN_ERR "Last user: [<%p>]",
+					*dbg_userword(cachep, objp));
+			print_symbol("(%s)",
+				(unsigned long)*dbg_userword(cachep, objp));
+			printk("\n");
+		}

It would be nice to clean this up a bit. See below for comments on how to do it for SLUB.

mm/slab.c size_t ksize(const void *objp) · line 4542

Quoted 4 lines
mm/slab.c +4 -0
+
+		dump_stack();
+	}
+}

don't we need

  EXPORT_SYMBOL(check_slab_write);

here?

mm/slub.c static int __init slab_proc_init(void) · line 4735

Quoted 13 lines
mm/slab.c +1 -0
+#endif
mm/slub.c +4 -0
index a9201d8..b3fdd93 100644
@@ -4729,3 +4729,32 @@ static int __init slab_proc_init(void)
 }
 module_init(slab_proc_init);
 #endif /* CONFIG_SLABINFO */
+
+#ifdef CONFIG_MUDFLAP
+void check_slab_write(void *ptr, unsigned int sz, const char *location)
+{

s/sz/size/g and use size_t

mm/slub.c static int __init slab_proc_init(void) · line 4737

Quoted 2 lines
mm/slub.c +2 -0
+	struct page *page;
+	struct kmem_cache *cachep;

struct kmem_cache *s;

please

mm/slub.c static int __init slab_proc_init(void) · line 4738

Quoted 1 line
mm/slub.c +1 -0
+	struct slab *slabp;

Hmm? SLUB has no "struct slab"

mm/slub.c static int __init slab_proc_init(void) · line 4740

Quoted 2 lines
mm/slub.c +2 -0
+	char *realobj;
+	void *objp, *start;

s/objp/obj/

mm/slub.c static int __init slab_proc_init(void) · line 4749

Quoted 9 lines
mm/slub.c +9 -0
+	int objnr, size;
+
+	page = virt_to_head_page(ptr);
+	if (!PageSlab(page))
+		return;
+
+	cachep = page->slab;
+	start = page_address(page);
+	objnr = (unsigned)(ptr - start) / cachep->size;

This looks wee bit fishy to me. You probably want to cast to "(unsigned long)" and make "objnr" unsigned long.

mm/slub.c static int __init slab_proc_init(void) · line 4751

Quoted 2 lines
mm/slub.c +2 -0
+	objp = start + cachep->size * objnr;
+	if (on_freelist(cachep, page, objp)) {

You could do

if (!on_freelist(cachep, page, objp))

       return;

to reduce nesting here.

mm/slub.c static int __init slab_proc_init(void) · line 4755

Quoted 4 lines
mm/slub.c +4 -0
+		printk(KERN_ERR "ptr: %p, sz: %d, location: %s\n",
+				ptr, sz, location);
+		printk(KERN_ERR "write to freed object, size %d\n",
+				cachep->size);

Can we make this error message more readable? Something like

printk(KERN_ERR "%s: Write to free'd object %p (size=%d) in %s\n",

         s->name, ptr, size, location);

mm/slub.c static int __init slab_proc_init(void) · line 4759

Quoted 4 lines
mm/slub.c +4 -0
+		print_tracking(cachep, objp);
+		dump_stack();
+	}
+}

don't we need

  EXPORT_SYMBOL(check_slab_write);

here?

mm/slub.c static int __init slab_proc_init(void) · line 4760

Quoted 1 line
mm/slub.c +1 -0
+#endif

Pekka