Skip to contentSkip to conversation

DHCP regression on 2009-06

PATCH In review Michael Zaidman 3 participants 3 messages Jul 14, 2009 – Jul 21, 2009 Networking

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 DHCP regression on 2009-06

Fixed the DHCP/BOOTP/RARP regression introduced in u-boot-2009.06 by initializing our IP addr to 0 in order to accept any IP addr assigned to us by the DHCP/BOOTP/RARP server.

---
 net/net.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)
net/net.c +3 -0
index 5637cf5..9bd3208 100644
@@ -388,17 +388,20 @@ restart:
 #if defined(CONFIG_CMD_DHCP)
 		case DHCP:
 			BootpTry = 0;
+			NetOurIP = 0;
 			DhcpRequest();		/* Basically same as BOOTP */
 			break;
 #endif
 
 		case BOOTP:
 			BootpTry = 0;
+			NetOurIP = 0;
 			BootpRequest ();
 			break;
 
 		case RARP:
 			RarpTry = 0;
+			NetOurIP = 0;
 			RarpRequest ();
 			break;
 #if defined(CONFIG_CMD_PING)
Signature · 1 line
1.6.0.4
#1 lore raw

[U-Boot] unassigned-patches/39: [PATCH] DHCP regression on 2009-06

Fixed the DHCP/BOOTP/RARP regression introduced in u-boot-2009.06 by initializing our IP addr to 0 in order to accept any IP addr assigned to us by the DHCP/BOOTP/RARP server.

---
Added to GNATS database as unassigned-patches/39

Quoted 5 lines
Responsible:    patch-coord
Message-Id:     <[email protected]>

In-Reply-To:
References:
Patch-Date: Tue Jul 14 22:37:12 +0200 2009

---
 net/net.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)
net/net.c +3 -0
index 5637cf5..9bd3208 100644
@@ -388,17 +388,20 @@ restart:
 #if defined(CONFIG_CMD_DHCP)
 		case DHCP:
 			BootpTry = 0;
+			NetOurIP = 0;
 			DhcpRequest();		/* Basically same as BOOTP */
 			break;
 #endif
 
 		case BOOTP:
 			BootpTry = 0;
+			NetOurIP = 0;
 			BootpRequest ();
 			break;
 
 		case RARP:
 			RarpTry = 0;
+			NetOurIP = 0;
 			RarpRequest ();
 			break;
 #if defined(CONFIG_CMD_PING)
Signature · 1 line
1.6.0.4
Applied
#2 lore raw

PATCH 1/1 DHCP regression on 2009-06

In reply to Michael Zaidman

Michael,

Quoted 26 lines · Michael Zaidman

Fixed the DHCP/BOOTP/RARP regression introduced in u-boot-2009.06 by initializing our IP addr to 0 in order to accept any IP addr assigned to us by the DHCP/BOOTP/RARP server.

---
 net/net.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)
net/net.c +1 -0
index 5637cf5..9bd3208 100644
@@ -388,17 +388,20 @@ restart:
 #if defined(CONFIG_CMD_DHCP)
 		case DHCP:
 			BootpTry = 0;
+			NetOurIP = 0;
 			DhcpRequest();		/* Basically same as BOOTP */
 			break;
 #endif
 
 		case BOOTP:
 			BootpTry = 0;

net/net.c restart: · line 407

Quoted 10 lines
net/net.c +2 -0
+			NetOurIP = 0;
 			BootpRequest ();
 			break;
 
 		case RARP:
 			RarpTry = 0;
+			NetOurIP = 0;
 			RarpRequest ();
 			break;
 #if defined(CONFIG_CMD_PING)

Applied to net repo.

thanks,
Ben