Skip to contentSkip to conversation

fix omap3 sram virtual addres overlap vmalloc space after increasing vmalloc size

PATCH In review Janboe Ye 3 participants 5 messages Jul 16, 2009 – Aug 5, 2009

Subsystems (2)
lore
Share & tools
lore

Janboe Ye

author
#0 lore raw

PATCH 1/1 fix omap3 sram virtual addres overlap vmalloc space after increasing vmalloc size

resend for mini coding style fixing

commit e85c205ac1427f2405021a36f083280ff0d0a35e increase vmalloc size. vmalloc space will overlap with OMAP3 sram virtual address.

---
 arch/arm/plat-omap/sram.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
arch/arm/plat-omap/sram.c +2 -2
index a2e60e7..755ccaa 100644
@@ -41,9 +41,9 @@
 #define OMAP2_SRAM_VA          0xe3000000
 #define OMAP2_SRAM_PUB_VA      (OMAP2_SRAM_VA + 0x800)
 #define OMAP3_SRAM_PA           0x40200000
-#define OMAP3_SRAM_VA           0xd7000000
+#define OMAP3_SRAM_VA           0xe3000000
 #define OMAP3_SRAM_PUB_PA       0x40208000
-#define OMAP3_SRAM_PUB_VA       0xd7008000
+#define OMAP3_SRAM_PUB_VA       (OMAP3_SRAM_VA + 0x8000)
 
 #if defined(CONFIG_ARCH_OMAP24XX) || defined(CONFIG_ARCH_OMAP34XX)
 #define SRAM_BOOTLOADER_SZ     0x00
Reviewed-by on v1 1/1
#1 lore raw
Quoted 4 lines · Janboe Ye

resend for mini coding style fixing

commit e85c205ac1427f2405021a36f083280ff0d0a35e increase vmalloc size. vmalloc space will overlap with OMAP3 sram virtual address.

Makes sense to me. I'm not sure how we missed this in the original patch.

- Paul

Quoted 14 lines
---
 arch/arm/plat-omap/sram.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
arch/arm/plat-omap/sram.c +0 -0
index a2e60e7..755ccaa 100644
@@ -41,9 +41,9 @@
 #define OMAP2_SRAM_VA          0xe3000000

arch/arm/plat-omap/sram.c line 49

Quoted 10 lines
arch/arm/plat-omap/sram.c +2 -2
 #define OMAP2_SRAM_PUB_VA      (OMAP2_SRAM_VA + 0x800)
 #define OMAP3_SRAM_PA           0x40200000
-#define OMAP3_SRAM_VA           0xd7000000
+#define OMAP3_SRAM_VA           0xe3000000
 #define OMAP3_SRAM_PUB_PA       0x40208000
-#define OMAP3_SRAM_PUB_VA       0xd7008000
+#define OMAP3_SRAM_PUB_VA       (OMAP3_SRAM_VA + 0x8000)
 
 #if defined(CONFIG_ARCH_OMAP24XX) || defined(CONFIG_ARCH_OMAP34XX)
 #define SRAM_BOOTLOADER_SZ     0x00

- Paul

author
#2 lore raw

Thanks, Paul

Tony

Is there some issue about this patch?

Thanks

Janboe Ye

Quoted 40 lines · Paul Walmsley
Quoted 4 lines · Janboe Ye

resend for mini coding style fixing

commit e85c205ac1427f2405021a36f083280ff0d0a35e increase vmalloc size. vmalloc space will overlap with OMAP3 sram virtual address.

Makes sense to me. I'm not sure how we missed this in the original patch.

- Paul

Quoted 14 lines
---
 arch/arm/plat-omap/sram.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
arch/arm/plat-omap/sram.c +0 -0
index a2e60e7..755ccaa 100644
@@ -41,9 +41,9 @@
 #define OMAP2_SRAM_VA          0xe3000000

arch/arm/plat-omap/sram.c line 49

Quoted 10 lines
arch/arm/plat-omap/sram.c +2 -2
 #define OMAP2_SRAM_PUB_VA      (OMAP2_SRAM_VA + 0x800)
 #define OMAP3_SRAM_PA           0x40200000
-#define OMAP3_SRAM_VA           0xd7000000
+#define OMAP3_SRAM_VA           0xe3000000
 #define OMAP3_SRAM_PUB_PA       0x40208000
-#define OMAP3_SRAM_PUB_VA       0xd7008000
+#define OMAP3_SRAM_PUB_VA       (OMAP3_SRAM_VA + 0x8000)
 
 #if defined(CONFIG_ARCH_OMAP24XX) || defined(CONFIG_ARCH_OMAP34XX)
 #define SRAM_BOOTLOADER_SZ     0x00

- Paul

#3 lore raw
Quoted 5 lines · Janboe Ye

Thanks, Paul

Tony

Is there some issue about this patch?

Tony's on vacation right now, so you shouldn't expect a response from him until he returns.

http://www.mail-archive.com/[email protected]/msg14015.html

- Paul

Quoted 47 lines

Thanks

Janboe Ye

Quoted 40 lines · Paul Walmsley
Quoted 4 lines · Janboe Ye

resend for mini coding style fixing

commit e85c205ac1427f2405021a36f083280ff0d0a35e increase vmalloc size. vmalloc space will overlap with OMAP3 sram virtual address.

Makes sense to me. I'm not sure how we missed this in the original patch.

- Paul

Quoted 14 lines
---
 arch/arm/plat-omap/sram.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
arch/arm/plat-omap/sram.c +0 -0
index a2e60e7..755ccaa 100644
@@ -41,9 +41,9 @@
 #define OMAP2_SRAM_VA          0xe3000000

arch/arm/plat-omap/sram.c line 49

Quoted 10 lines
arch/arm/plat-omap/sram.c +2 -2
 #define OMAP2_SRAM_PUB_VA      (OMAP2_SRAM_VA + 0x800)
 #define OMAP3_SRAM_PA           0x40200000
-#define OMAP3_SRAM_VA           0xd7000000
+#define OMAP3_SRAM_VA           0xe3000000
 #define OMAP3_SRAM_PUB_PA       0x40208000
-#define OMAP3_SRAM_PUB_VA       0xd7008000
+#define OMAP3_SRAM_PUB_VA       (OMAP3_SRAM_VA + 0x8000)
 
 #if defined(CONFIG_ARCH_OMAP24XX) || defined(CONFIG_ARCH_OMAP34XX)
 #define SRAM_BOOTLOADER_SZ     0x00

- Paul

- Paul

#4 lore raw
Quoted 4 lines · Paul Walmsley
Quoted 2 lines · Janboe Ye

Thanks, Paul

Quoted 8 lines
Quoted 3 lines

Tony

Is there some issue about this patch?

Tony's on vacation right now, so you shouldn't expect a response from him until he returns.

http://www.mail-archive.com/[email protected]/msg14015.html

I've added this patch to my omap-fixes queue, had to apply it manually because of the omap4 defines.

Tony

Quoted 54 lines

- Paul

Quoted 47 lines

Thanks

Janboe Ye

Quoted 40 lines · Paul Walmsley
Quoted 4 lines · Janboe Ye

resend for mini coding style fixing

commit e85c205ac1427f2405021a36f083280ff0d0a35e increase vmalloc size. vmalloc space will overlap with OMAP3 sram virtual address.

Makes sense to me. I'm not sure how we missed this in the original patch.

- Paul

Quoted 14 lines
---
 arch/arm/plat-omap/sram.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
arch/arm/plat-omap/sram.c +0 -0
index a2e60e7..755ccaa 100644
@@ -41,9 +41,9 @@
 #define OMAP2_SRAM_VA          0xe3000000

arch/arm/plat-omap/sram.c line 49

Quoted 10 lines
arch/arm/plat-omap/sram.c +2 -2
 #define OMAP2_SRAM_PUB_VA      (OMAP2_SRAM_VA + 0x800)
 #define OMAP3_SRAM_PA           0x40200000
-#define OMAP3_SRAM_VA           0xd7000000
+#define OMAP3_SRAM_VA           0xe3000000
 #define OMAP3_SRAM_PUB_PA       0x40208000
-#define OMAP3_SRAM_PUB_VA       0xd7008000
+#define OMAP3_SRAM_PUB_VA       (OMAP3_SRAM_VA + 0x8000)
 
 #if defined(CONFIG_ARCH_OMAP24XX) || defined(CONFIG_ARCH_OMAP34XX)
 #define SRAM_BOOTLOADER_SZ     0x00

- Paul

- Paul