Skip to contentSkip to conversation

mx27: rename fec_imx27 to fec_mxc

PATCH New Ilya Yanok 2 participants 3 messages Jul 17, 2009

lore
Share & tools
lore

Ilya Yanok

author
#0 lore raw

PATCH 1/1 mx27: rename fec_imx27 to fec_mxc

---
 cpu/arm926ejs/mx27/generic.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
cpu/arm926ejs/mx27/generic.c +1 -1
index b377fad..cbb6c85 100644
@@ -165,7 +165,7 @@ int print_cpuinfo (void)
 
 int cpu_eth_init(bd_t *bis)
 {
-#if defined(CONFIG_FEC_IMX27)
+#if defined(CONFIG_FEC_MXC)
 	return fecimx27_initialize(bis);
 #else
 	return 0;
Signature · 1 line
1.6.0.6
#1 lore raw

PATCH 1/1 mx27: rename fec_imx27 to fec_mxc

Dear Ilya Yanok,

Quoted 11 lines · In message <[email protected]> you wrote:
---
 cpu/arm926ejs/mx27/generic.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
cpu/arm926ejs/mx27/generic.c +0 -0
index b377fad..cbb6c85 100644

cpu/arm926ejs/mx27/generic.c int print_cpuinfo (void) · line 169

Quoted 6 lines
cpu/arm926ejs/mx27/generic.c +1 -1
@@ -165,7 +165,7 @@ int print_cpuinfo (void)
 
 int cpu_eth_init(bd_t *bis)
 {
-#if defined(CONFIG_FEC_IMX27)
+#if defined(CONFIG_FEC_MXC)
 	return fecimx27_initialize(bis);

See Ben's comment - renaming the CONFIG_ variable but leaving fecimx27_initialize() makes no sense.

And this should be no separate patch, but squashed into the patch that adds the cpu_eth_init() code.

Best regards,

Wolfgang Denk

Signature · 5 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"The trouble with doing something right the first time is that nobody
appreciates how difficult it was."                        - Walt West
author
#2 lore raw

PATCH 1/1 mx27: rename fec_imx27 to fec_mxc

Hi Wolfgang,

Quoted 11 lines · Wolfgang Denk
Quoted 11 lines
---
 cpu/arm926ejs/mx27/generic.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
cpu/arm926ejs/mx27/generic.c +0 -0
index b377fad..cbb6c85 100644
@@ -165,7 +165,7 @@ int print_cpuinfo (void)
 
Quoted 10 lines

cpu/arm926ejs/mx27/generic.c int print_cpuinfo (void)

Quoted 6 lines
cpu/arm926ejs/mx27/generic.c +1 -1
 int cpu_eth_init(bd_t *bis)
 {
-#if defined(CONFIG_FEC_IMX27)
+#if defined(CONFIG_FEC_MXC)
 	return fecimx27_initialize(bis);
 

See Ben's comment - renaming the CONFIG_ variable but leaving fecimx27_initialize() makes no sense.

Yes. That's my fault. I'll fix this and repost the patches.

Quoted 3 lines

And this should be no separate patch, but squashed into the patch that adds the cpu_eth_init() code.

Surely. I'll fix this too.

Regards, Ilya.