Skip to contentSkip to conversation

Revsion 2 of the security processor kernel driver;

PATCH In review Mark Allyn 3 participants 3 messages Jul 23, 2009 – Jul 31, 2009 Staging

lore
Share & tools
lore

Mark Allyn

author
#0 lore raw

PATCH 1/1 Revsion 2 of the security processor kernel driver;

For the upstream community, this is revision 2. Changes are the relocation of this driver to the staging area.

This is the Linux kernel driver for the Security Processor, which is a hardware device the provides cryptographic, secure storage, and key management services.

Please be aware that this patch does not contain any encryption algorithm. It only transports data to and from user space applications to the security processor.

Date: July 23, 2009

---
 drivers/staging/Kconfig                       |    2 +
 drivers/staging/Makefile                      |    1 +
 drivers/staging/sep/Kconfig                   |    9 +
 drivers/staging/sep/Makefile                  |    3 +
 drivers/staging/sep/sep_driver_api.h          |  545 ++++
 drivers/staging/sep/sep_driver_config.h       |  305 ++
 drivers/staging/sep/sep_driver_ext_api.h      |  106 +
 drivers/staging/sep/sep_driver_hw_defs.h      |  240 ++
 drivers/staging/sep/sep_ext_with_pci_driver.c |  631 ++++
 drivers/staging/sep/sep_main_mod.c            | 3919 +++++++++++++++++++++++++
 kernel-mrst-alpha2.config                     |    1 +
 11 files changed, 5762 insertions(+), 0 deletions(-)
 create mode 100644 drivers/staging/sep/Kconfig
 create mode 100644 drivers/staging/sep/Makefile
 create mode 100644 drivers/staging/sep/sep_driver_api.h
 create mode 100644 drivers/staging/sep/sep_driver_config.h
 create mode 100644 drivers/staging/sep/sep_driver_ext_api.h
 create mode 100644 drivers/staging/sep/sep_driver_hw_defs.h
 create mode 100644 drivers/staging/sep/sep_ext_with_pci_driver.c
 create mode 100644 drivers/staging/sep/sep_main_mod.c
drivers/staging/Kconfig +2 -0
index 348bf61..af480a6 100644
@@ -129,5 +129,7 @@ source "drivers/staging/pata_rdc/Kconfig"
 
 source "drivers/staging/udlfb/Kconfig"
 
+source "drivers/staging/sep/Kconfig"
+
 endif # !STAGING_EXCLUDE_BUILD
 endif # STAGING
drivers/staging/Makefile +1 -0
index 8d61d7b..f050bbe 100644
@@ -46,3 +46,4 @@ obj-$(CONFIG_VT6655)		+= vt6655/
 obj-$(CONFIG_USB_CPC)		+= cpc-usb/
 obj-$(CONFIG_RDC_17F3101X)	+= pata_rdc/
 obj-$(CONFIG_FB_UDL)		+= udlfb/
+obj-$(CONFIG_DX_SEP)		+= sep/
drivers/staging/sep/Kconfig new file +9 -0
new file mode 100644
index 0000000..1a4514d
@@ -0,0 +1,9 @@
+config DX_SEP
+	tristate "Discretix SEP driver"
+	depends on MRST
+	default y
+	help
+	  Discretix SEP driver
+
+	  If unsure say M. The compiled module will be
+	  called sep_driver.ko
drivers/staging/sep/Makefile new file +3 -0
new file mode 100644
index 0000000..2e0c4cb
@@ -0,0 +1,3 @@
+EXTRA_CFLAGS += -DLITTLE__ENDIAN -DDX_CC5_SEP_PLAT -DCRYS_NO_EXT_IF_MODE_SUPPORT
+obj-$(CONFIG_DX_SEP) := sep_driver.o
+sep_driver-objs := sep_main_mod.o sep_ext_with_pci_driver.o
drivers/staging/sep/sep_driver_api.h new file +545 -0

545 lines not on this page · raw message

drivers/staging/sep/sep_driver_config.h new file +305 -0

305 lines not on this page · raw message

drivers/staging/sep/sep_driver_ext_api.h new file +106 -0

106 lines not on this page · raw message

drivers/staging/sep/sep_driver_hw_defs.h new file +240 -0

240 lines not on this page · raw message

drivers/staging/sep/sep_ext_with_pci_driver.c new file +631 -0

631 lines not on this page · raw message

drivers/staging/sep/sep_main_mod.c new file +3919 -0

1,150 lines not on this page · raw message

kernel-mrst-alpha2.config +1 -0
index 1f73364..d803dbd 100644

Lines of this file are not shown. View the raw message.

The rest of this diff is not shown. View the raw message.

Signature · 1 line
1.6.0.6

Part of the diff is not shown here. View the raw message.

#1 lore raw
Quoted 7 lines · Mark Allyn

For the upstream community, this is revision 2. Changes are the relocation of this driver to the staging area.

This is the Linux kernel driver for the Security Processor, which is a hardware device the provides cryptographic, secure storage, and key management services.

Quoted 5 lines

Please be aware that this patch does not contain any encryption algorithm. It only transports data to and from user space applications to the security processor.

Can you provide me a TODO file that lists what is remaining to be done to this driver in order to get it accepted into the main portion of the kernel tree?

And do that with the patch itself, so it would require a respin of this one?

thanks,

greg k-h

#2 lore raw
Quoted 12 lines · On Thu, 23 Jul 2009 17:24:39 -0700 Greg KH <[email protected]> wrote:
Quoted 11 lines · Mark Allyn

For the upstream community, this is revision 2. Changes are the relocation of this driver to the staging area.

This is the Linux kernel driver for the Security Processor, which is a hardware device the provides cryptographic, secure storage, and key management services.

Please be aware that this patch does not contain any encryption algorithm. It only transports data to and from user space applications to the security processor.

Quoted 5 lines
Quoted 1 line

Can you provide me a TODO file that lists what is remaining to be done to this driver in order to get it accepted into the main portion of the kernel tree?

My guesses would be something like

- Fix firmware loading
- Get firmware into firmware git tree
- Review and tidy each algorithm function
- Check whether it can be plugged into any of the kernel crypto API interfaces
- Do something about the magic shared memory interface and replace it with something saner (in Linux terms)

The last one is non-trivial. The other security processors we have support for also have fairly disgusting interfaces as do most of the user space crypto library plugins. It doesn't seem to be something that structures nicely (eg see the zSystem crypto driver we have now).

We may thus have to simply accept "Less ugly" unless anyone can point me at a clean, well designed crypto processor API we could use.

Alan