Skip to contentSkip to conversation

<no subject>

DISCUSSION Joachim Bremer 1 participant 1 message Aug 29, 2004

lore
Share & tools
lore
#0 lore raw

Nick Piggin <[email protected]> schrieb am 29.08.04 14:43:43:

Quoted 9 lines
Quoted 7 lines · Joachim Bremer

As mentioned before I got even with Nicks patch some errors. Looking closer at the source there is is a second "goto page_ok" a few lines down the label "page_not_up_to_date". Inserting the same calculating code used before the label "readpage_error" fixes the errors on my machine. These for instance where failure to do reiserfsck (bread complains on last block of device) and compiling the linux-tree (file truncated).

Quoted 7 lines
Quoted 2 lines

The leads to the same calculation 3 times...

Surely not - there is only 1 way to get to page_not_up_to_date, and through that path you have already done that calculation and none of the variables involved have been changed.

Sure I backed out the other patch - but you are right. It does magically work now with your patch only. maybe it was an interaction with the sound driver which hangs on shutdown so maybe there where some transactions not written or replayed.

Thanks

Joachim

Quoted 6 lines

I think. Put a printk before your goto out, and if it triggers then I am wrong.

What errors were you seeing with my patch? (If you applied my patch to an -mm kernel without first backing out the others then it will break).

_______________________________________________________________
SMS schreiben mit WEB.DE FreeMail - einfach, schnell und kostenguenstig. Jetzt gleich testen! http://f.web.de/?mc=021192