Skip to contentSkip to conversation

block: fix improper kobject release in blk_integrity_unregister

PATCH Applied Xiaotian Feng 2 participants 2 messages Jul 24, 2009 – Jul 28, 2009 Block layer

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 block: fix improper kobject release in blk_integrity_unregister

blk_integrity_unregister should use kobject_put to release the kobject, otherwise after bi is freed, memory of bi->kobj->name is leaked.

---
 block/blk-integrity.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
block/blk-integrity.c +1 -0
index 73e28d3..15c6308 100644
@@ -379,6 +379,7 @@ void blk_integrity_unregister(struct gendisk *disk)
 
 	kobject_uevent(&bi->kobj, KOBJ_REMOVE);
 	kobject_del(&bi->kobj);
+	kobject_put(&bi->kobj);
 	kmem_cache_free(integrity_cachep, bi);
 	disk->integrity = NULL;
 }
Signature · 1 line
1.6.2.5
Applied
#1 lore raw
Quoted 2 lines · Xiaotian Feng

blk_integrity_unregister should use kobject_put to release the kobject, otherwise after bi is freed, memory of bi->kobj->name is leaked.

Applied, thanks.

Quoted 21 lines
---
 block/blk-integrity.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
block/blk-integrity.c +1 -0
index 73e28d3..15c6308 100644
@@ -379,6 +379,7 @@ void blk_integrity_unregister(struct gendisk *disk)
 
 	kobject_uevent(&bi->kobj, KOBJ_REMOVE);
 	kobject_del(&bi->kobj);
+	kobject_put(&bi->kobj);
 	kmem_cache_free(integrity_cachep, bi);
 	disk->integrity = NULL;
 }
Signature · 1 line
1.6.2.5
Signature · 1 line
Jens Axboe