Travis failures
Hi Cyril,
quite often I see in my travis builds liblitpnuma.a related failures [1] (one random out-of-tree build), which gets fixed by restarting it. Any idea why?
Kind regards,
Petr
make[4]: Leaving directory '/usr/src/ltp-build/testcases/kernel/syscalls/splice'
make[4]: Entering directory '/usr/src/ltp-build/testcases/kernel/syscalls/set_mempolicy'
make -C "/usr/src/ltp-build/libs/libltpnuma" -f "/usr/src/ltp-build/libs/libltpnuma/Makefile" all make[5]: Entering directory '/usr/src/ltp-build/libs/libltpnuma'
make[5]: /usr/src/ltp-build/libs/libltpnuma/Makefile: No such file or directory
make[5]: *** No rule to make target '/usr/src/ltp-build/libs/libltpnuma/Makefile'. Stop. make[5]: Leaving directory '/usr/src/ltp-build/libs/libltpnuma' /usr/src/ltp/include/mk/testcases.mk:52: recipe for target '/usr/src/ltp-build/libs/libltpnuma/libltpnuma.a' failed make[4]: *** [/usr/src/ltp-build/libs/libltpnuma/libltpnuma.a] Error 2
make[4]: Leaving directory '/usr/src/ltp-build/testcases/kernel/syscalls/set_mempolicy' /usr/src/ltp/include/mk/generic_trunk_target.inc:93: recipe for target 'all' failed
make[3]: *** [all] Error 2
make[3]: Leaving directory '/usr/src/ltp-build/testcases/kernel/syscalls' /usr/src/ltp/include/mk/generic_trunk_target.inc:93: recipe for target 'all' failed
make[2]: *** [all] Error 2
make[2]: Leaving directory '/usr/src/ltp-build/testcases/kernel' /usr/src/ltp/include/mk/generic_trunk_target.inc:93: recipe for target 'all' failed
make[1]: *** [all] Error 2
make[1]: Leaving directory '/usr/src/ltp-build/testcases'/usr/src/ltp/Makefile:119: recipe for target 'testcases-all' failed
make: *** [testcases-all] Error 2
make: Leaving directory '/usr/src/ltp-build'
----- Original Message -----
Quoted 4 lines
Hi Cyril,
quite often I see in my travis builds liblitpnuma.a related failures [1] (one random out-of-tree build), which gets fixed by restarting it. Any idea why?
Looks like when it gets built via ./libs it works, but if it's pulled as dependency first, it fails:
# make -C $(pwd)/../ltp-build/testcases/kernel/syscalls/set_mempolicy/ -f $(pwd)/testcases/kernel/syscalls/set_mempolicy/Makefile top_srcdir=$(pwd) top_builddir=$(pwd)/../ltp-build make: Entering directory `/root/ltp-build/testcases/kernel/syscalls/set_mempolicy' make -C "/root/ltp-build/libs/libltpnuma" -f "/root/ltp-build/libs/libltpnuma/Makefile" all make[1]: Entering directory `/root/ltp-build/libs/libltpnuma' make[1]: /root/ltp-build/libs/libltpnuma/Makefile: No such file or directory make[1]: *** No rule to make target `/root/ltp-build/libs/libltpnuma/Makefile'. Stop. make[1]: Leaving directory `/root/ltp-build/libs/libltpnuma' make: *** [/root/ltp-build/libs/libltpnuma/libltpnuma.a] Error 2 make: Leaving directory `/root/ltp-build/testcases/kernel/syscalls/set_mempolicy'
Maybe something like this to fix it?
include/mk/testcases.mk +2 -2
@@ -43,13 +43,13 @@ LDLIBS += -lltp ifdef LTPLIBS -LTPLIBS_DIRS = $(addprefix $(abs_top_builddir)/libs/lib, $(LTPLIBS)) +LTPLIBS_DIRS = $(LTPLIBS) LTPLIBS_FILES = $(addsuffix .a, $(addprefix $(abs_top_builddir)/libs/, $(foreach LIB,$(LTPLIBS),lib$(LIB)/lib$(LIB)))) MAKE_DEPS += $(LTPLIBS_FILES) $(LTPLIBS_FILES): $(LTPLIBS_DIRS) - $(MAKE) -C "$^" -f "$^/Makefile" all + $(MAKE) -C "$(addprefix $(abs_top_builddir)/libs/lib, $^)" -f "$(addprefix $(abs_top_srcdir)/libs/lib, $^)/Makefile" all LDFLAGS += $(addprefix -L$(top_builddir)/libs/lib, $(LTPLIBS))
Quoted 39 lines
Kind regards,
Petrmake[4]: Leaving directory '
/usr/src/ltp-build/testcases/kernel/syscalls/splice'
make[4]: Entering directory '/usr/src/ltp-build/testcases/kernel/syscalls/set_mempolicy' make -C "/usr/src/ltp-build/libs/libltpnuma" -f "/usr/src/ltp-build/libs/libltpnuma/Makefile" all
make[5]: Entering directory '/usr/src/ltp-build/libs/libltpnuma' make[5]:/usr/src/ltp-build/libs/libltpnuma/Makefile: No such file or directory
make[5]: *** No rule to make target '/usr/src/ltp-build/libs/libltpnuma/Makefile'. Stop.
make[5]: Leaving directory '/usr/src/ltp-build/libs/libltpnuma'/usr/src/ltp/include/mk/testcases.mk:52: recipe for target '/usr/src/ltp-build/libs/libltpnuma/libltpnuma.a' failed make[4]: *** [/usr/src/ltp-build/libs/libltpnuma/libltpnuma.a] Error 2 make[4]: Leaving directory '/usr/src/ltp-build/testcases/kernel/syscalls/set_mempolicy'/usr/src/ltp/include/mk/generic_trunk_target.inc:93: recipe for target 'all' failed
make[3]: *** [all] Error 2
make[3]: Leaving directory '/usr/src/ltp-build/testcases/kernel/syscalls'/usr/src/ltp/include/mk/generic_trunk_target.inc:93: recipe for target 'all' failed
make[2]: *** [all] Error 2
make[2]: Leaving directory '/usr/src/ltp-build/testcases/kernel'/usr/src/ltp/include/mk/generic_trunk_target.inc:93: recipe for target 'all' failed
make[1]: *** [all] Error 2
make[1]: Leaving directory '/usr/src/ltp-build/testcases'/usr/src/ltp/Makefile:119: recipe for target 'testcases-all' failed
make: *** [testcases-all] Error 2
make: Leaving directory '/usr/src/ltp-build'
Hi!
Quoted 5 lines
Quoted 2 lines
quite often I see in my travis builds liblitpnuma.a related failures [1] (one random out-of-tree build), which gets fixed by restarting it. Any idea why?
Looks like when it gets built via ./libs it works, but if it's pulled as dependency first, it fails:
Which is bug itself, we have to build it via libs otherwise this will break if more than one of these directories will pull it as dependency at the same time.
Quoted 19 lines
# make -C $(pwd)/../ltp-build/testcases/kernel/syscalls/set_mempolicy/ -f $(pwd)/testcases/kernel/syscalls/set_mempolicy/Makefile top_srcdir=$(pwd) top_builddir=$(pwd)/../ltp-build make: Entering directory `/root/ltp-build/testcases/kernel/syscalls/set_mempolicy' make -C "/root/ltp-build/libs/libltpnuma" -f "/root/ltp-build/libs/libltpnuma/Makefile" all make[1]: Entering directory `/root/ltp-build/libs/libltpnuma' make[1]: /root/ltp-build/libs/libltpnuma/Makefile: No such file or directory make[1]: *** No rule to make target `/root/ltp-build/libs/libltpnuma/Makefile'. Stop. make[1]: Leaving directory `/root/ltp-build/libs/libltpnuma' make: *** [/root/ltp-build/libs/libltpnuma/libltpnuma.a] Error 2 make: Leaving directory `/root/ltp-build/testcases/kernel/syscalls/set_mempolicy'Maybe something like this to fix it?
include/mk/testcases.mk +0
-0@@ -43,13 +43,13 @@ LDLIBS += -lltp ifdef LTPLIBS
include/mk/testcases.mk LDLIBS += -lltp · line 52
Quoted 10 lines
include/mk/testcases.mk +2
-2-LTPLIBS_DIRS = $(addprefix $(abs_top_builddir)/libs/lib, $(LTPLIBS)) +LTPLIBS_DIRS = $(LTPLIBS) LTPLIBS_FILES = $(addsuffix .a, $(addprefix $(abs_top_builddir)/libs/, $(foreach LIB,$(LTPLIBS),lib$(LIB)/lib$(LIB)))) MAKE_DEPS += $(LTPLIBS_FILES) $(LTPLIBS_FILES): $(LTPLIBS_DIRS) - $(MAKE) -C "$^" -f "$^/Makefile" all + $(MAKE) -C "$(addprefix $(abs_top_builddir)/libs/lib, $^)" -f "$(addprefix $(abs_top_srcdir)/libs/lib, $^)/Makefile" all
Well we can use LTPLIBS directly here, and there is no need to use addprefix if we are not applying the change to a set, so I guess that following will work as well:
$(MAKE) -C "$(abs_top_builddir)/libs/lib)$^" -f "$(abs_top_srcdir)/libs/lib)$^/Makefile" all
Otherwise this is a good catch, acked.
Signature · 2 lines
Cyril Hrubis [email protected]
----- Original Message -----
Quoted 38 lines
Hi!
Quoted 7 lines
Quoted 4 lines
quite often I see in my travis builds liblitpnuma.a related failures [1] (one
random out-of-tree build), which gets fixed by restarting it. Any idea why?Looks like when it gets built via ./libs it works, but if it's pulled as dependency first, it fails:
Which is bug itself, we have to build it via libs otherwise this will break if more than one of these directories will pull it as dependency at the same time.
Quoted 25 lines
# make -C $(pwd)/../ltp-build/testcases/kernel/syscalls/set_mempolicy/ -f $(pwd)/testcases/kernel/syscalls/set_mempolicy/Makefile top_srcdir=$(pwd) top_builddir=$(pwd)/../ltp-build make: Entering directory `/root/ltp-build/testcases/kernel/syscalls/set_mempolicy' make -C "/root/ltp-build/libs/libltpnuma" -f "/root/ltp-build/libs/libltpnuma/Makefile" all make[1]: Entering directory `/root/ltp-build/libs/libltpnuma' make[1]: /root/ltp-build/libs/libltpnuma/Makefile: No such file or directory make[1]: *** No rule to make target `/root/ltp-build/libs/libltpnuma/Makefile'. Stop. make[1]: Leaving directory `/root/ltp-build/libs/libltpnuma' make: *** [/root/ltp-build/libs/libltpnuma/libltpnuma.a] Error 2 make: Leaving directory `/root/ltp-build/testcases/kernel/syscalls/set_mempolicy'Maybe something like this to fix it?
include/mk/testcases.mk +0
-0@@ -43,13 +43,13 @@ LDLIBS += -lltp
Quoted 4 lines
include/mk/testcases.mk LDLIBS += -lltp · line 46
Quoted 4 lines
include/mk/testcases.mk +1
-1ifdef LTPLIBS -LTPLIBS_DIRS = $(addprefix $(abs_top_builddir)/libs/lib, $(LTPLIBS)) +LTPLIBS_DIRS = $(LTPLIBS)
This part is wrong, LTPLIBS_DIRS is also used for "mkdir" rule below. I'll post v2 properly.
Quoted 23 lines
Quoted 9 lines
include/mk/testcases.mk +1
-1LTPLIBS_FILES = $(addsuffix .a, $(addprefix $(abs_top_builddir)/libs/, $(foreach LIB,$(LTPLIBS),lib$(LIB)/lib$(LIB)))) MAKE_DEPS += $(LTPLIBS_FILES) $(LTPLIBS_FILES): $(LTPLIBS_DIRS) - $(MAKE) -C "$^" -f "$^/Makefile" all + $(MAKE) -C "$(addprefix $(abs_top_builddir)/libs/lib, $^)" -f"$(addprefix $(abs_top_srcdir)/libs/lib, $^)/Makefile" all
Well we can use LTPLIBS directly here, and there is no need to use addprefix if we are not applying the change to a set, so I guess that following will work as well:
$(MAKE) -C "$(abs_top_builddir)/libs/lib)$^" -f
"$(abs_top_srcdir)/libs/lib)$^/Makefile" allOtherwise this is a good catch, acked.
--
Cyril Hrubis
[email protected]
Hi Cyril, Jan,
Quoted 2 lines
quite often I see in my travis builds liblitpnuma.a related failures [1] (one random out-of-tree build), which gets fixed by restarting it. Any idea why?
Happen on master as well :( [1]. I've just restarted it so it should be ok, but a bit inconvenient :(.
[1] https://api.travis-ci.org/v3/job/507884079/log.txt
Kind regards,
Petr