Skip to contentSkip to conversation

powerpc/mm: Fix SMP issue with MMU context handling code

PATCH New Kumar Gala 1 participant 1 message Jul 30, 2009 PowerPC

lore
Share & tools
lore

Kumar Gala

author
#0 lore raw

PATCH 1/1 powerpc/mm: Fix SMP issue with MMU context handling code

In switch_mmu_context() if we call steal_context_smp() to get a context to use we shouldn't fall through and than call steal_context_up(). Doing so can be problematic in that the 'mm' that steal_context_up() ends up using will not get marked dirty in the stale_map[] for other CPUs that might have used that mm. Thus we could end up with stale TLB entries in the other CPUs that can cause all kinda of havoc.

---
 arch/powerpc/mm/mmu_context_nohash.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
arch/powerpc/mm/mmu_context_nohash.c +1 -0
index 92a1971..b1a727d 100644
@@ -217,6 +217,7 @@ void switch_mmu_context(struct mm_struct *prev, struct mm_struct *next)
 			id = steal_context_smp(id);
 			if (id == MMU_NO_CONTEXT)
 				goto again;
+			goto stolen;
 		}
 #endif /* CONFIG_SMP */
 		id = steal_context_up(id);
Signature · 1 line
1.6.0.6